path: root/src/modules/emotion (follow)
AgeCommit message (Collapse)Author
2021-09-26emotion - properly track subtitle mute state and init emotion obj earlyCarsten Haitzler (Rasterman)
fix setting things on an emotion obj early bu initting engine early and also track spu mute flags to set on pipe later @fix
2020-06-23Get rid of trailing whitespaces (13 / 14)Elyes HAOUAS
Remove trailing whitespaces Differential Revision:
2020-05-18Revert "Fix EAPI definition by defining EFL_BUILD for each built DLL"Carsten Haitzler (Rasterman)
This reverts commit 3ade45cbc82bea1772c7ad1afb7e1ba5dd67d930.
2020-05-18Fix EAPI definition by defining EFL_BUILD for each built DLLVincent Torri
Summary: EAPI must be defined to dllexport when building DLL, and to dllimport when using these DLL. To achieve this, define EFL_BUILD for each library and module, and set DLL_EXPORT unconditionally. Static library are and will be not supported Test Plan: compilation Reviewers: zmike, raster, jptiz Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision:
2020-04-07meson: support unified suffixes for modulesMarcel Hollerbach
A long story in a few words: sometimes on macos modules will be compiled into .dylib, sometimes, into .so suffix. We did not set the suffix everywhere in our meson build instructions, hence our suffixes have been differently, which resulted in random load fails on different maschines. With this commit, we ensure that we suffix all modules the same way. Reviewed-by: Mike Blumenkrantz <> Differential Revision:
2020-03-08remove vlc, gst-0.10, xine deps, modules as they are brokenCarsten Haitzler (Rasterman)
they dont work. easier to remove than fix, so... remove :) only gst 1.x supported now.
2019-12-04emotion & evas: remove gstreamer 0.10 supportStefan Schmidt
We have Gstreamer 1.x support for a long time already. We used to keep this around as fallback. By now Linux distributions start to actually no longer ship the Gstreamer 0.10.x packages and upstream has not seen a release in in 5 years. Time to remove it on our side as well. Signed-off-by: Stefan Schmidt <> Reviewed-by: Cedric BAIL <> Differential Revision:
2019-06-19build: emotion: fix lookup of gstreamer 0.10 dependencyStefan Schmidt
The pkg-config file for the 0.10 series of gstreamer is called gstreamer-0.10.pc and we need to correct name in the dependency check here to find it. Improving our CI coverage does spot bugs. :-) Reviewed-by: Marcel Hollerbach <> Differential Revision:
2019-06-19build: emotions: gstreamer: add needed ecore_x internal dependencyStefan Schmidt
The 0.10 gstreamer module needs Ecore_X.h during build. Make sure we actually have this dependency right so the build can succeed. Reviewed-by: Marcel Hollerbach <> Differential Revision:
2019-05-23Emotion gst1 module: fix "empty if statement" warningVincent Torri
Summary: the macro GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS can be undefined (see gst core doc), hence the if statement may have no body Test Plan: compilation Reviewers: zmike, raster, cedric, Hermet Reviewed By: Hermet Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-05-23Emotion gst1 module: remove whitespacesVincent Torri
Reviewers: zmike, cedric, raster, Hermet Reviewed By: Hermet Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-05-08Evil: remove wrapper around getcwd()Vincent Torri
Summary: getcwd() is declared in direct.h Test Plan: compilation Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision:
2019-05-06meson: do not build emotion generic loader on windowsMike Blumenkrantz
this is not supported Reviewed-by: Marcel Hollerbach <> Differential Revision:
2019-01-16emotion: gstreamer: fix deprecation warning for g_type_class_add_privateStefan Schmidt
Summary: Since glib 2.58 g_type_class_add_private is deprecated and this throws an ugly warning in our build. Not being a glib expert I based this on patch in freeverb which solves the same issue for them: Videos in rage are still playing fine for me, but double checking during review would be appreciated. Reviewers: raster Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision:
2018-12-07meson: add inital support for windows compilationMarcel Hollerbach
Differential Revision:
2018-10-02here comes mesonMarcel Hollerbach
a new shiny buildtool that currently completes in the total of ~ 4 min.. 1 min. conf time 2:30 min. build time Where autotools takes: 1:50 min. conf time 3:40 min. build time. meson was taken because it went quite good for enlightenment, and is a traction gaining system that is also used by other mayor projects. Additionally, the DSL that is defined my meson makes the configuration of the builds a lot easier to read. Further informations can be gathered from the README.meson Right now, bindings & windows support are missing. It is highly recommented to use meson 0.48 due to optimizations in meson that reduced the time the meson call would need. Co-authored-by: Mike Blumenkrantz <> Differential Revision: Depends on D7011
2018-09-18emotion: Convert to new animatorsDerek Foreman
Summary: Use more efficient animator mechanism. Depends on D7051 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision:
2018-06-21efl: include sys/types.h where ssize_t is usedDaniel Kolesa
This include is necessary according to POSIX. Without it, build fails on certain platforms (QNX). It may already be included implicitly in some of those files, but declare intent. Fixes T6667.
2018-06-19emotion_generic: clean up event handlers on fork failureMike Blumenkrantz
Summary: this case would guarantee a crash if the module was ever unloaded and the event handlers were called, and it leaks otherwise @fix Reviewers: ManMower, devilhorns, bu5hm4n Reviewed By: ManMower, bu5hm4n Subscribers: cedric, #committers Tags: #efl Differential Revision:
2018-01-06efl thread signal masks - fix up for various threads manually createdCarsten Haitzler (Rasterman)
so xine module plus 2 eina dbug threads didnt set up signal blocking/masks correctly. xine use ssigprocmask not pthread_sigmask and the other 2 didnt even bother at all. fix this so these threads all block most of these commnly caught signals so these threads never get them
2017-11-06emotion: Fix data race conditionChris Michael
Coverity reports that we access vfmapped here without holding a lock. This patch implements eina_lock_take/release while accessing priv->vfmapped. Fixes Coverity CID1381624 @fix Signed-off-by: Chris Michael <>
2017-10-11emotion: Properly unmap video frameChris Michael
Calls to gst_video_frame_unmap should take a GstVideoFrame as a parameter (not a buffer). I believe this was the intended function here (to unmap the video frame), so fix the call to not pass a GstBuffer. @fix Signed-off-by: Chris Michael <>
2017-10-07emotion gst1 - handle null imagwe data returrn and dont crashCarsten Haitzler (Rasterman)
fix crash i spotted thanks to getting img obbj data returning null. @fix
2017-08-29emotion: gst: use proper GStreamer time-unit macrosReynaldo H. Verdejo Pinochet
Summary: Do not harcode numbers that make no immediate sense. Additionally: add some wont-hurt doc note and fix two related typos. Subscribers: cedric, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2017-08-29emotion: gst: drop Frenglish from English messagesReynaldo H. Verdejo Pinochet
Subscribers: cedric, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2017-07-29emotion gst1 module - remove extra unneded if'sCarsten Haitzler (Rasterman)
not a bug, but don't need these found by PVS studio
2017-07-19emtoion gst1 - workaround gst break between 1.10 and 1.12Carsten Haitzler (Rasterman)
so emotion was using a much older (pre 1.0) buffer map mechanism for getting video data. a new frame map api was added to gst in 1.0 but we didnt use it. gst broke the old buffer direct mapping for some codecs paths between 1.10 and 1.12. since we were using a very old method/api this broke us. this also happens to fix some vaapi issues (except where the buffer is simply never mappable ever). so this is kind of a fix (updating us to as more modern api) and a workaround. @fix
2017-07-04Emotion: freed allocated string.Uma Devika
Summary: GStreamer API gst_caps_to_string returns allocated memory which needs to be freed with g_free() after use. @fix Signed-off-by: Uma Devika <> Reviewers: cedric, tasn, singh.amitesh, raster, jpeg Subscribers: tanwar.umesh07, yashu21985, cedric, jpeg Differential Revision:
2017-04-17Fix sed error that changed "video" to "videfl"Derek Foreman
commit c662934be8bcbaba60d1688e77533acbea5d09b9 seems to have accidentally renamed a few instances of _video_ to _videfl_, this hopefully changes them all back.
2017-04-16emotion - gstreamer1 - fix yuv import funcs to use gst stride + offsetCarsten Haitzler (Rasterman)
so our yuv import funcs for gstreamer 1.x engine were ignoring the plane offsets and strides provided by gstreamer. though this nicely shows that these numbers provided are actually wrong - at least in the testing with vaapi back-ends with gst. so this fixes emotions' badness but there is still badness in gst apparently. the numbers provided if used are just simply wrong for teh image data. commented code in the src to show how to "Fix it up" by forcing some alignment of content to get it to work. @fix
2017-03-31Fixes latest crash w/rageAl Poole
Summary: eina_file_virtualize is causing issues. memfile_set is better but see attached bt. What to do??? Reviewers: raster, cedric Subscribers: jpeg Differential Revision:
2017-02-23emotion XXX - make nv12 709 streams work even with slightly off colorsCarsten Haitzler (Rasterman)
ther eis no 709 nv12 support support in evas but there is 601, so use that for now until we add the feature of 709 nv12 support.
2017-01-19gstreamer buffer unref emotion: too many urefs! Seems I read the documention ↵Al Poole
incorrectly!!! Reviewers: raster, jpeg, cedric Reviewed By: raster Differential Revision:
2017-01-12emotion: add support for obtaining embedded artwork from media files with ↵Al Poole
gstreamer1 backend. Reviewers: raster, cedric Subscribers: cedric, jpeg Differential Revision: Signed-off-by: Cedric BAIL <>
2017-01-06eina: rename EINA_{FLT,DBL}_CMP to EINA_{FLT,DBL}_EQ.Cedric BAIL
2016-12-20emotion: remove float comparison warningsChris Michael
Signed-off-by: Chris Michael <>
2016-10-31emotion gst1 module - disable subtitles by default as that should beCarsten Haitzler (Rasterman)
there are spu apis to turn subtitles on and off and this should be off until turned on by api. you really have to be able to choose the subtitles to display - eg language etc. to use them effectively. this fixes T4795 @fix
2016-09-22modules: emotion: fix event name after EFL Canvas Video convertStefan Schmidt
In commit 7b90e1147442d6a8023422400bffd77e2815fe0b the event name changed but this module was not updated. Luckily we are building it on Jenkins or it would have gone unnoticed for a long time.
2016-08-30efl callbacks: update some events calls to no longer trigger legacy callbacksdevs/vitorsousa/update_event_callsVitor Sousa
2016-08-26Efl Object: remove legacy callback calls from event_callback_callVitor Sousa
Efl.Object.event_callback_call no longer calls legacy smart callbacks; calling only event callbacks registered with the given event description pointer. Create the method Efl.Object.event_callback_legacy_call to inherit the old behavior from Efl.Object.event_callback_call, calling both Efl.Object events and legacy smart callbacks. Update all other files accordingly in order to still supply legacy callbacks while they are necessary.
2016-08-15Eo: Finish the renaming of Eo to the EFL.Tom Hacohen
This renames all the rest of the API to the EFL namespace except for Eo_Event that will follow soon. Obviously breaks both API and ABI.
2016-08-11Change the EFL to follow the new Eo rename.Tom Hacohen
2016-07-24Gstreamer1: implement subtitles mute/unmute abilityDave Andreoli
This seems the only way to disable subtitles embedded in the video file. WIthout this patch calling em_spu_mute_set/get do not work, thus I consider this a @fix
2016-07-08emotion xine module - silence coverityCarsten Haitzler (Rasterman)
silence CID 1357140 as its harmless to not check fcntl here, but dont confuse coverity.
2016-07-08emotion vlc module - fix potential divide by 0Carsten Haitzler (Rasterman)
fix CID 1357146
2016-07-08emotion xine module - silence coverity complaintCarsten Haitzler (Rasterman)
getting the fd from a valid fd handler wont return < 0 but in theory it can, so just be silent coverity silence CID 1357155
2016-07-08emotion xine module - fix minor complaints but not bugsCarsten Haitzler (Rasterman)
silence CID 1357156 , 1357172
2016-07-08emotion libvlc module - fix possible argv init issue with tokensCarsten Haitzler (Rasterman)
fixes CID 1357170
2016-07-04efl - threads and signals - make efl work on "insane" os's with signalsCarsten Haitzler (Rasterman)
so. on linux signals are delivered to the main process thread/loop. thats' where signal handlers are set up and always run. this is sane. it's predicatble. but of course this is not the same in bsd land. there "just send the signal to any old thread and call the signal handler there" seems to tbe the order of the day. this explains why wer are losing sigchld signals in edje_cc - it's heavily threaded and bsd is just randombly picking a thread to call it on. this fixes that. in theory. i hope. i can't test, but putting it in to share @fix
2016-03-28emotion/libvlc: fix url openingThomas Guillem