summaryrefslogtreecommitdiff
path: root/src (follow)
AgeCommit message (Collapse)Author
2019-08-26spinner_cxx_example: Fix use wrong apiJunsuChoi
Summary: de18371 changes cause build errors. (D9707) this is a patch to fix it. Test Plan: N/A Reviewers: woohyun, bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9738
2019-08-26efl_ui_format: add null checking codes for eina_strftime in ↵Taehyub Kim
_do_format_string function Summary: efl_ui_format: add null checking codes for eina_strftime in _do_format_string function Reviewers: kimcinoo Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9735
2019-08-26edje/style: optimize style_update function.subhransu mohanty
Summary: If the style is readonly then we know for sure it dosen't have any text_class/color_class. If a style has text_class tag then call update only once not for each text_class tag it has. Reviewers: ali.alzyod, Hermet, cedric, raster Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9641
2019-08-26efl_ui_spin_button: rename editable to direct_text_inputMarcel Hollerbach
Summary: as suggested in T8097. Reviewers: cedric, zmike, woohyun Reviewed By: woohyun Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9707
2019-08-25efreet - make efreet launch timeout configurable by env varCarsten Haitzler (Rasterman)
also report as an ERR explicitly if its a timeout.
2019-08-25evas - scalecache - be a bit paranoid about images being set to nullCarsten Haitzler (Rasterman)
this may address a bug, but i'm not sure as i can't reproduce it. suffice to say it smells like a possible leak.
2019-08-24scalecache - handle possible use after free with sci still in listCarsten Haitzler (Rasterman)
the sci may still be in the list then we free it because sci->im is NULL .. it may always have been null. this should guard against that and fix it. @fix
2019-08-23elm: Fix Scrollable_Content namespaceLauro Moura
Summary: Efl.Ui.Widget is already a class. Required by the C# bindings. Reviewers: cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9733
2019-08-23efl_canvas_text: remove unused Text_Style eo structYeongjong Lee
Summary: `Efl.Canvas.Text_Style` is not used in eo world. Reviewers: zmike, tasn Reviewed By: tasn Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9565
2019-08-23edje signal matches - try number 3 to try plug all the holesCarsten Haitzler (Rasterman)
i found some more cases where the hash may change, so del and add from the hash when this happens... and... i found a nasty. _edje_signal_match_key_cmp compared pointers like: int return = ptr_a - ptr_b; what happens if .... ptr_a and ptr_b are more than 2^31 (2gb) apart? overflow (or underflow) and we return the wrong thing. i suspect this is part of the problem and why my has remove/adds have not been working because ... i suspect that maybe the hash dels have not been finding things. i can't be sure right now, but it is an obvious problem that i fixed by just doing if's and returning -1 or 1. also i found a double-add or overwrite int he hash - when we shuffled with _edje_signal_callback_move_last the matches CAN match exactly something already in the hash thus adding it in will conflict with what is already there as keys match. handle this cvase now and i have seen segv's go away for now. @fix
2019-08-23edje signal - let's not crash if something odd happensCarsten Haitzler (Rasterman)
better we dont just crash but err log it which can be set to abort anyway. @fix
2019-08-23elm/config: always use default profile with EFL_RUN_IN_TREEMike Blumenkrantz
Summary: if this env var is set, we're probably running unit tests or something and we should ignore ELM_PROFILE Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9701
2019-08-23tests/edje: disable efreetd and ecore system modules in unit testsMike Blumenkrantz
Summary: these cause tests to take up to 100x longer Reviewers: bu5hm4n, cedric Reviewed By: bu5hm4n, cedric Subscribers: cedric, #reviewers, #committers Tags: #efl_tests Differential Revision: https://phab.enlightenment.org/D9702
2019-08-23efl_ui_table: remove inlist items in EINA_INLIST_FREE macroYeongjong Lee
Summary: Check the EINA_INLIST_FREE document ``` in eina_inlist.h NOTE: it is the duty of the body loop to properly remove the item from the inlist and free it. This function will turn into a infinite loop if you don't remove all items from the list. ``` This will avoid infinite loop when Efl.Ui.Table is invalidated. ref T8145 Test Plan: See the test file in T8145 Reviewers: brunobelo, Jaehyun_Cho, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8145 Differential Revision: https://phab.enlightenment.org/D9699
2019-08-23efl_ui/scroll_util: block scroll calc tsunamis caused by repeat signal emitsMike Blumenkrantz
Summary: the 'efl,action,scroll' signal should only occur (at most) one time during each signal process loop, so restrict it for this case furthermore, the bar pos_changed and size_changed callbacks are always triggered sequentially, so there's no need to emit the signal in both callbacks this fixes infinite edje embryo errors and massively improves scroll perf Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl_widgets Differential Revision: https://phab.enlightenment.org/D9681
2019-08-23tests/eio: unlink tmpfiles after testsMike Blumenkrantz
Summary: my tmpdir is full of thousands of these things Depends on D9710 Reviewers: cedric Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9711
2019-08-23tests/eio: verify that the model monitor test's file is successfully createdMike Blumenkrantz
Summary: if this fails then the test will hang until timeout, so catch it earlier Depends on D9709 Reviewers: cedric Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9710
2019-08-23eio/poll: avoid ever dereferencing the backend's parent in a threadMike Blumenkrantz
Summary: when a monitor is destroyed, it unconditionally and immediately deletes the monitor struct. this means that as soon as the monitor is dead, the backend must never access the parent pointer again if its lifetime exceeds the lifetime of the monitor (such as in threads) the only member of the monitor data used by the fallback monitor is the monitor path, so we can just copy it to the fallback data to avoid ever needing to dereference this pointer fixes reliability issues with efl sentry unit tests @fix Depends on D9708 Reviewers: cedric Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9709
2019-08-23efl/io: fix race condition with child model deletionMike Blumenkrantz
Summary: if an event is emitted for a child that is added to the model during a call to _efl_io_model_children_list(), it's possible that this child will never be detected by the model's monitor/sentry if it is deleted before the monitor can detect it, which means there will never be a corresponding eio event emitted in this case, ensure that we manually remove this child from the model since we know we've just deleted it this fixes reliability issues with efl io model monitor unit test @fix Reviewers: cedric Reviewed By: cedric Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9708
2019-08-23efl_ui_scrollbar_direction: replace with efl_ui_layout_orientationYeongjong Lee
Summary: ref T7924, T7884 Reviewers: segfaultxavi, bu5hm4n Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T7924, T7884 Differential Revision: https://phab.enlightenment.org/D9612
2019-08-23csharp: add legacy eo in mono blacklistYeongjong Lee
Summary: It is unnecessary to generate cs file of legacy class. Test Plan: meson setup -Dbindings=mono,cxx Reviewers: felipealmeida, lauromoura Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers, woohyun Tags: #efl Differential Revision: https://phab.enlightenment.org/D9638
2019-08-23eolian-mono: Add support for partial classesFelipe Magno de Almeida
Summary: Add the -p command to eolian to create a class as a partial class. Create a list in meson build of Eolian files that should be built with partial classes. This allows creating more specific method overloads for C#, manually, by generating the class as partial and adding in manual binding the partial class with the new methods and properties. T8034 Reviewers: segfaultxavi, lauromoura, woohyun, Jaehyun_Cho Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9690
2019-08-23csharp: Only build extension methods for betaLauro Moura
Reviewers: felipealmeida, SanghyeonLee Reviewed By: SanghyeonLee Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9714
2019-08-23csharp: Add bindable factory parts supportLauro Moura
Summary: This commit makes parts that implement `Efl.IContent` use BindFactory instead of property binding. ``` var factory = new Efl.Ui.ItemFactory<Efl.Ui.ListDefaultItem>(); var iconFactory = new Efl.Ui.ImageFactory(null); iconFactory.PropertyBind("filename", "modelProperty"); factory.IconPart().BindFactory(iconFactory); ``` Fixes T7628 Reviewers: cedric, felipealmeida, SanghyeonLee Reviewed By: felipealmeida Tags: #efl Maniphest Tasks: T7628 Differential Revision: https://phab.enlightenment.org/D9653
2019-08-23eolian-mono: Add support for multi-value properties with tuplesFelipe Magno de Almeida
Summary: T8133 Reviewers: woohyun, segfaultxavi, felipealmeida Reviewed By: felipealmeida Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9577
2019-08-23slider_cxx_example: Fix use wrong apiJunsuChoi
Summary: d50fdc0, e84ecd95 changes cause build errors. this is a patch to fix it. Test Plan: N/A Reviewers: zmike, Jaehyun_Cho Reviewed By: Jaehyun_Cho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9721
2019-08-23efl_ui/image: explicitly mark 'drop' event @betaMike Blumenkrantz
this should probably be removed altogether but until dnd exists ensure that this doesn't accidentally get released ref T7873 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9705
2019-08-23efl_ui/image: scalable -> efl.gfx.image::can_up/downscaleMike Blumenkrantz
this removes the property from the image class to use the properties from the interface ref T7873 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9704
2019-08-23efl/gfx.image: add can_upscale and can_downscale propertiesMike Blumenkrantz
these are more granular properties which allow blocking of image upscaling and/or downscaling regardless of scale hint ref T7875 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9703
2019-08-23efl/gfx: redo image scale_type enumMike Blumenkrantz
this is ideally a bit more clear and flexible than the previous enum names Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D9691
2019-08-23efl_ui/image: implement efl.gfx.arrangement content_align to replace align propMike Blumenkrantz
this is effectively the same thing. no uses of this functionality exist anywhere ref T7873 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9688
2019-08-23efl_ui/image: remove geometry from internal struct, clean up geometry methodsMike Blumenkrantz
these methods exist only to trigger efl_canvas_group_change on geometry change and apply image sizing policies, there's no need to duplicate existing functionality as well Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9687
2019-08-23efl_ui/image: add group_calc implementation, use deferred calc for sizingMike Blumenkrantz
this changes image internals to use the more standardized group_calc method of sizing and causes all previous operations on the image which would have resulted in an immediate recalc to instead defer the calc until the group_calc function is called Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D9686
2019-08-23elm: fix macro for group_calc function namingMike Blumenkrantz
this should be efl_canvas_group_group_calculate to match eolian function naming no functional changes Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9685
2019-08-23efl_ui/popup: remove text_alert classMike Blumenkrantz
this can now be done by simply calling efl_ui_widget_scrollable_content_scrollable_text_set on an alert popup tests have been adjusted for this Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9677
2019-08-23efl_ui/scrollable_content: add scrollable_text propertyMike Blumenkrantz
this creates a label with a scroller and manages sizing calcs note that efl_ui_text cannot be used here because its sizing calc model is incompatible with efl Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9676
2019-08-23efl_ui/popup: remove scroll_alert classMike Blumenkrantz
this can now be done by simply calling efl_ui_widget_scrollable_content_set on an alert popup tests have been adjusted for this Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9675
2019-08-23efl_ui: add scrollable_content mixinMike Blumenkrantz
this allows content to be set with a scroller that automatically handles its own sizing calcs so that widgets/apps don't have to @feature Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9674
2019-08-23efl_ui_spotlight: add null check for manager stack dataJaehyun Cho
Like other functions, null check for manager stack data is added before referencing manager stack data.
2019-08-23test_ui_spotlight: remove dead default in switchJaehyun Cho
2019-08-23edje/style: Enable lazy computaion of styles.subhransu mohanty
Summary: Instead of updating all the styles in an Edje_File just mark them dirty so that subsequent call to style will recompute the new style before returning the style. Reviewers: ali.alzyod, Hermet, raster, cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9697
2019-08-23ecore_con/memleak: due to checking refcount using postfix decrement operatorsubhransu mohanty
Reviewers: Hermet, raster, cedric Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9716
2019-08-22emotion - webcam fix deletion of webcam still left in webcam listCarsten Haitzler (Rasterman)
we may destroy webcams but leave them in the list. this fixes that by removing them from our global list when we do unref to 0. @fix
2019-08-22edje - signal callback matches/patterns try fix number 2Carsten Haitzler (Rasterman)
so i think there was also another bug as i saw this again now. this should hopefully plug the signal/mtach memory bugs now by removing and adding back to hash as the hash key relies on the memory addresses of signal/src in the matches array which change on realloc. a bit brute-forceey but... better than crashes. @fix
2019-08-22efl_ui_slider_interval: cut off the dependency with efl_ui_sliderWooHyun Jung
efl_ui_slider_interval is totally different widget from efl_ui_slider. Now, it extends efl_ui_layout_base and implements all efl_ui_slider's functionalities by its own. This class needs to be marked to @beta till reviewing whole class definitions again. @ref T7893 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D9696
2019-08-22elm/config: avoid unnecessary elm cache flushsubhransu mohanty
Summary: in config_apply() we load the deafult theme and then elm_recache() just throws it away. so just move it before config_apply for time being. We need to revisit to check if we really need that elm_recache() in that function or not. Reviewers: Hermet, raster, cedric, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9700
2019-08-22efl_ui_widget: correct the comparison parameter in scroll_freeze_popYeongjong Lee
Summary: It is copy/paste error. See also, e7986cc6468b4f99b4c8abdb4a900992d9e525ad Reviewers: bu5hm4n, zmike Reviewed By: zmike Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9695
2019-08-22edje_cc: Fix always true condition.JunsuChoi
Summary: The condition at 742 line is always true. So I fix it. If action is not ACTION_STOP or ACTION_TYPE_SCRIPT, go to continue. Test Plan: N/A Reviewers: bu5hm4n, Hermet, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, kimcinoo, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9667
2019-08-22edje/style: fix memory leak because of typo.subhransu mohanty
Summary: We already have a escaped string for the font_source so this code is unnecessary. Reviewers: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9698
2019-08-22examples: shut up edc build warnings.Hermet Park
This might not be proper fix (at least they are fine by me), if these textblocks actually have something wrong sizing.