summaryrefslogtreecommitdiff
path: root/src (follow)
AgeCommit message (Collapse)Author
2019-05-29evas_inline: Clean up evas_object_plane_changed functionChristopher Michael
Summary: This file is full of functions called as: foo(eo_obj, obj); Most of them can be reduced to foo(obj); and internally get the eo_obj with obj->object This would make it impossible to screw up calling them passing an unrelated pair, and make calling code a little more readable. ref T7230 Depends on D9050 Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7230 Differential Revision: https://phab.enlightenment.org/D9051
2019-05-29evas_inline: Clean up evas_object_is_on_plane functionChristopher Michael
Summary: This file is full of functions called as: foo(eo_obj, obj); Most of them can be reduced to foo(obj); and internally get the eo_obj with obj->object This would make it impossible to screw up calling them passing an unrelated pair, and make calling code a little more readable. ref T7230 Depends on D9049 Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7230 Differential Revision: https://phab.enlightenment.org/D9050
2019-05-29evas_inline: Clean up evas_object_is_opaque functionChristopher Michael
Summary: This file is full of functions called as: foo(eo_obj, obj); Most of them can be reduced to foo(obj); and internally get the eo_obj with obj->object This would make it impossible to screw up calling them passing an unrelated pair, and make calling code a little more readable. ref T7230 Depends on D9048 Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7230 Differential Revision: https://phab.enlightenment.org/D9049
2019-05-29evas_inline: Clean up evas_object_is_proxy_visible functionChristopher Michael
Summary: This file is full of functions called as: foo(eo_obj, obj); Most of them can be reduced to foo(obj); and internally get the eo_obj with obj->object This would make it impossible to screw up calling them passing an unrelated pair, and make calling code a little more readable. ref T7230 Depends on D9046 Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7230 Differential Revision: https://phab.enlightenment.org/D9048
2019-05-29evas_inline: Clean up evas_object_is_visible functionChristopher Michael
Summary: This file is full of functions called as: foo(eo_obj, obj); Most of them can be reduced to foo(obj); and internally get the eo_obj with obj->object This would make it impossible to screw up calling them passing an unrelated pair, and make calling code a little more readable. ref T7230 Depends on D9045 Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7230 Differential Revision: https://phab.enlightenment.org/D9046
2019-05-29evas_inline: Clean up evas_object_was_visible functionChristopher Michael
Summary: This file is full of functions called as: foo(eo_obj, obj); Most of them can be reduced to foo(obj); and internally get the eo_obj with obj->object This would make it impossible to screw up calling them passing an unrelated pair, and make calling code a little more readable. ref T7230 Reviewers: raster, cedric, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7230 Differential Revision: https://phab.enlightenment.org/D9045
2019-05-29eolian: fix unit version checkDaniel Kolesa
2019-05-29eolian-cxx: Fix some warnings from cppcheckLauro Moura
Differential Revision: https://phab.enlightenment.org/D9052
2019-05-29ecore: enable property reflection support in Efl.CompositeModel.Cedric BAIL
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D8754
2019-05-29eina: add test for eina_slstr_copy_new_length.Cedric BAIL
Summary: Depends on D8800 Reviewers: zmike Reviewed By: zmike Subscribers: zmike, #reviewers, #committers Tags: #efl Maniphest Tasks: T7832 Differential Revision: https://phab.enlightenment.org/D9016
2019-05-29eina: add eina_slstr_copy_new_length.Cedric BAIL
Reviewers: SanghyeonLee, bu5hm4n, zmike, segfaultxavi, lauromoura, felipealmeida, raster Reviewed By: bu5hm4n, zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T7832 Differential Revision: https://phab.enlightenment.org/D8800
2019-05-29tests/elm_focus: explicitly set widgets to expand+fill in testMike Blumenkrantz
Summary: some widgets do not create a minimum size for themselves, resulting in a 0x0 layout which can affect tests that rely on object visibility to succeed without errors Depends on D9007 Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9008
2019-05-29tests/genlist: fix some shadowed variable warningsMike Blumenkrantz
Summary: Depends on D9006 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9007
2019-05-29tests/elm: explicitly denote cases where error messages are intentionalMike Blumenkrantz
Summary: we want to make it clear in our tests where it is intended that warnings and errors may occur Depends on D9005 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9006
2019-05-29ecore-imf/xim: only call ecore_x_shutdown if init was previously calledMike Blumenkrantz
Summary: this isn't a perfect fix, but it's probably the best that can be done given the current ecore-imf module api which calls the exit() module function unconditionally during module cleanup even if the module was never initialized @fix Depends on D9003 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9005
2019-05-29emotion: don't update crop clipper geometry if crop clipper doesn't existMike Blumenkrantz
Summary: this object does not exist if no image border is set @fix Depends on D9002 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9003
2019-05-29elm_widget_item_static_focus: check for adapter existence in unrealize cbMike Blumenkrantz
Summary: adapter can be null if it was previously destroyed @fix Depends on D9001 Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: bu5hm4n, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9002
2019-05-29elm/scroller: return immediately from updating focused scroll region without ↵Mike Blumenkrantz
content Summary: there is nothing to update here if the scroller has no content to update @fix Depends on D9000 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9001
2019-05-29elm/map: move setting initial zoom to later in constructionMike Blumenkrantz
Summary: this ensures that all necessary objects exist in order to successfully perform the zoom @fix Depends on D8999 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9000
2019-05-29elm/list: return early from min_limit_cb if list object is deadMike Blumenkrantz
Summary: no further recalculating should be done on dead objects @fix Depends on D8998 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8999
2019-05-29elm/interface_scrollable: return immediately from setting region if no contentMike Blumenkrantz
Summary: this is a valid case and should be handled without erroring @fix Depends on D8997 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8998
2019-05-29elm/index: create event_rect[0] earlier in constructionMike Blumenkrantz
Summary: this ensures that the object exists during init functions which make calls on it @fix Depends on D8996 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8997
2019-05-29elm/genlist: handle genlist finding of nearest visible item when not realizedMike Blumenkrantz
Summary: FIXME-- @fix Depends on D8995 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8996
2019-05-29elm/genlist: handle cache item deletion without errorsMike Blumenkrantz
Summary: @fix Depends on D8994 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8995
2019-05-29elm/genlist: trigger unrealize event after unsetting unrealized flagMike Blumenkrantz
Summary: this flag is accessed by other components (e.g., focus) during the event and so it must reflect the emitted event @fix Depends on D8993 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8994
2019-05-29elm/genlist: unify all creation of calc jobs, skip if genlist is deadMike Blumenkrantz
Summary: there is no need to recalculate any genlist attributes if the genlist is dead @fix Depends on D8992 Reviewers: cedric, bu5hm4n Reviewed By: cedric, bu5hm4n Subscribers: bu5hm4n, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8993
2019-05-29elm/gen*: only call focus_object_setup_order_non_recursive if realizedMike Blumenkrantz
Summary: this function cannot process unrealized items @fix Depends on D8990 Reviewers: bu5hm4n Reviewed By: bu5hm4n Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8992
2019-05-29elm/gengrid: trigger unrealize event after unsetting unrealized flagMike Blumenkrantz
Summary: this flag is accessed by other components (e.g., focus) during the event and so it must reflect the emitted event @fix Depends on D8989 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8990
2019-05-29elm/code: check for cursor layout existence before emitting signals to itMike Blumenkrantz
Summary: non-editable widgets do not have this object and will trigger errors @fix Depends on D8988 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8989
2019-05-29elm/popup: remove del callback for internal table object during destructionMike Blumenkrantz
Summary: the table object's destruction is no longer relevant after this point and its callback can trigger unnecessary errors @fix Depends on D8986 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8988
2019-05-29elm/fileselector: return early in theme_apply during constructionMike Blumenkrantz
Summary: the remainder of this function is used to setup styles for subobjects which don't yet exist at this point @fix Depends on D8984 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8985
2019-05-29efl_ui/widget: skip updating access info during parent_set(NULL) if deadMike Blumenkrantz
Summary: no need to update access info for dead objects @fix Depends on D8983 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8984
2019-05-29efl_ui/video: do not set 0x0 aspect hintMike Blumenkrantz
Summary: this is an error @fix Depends on D8982 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8983
2019-05-29efl_ui/progressbar: check for part existence before using partsMike Blumenkrantz
Summary: some progressbar styles do not have certain parts, so it's necessary to check part existence on theme load to avoid triggering unnecessary errors @fix Depends on D8981 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8982
2019-05-29efl_ui/layout: only freeze internal layout during delete if it existsMike Blumenkrantz
Summary: if the layout object does not exist here then there is nothing to freeze @fix Depends on D8980 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8981
2019-05-29efl_ui/layout: do not trigger sizing eval on subobj delete if layout is deadMike Blumenkrantz
Summary: @fix Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8980
2019-05-29efl_ui/layout: do not trigger sizing eval on hint change if object is deadMike Blumenkrantz
Summary: this fixes a huge number of errors during object deletion @fix Depends on D8979 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8987
2019-05-29efl_ui/image: check image object existence before using it in sizingMike Blumenkrantz
Summary: when triggered before the image is loaded, this code cannot be run @fix Depends on D8978 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8979
2019-05-29efl_ui/check: check icon swallow existence before getting its contentMike Blumenkrantz
Summary: some check styles do not have this part @fix Depends on D8977 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8978
2019-05-29eldbus: don't print warnings for user-canceled callsMike Blumenkrantz
Summary: these are intentionally canceled and not something to be concerned with @fix Depends on D8974 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8976
2019-05-29efl/io_model: check for parent object existence before removing wrefMike Blumenkrantz
Summary: if the wref automatically removes this pointer then there's no need to remove the wref on the pointer @fix Depends on D8973 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8974
2019-05-29ecore-x: protect ecore_x_shutdown from creating a negative init countMike Blumenkrantz
Summary: @fix Depends on D8972 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8973
2019-05-29ecore-evas: check for internal evas presence before using it during freeMike Blumenkrantz
Summary: some engines do not have an evas @fix Depends on D8971 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8972
2019-05-29efl_ui/button: check icon swallow existence before getting its contentMike Blumenkrantz
Summary: some button styles do not have this part @fix Depends on D8970 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8971
2019-05-29elm/slider: check for interval/range state before using that functionalityMike Blumenkrantz
Summary: the part elm.dragable2.slider only exists when the slider is set to range mode, so verify that this mode is active before attempting to use that part @fix Depends on D8968 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8969
2019-05-29elm/slider: avoid emitting double events when range slider value changesMike Blumenkrantz
Summary: in range mode, there are two slider endpoints, but only one event should be emitted if a change is detected during update @fix Depends on D8967 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8968
2019-05-29elm/map: ignore zoom events during construction which cannot be handledMike Blumenkrantz
Summary: sd->obj is null until after the object is finalized, so this codepath cannot be processed until then @fix Depends on D8966 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8967
2019-05-29elm: fix value of datadir when running in treeMike Blumenkrantz
Summary: this makes it possible to successfully run elm_test out of the tree without installing @fix Depends on D8965 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8966
2019-05-29elm: don't attempt to load clouseau when running in treeMike Blumenkrantz
Summary: clouseau doesn't work anyway Depends on D8964 Reviewers: cedric Reviewed By: cedric Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8965
2019-05-29elm/hovers: don't trigger more errors when setting null hover parentMike Blumenkrantz
Summary: null is not a valid subobject, do not attempt to add it @fix Depends on D8963 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: devilhorns, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8964