summaryrefslogtreecommitdiff
path: root/src (follow)
AgeCommit message (Collapse)Author
2019-11-15examples: efl_exe: fix out of bounds writeStefan Schmidt
Summary: Buf is 4096 in size and rw_slice.len also evaluates to 4096. Write at the last byte and not over bound instead. CID: 1403895 Reviewers: raster, bu5hm4n, devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10682
2019-11-15eolian: fix memory leak when using error objectsDaniel Kolesa
2019-11-15efreet: fix typoBoris Faure
Summary: efreet: fix typo Test Plan: None Reviewers: cedric, raster, lauromoura, devilhorns, marcelhollerbach, segfaultxavi, zmike, vtorri Reviewed By: segfaultxavi, vtorri Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10676
2019-11-15csharp: FunctionPtr wrappers are not IDisposableLauro Moura
Summary: They don't actually store unmanaged memory and we already rely on the GC to free them (not calling Dispose() directly through the managedCb closure, so we don't need IDisposable. Just making sure we release the Function Pointer data in the main loop as the GC runs in a different thread. Ref T8423 Depends on D10672 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10673
2019-11-15csharp: Silence CA2000 in testsLauro Moura
Summary: These objects are expected to leave scope while alive. Ref T8423 Depends on D10671 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10672
2019-11-15csharp: Suppress CA2000 in native wrappers.Lauro Moura
Summary: These methods may instantiate `IDisposable` classes like `Array`, `Iterator` to pass to user-overriden C# methods. As we can't guarantee the user stored the object or not, we can't call Dispose directly on them. Ref T8423 Depends on D10670 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10671
2019-11-15csharp: More CA2000 fixesLauro Moura
Summary: For eldbus.Proxy.Send, as the native function takes ownership of the message, we Ref it so it can still be used afterwards. Ref T8423 Reviewers: brunobelo, felipealmeida, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10670
2019-11-15Edje : textblock_styles strncmp improvementabdulleh Ghujeh
Summary: Improve string comparison Reviewers: cedric, ali.alzyod, woohyun, bu5hm4n Reviewed By: woohyun Subscribers: bu5hm4n, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10635
2019-11-14edje: Remove warningsLauro Moura
Missing declaration from another file and removing unused variable. After D10605 Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10674
2019-11-14csharp: Disposing IDisposable objects.Bruno da Silva Belo
Summary: ref T8423 Reviewers: lauromoura, felipealmeida, YOhoho Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8423 Differential Revision: https://phab.enlightenment.org/D10644
2019-11-14edje_calc: Exception handling if no calculation is required.Woochanlee
If there is no object swllowed, do not run part_calc on it. This swallow will be calculated if there is an associated part, otherwise it will not need to be calculated. When the app is launched, a lot of edje calculation logic is executed. Most of the edje size is missing, so the calculation result is meaningless. Added code to prevent this. Reviewed-by: Cedric BAIL <cedric.bail@free.fr> Differential Revision: https://phab.enlightenment.org/D10605
2019-11-14ecore-drm2: Fix issue of shifting 1 by more than 32bitsChris Michael
Based on 9ca573f40f1065cc717c0c5aabb787671bab852b, this patch fixes potential undefined behaviour on 64 bit systems. @fix
2019-11-14eo: fix UB in the eo event code (edje_cc hangs etc.)Daniel Kolesa
Today I started experiencing mysterious hanging of edje_cc during build. "The French are at it again" I thought, and after spending a while bisecting, I found the culprit. It's 7f53d9158395504151e1ff3dcae715a799d913a8. So, what is happening in here? The idea here was fundamentally sound; compute a special hash value for event descriptors, taking range between 0 and 63 (on 64-bit systems) and 0 and 31 (on 32-bit systems), then use a mask sized 32-bit or 64-bit (depending on your system) and check early if to bail out from callback_call, saving some resources. So far so good. The problem is in the way the mask is handled. We're applying the hash as the shift value like, `x |= (1 << hash)`. On 32-bit systems this is okay, but on 64-bit systems, C's dumb silent coercion rules kick in, since the left side of the expression is 1, a literal with type signed int; that means our shifting range is limited to 31 and what we get is... undefined behavior. This is obviously not what we want, so take a 1ULL value as a base. The previous thing seemingly worked on x86_64 (nobody reported any issues) and interestingly it worked for me too for a while (on ppc64le), but undefined behavior can be unpredictable, so... This shouldn't need a commit message as long as this, but I'm making it proportional to the amount of time I wasted on this.
2019-11-14efl_canvas_vg_node: Prevent access to NULL object for remove warningJunsuChoi
Summary: For remove this warning WRN<3378>:eo ../src/lib/eo/eo.c:644 _efl_object_call_resolve() NULL passed to function efl_invalidated_get(). Test Plan: elementary_test -> animation_view Reviewers: Hermet, kimcinoo, smohanty Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10627
2019-11-13efl: improve Efl.BooleanModel test by checking the child del case.Cedric BAIL
This has detected the bug that previous commit fix. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10634
2019-11-13efl: remove useless printf from Efl Container Model tests.Cedric BAIL
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10633
2019-11-13ecore: correctly apply the offset on the upper part of the boolean mask for ↵Cedric BAIL
Efl.BooleanModel. The upper mask is the one that should actually move as the gap is between the lower and the upper mask when removing an element from the array. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10632
2019-11-13ecore: remove the composited children from the source of an Efl.CompositeModel.Cedric BAIL
The composite model was erroneously giving the reference to a children composited model instead of the origianl children which made it impossible for the composited model to delete the right child. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10631
2019-11-13elementary: fix initialization order and memory leak when setting model on ↵Cedric BAIL
Efl.Ui.CollectionView. This patch use volatile model to make sure that a model is properly cleaned once it is not used anymore. Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10625
2019-11-13elementary: fix recursive case during model fetch in Efl.Ui.CollectionView.Cedric BAIL
Figuring out why model fetch was sometime not working recursively allow to reduce the amount of request that need to be made. In this case, notifying the position manager or lack of notification was triggering a case where the item would not show up (Joice of nested asynchronous behavior). Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10624
2019-11-13ecore: properly handle children destruction in Efl.BooleanModel.Cedric BAIL
The children removal event is happening on the parent model, so access values directly. T8358 Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de> Differential Revision: https://phab.enlightenment.org/D10623
2019-11-13csharp: Some missing conversionsLauro Moura
Summary: Ref T8430 Depends on D10616 Reviewers: brunobelo, segfaultxavi, felipealmeida, YOhoho Reviewed By: YOhoho Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8430 Differential Revision: https://phab.enlightenment.org/D10652
2019-11-13csharp: Add conversion methods for generated typesLauro Moura
Summary: This also adds a helper method to convert from a value type name to the reference type name. (e.g. int to Int32). Ref T8430 Reviewers: felipealmeida, brunobelo, YOhoho Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8430 Differential Revision: https://phab.enlightenment.org/D10653
2019-11-13eolian_mono: change OnXXXEvent access modifier from public to protected virtualYeongjong Lee
Summary: OnXXXEvent is event invocation wrapper method to allow derived classes to override the event invocation behavior. Test Plan: meson with `-Dbindings=mono,cxx` Reviewers: lauromoura Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10655
2019-11-13wl_egl : Prevent access to NULL pointerJunsuChoi
Summary: The pointer s can be null. Test Plan: N/A Reviewers: Jaehyun_Cho, raster Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10654
2019-11-12csharp: Add To and From methods for implicit conversion.Bruno da Silva Belo
Summary: ref T8430 Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8430 Differential Revision: https://phab.enlightenment.org/D10616
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_wm_rotation_supportedChristopher Michael
functions ref T8016
2019-11-12tests/ecore_wl2: Modify ecore_wl2_window_rotation testChristopher Michael
Small patch to modify ecore_wl2_window_rotation test to support ecore_wl2_window_rotation_set function ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_rotation_app functionsChristopher Michael
ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_preferred_rotationChristopher Michael
functions ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_maximized functionsChristopher Michael
ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_fullscreen functionsChristopher Michael
ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_focus_skip_get/setChristopher Michael
functions ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_floating_mode_get/setChristopher Michael
functions ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_window_alpha_get/set functionsChristopher Michael
ref T8016
2019-11-12tests/ecore_wl2: Add test for ecore_wl2_display_compositor_version_getChristopher Michael
ref T8016
2019-11-12efl_ui_relative_container: rename relative_layoutYeongjong Lee
Summary: Also, Rename parameter name `target` to `base`. Rename parameter name `relative` to `relative_position`. ref T8380 Depends On D10639 Test Plan: ninja test Reviewers: woohyun, segfaultxavi Reviewed By: segfaultxavi Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8380 Differential Revision: https://phab.enlightenment.org/D10640
2019-11-12eolian_mono: avoid keyword as a variable nameYeongjong Lee
Summary: ``` private static void relation_left_get(System.IntPtr obj, System.IntPtr pd, Efl.Gfx.IEntity child, out Efl.Gfx.IEntity kw_base, out Efl.Gfx.Align relative_position) { Eina.Log.Debug("function efl_ui_relative_container_relation_left_get was called"); var ws = Efl.Eo.Globals.GetWrapperSupervisor(obj); if (ws != null) { base = default(Efl.Gfx.IEntity);relative_position = default(Efl.Gfx.Align); ``` Parameter name is replaced with `kw_base` but `base` is not changed in assignment expression (`base = default(Efl.Gfx.IEntity...`). This patch will fix following compiler error. ``` src/bindings/mono/efl_ui_relative_container.eo.cs(544,21): error CS1525: Unexpected symbol `=', expecting `.' or `[' ``` Test Plan: ninja with D10640 Reviewers: lauromoura Reviewed By: lauromoura Subscribers: segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10639
2019-11-12mono: reduce duplicated event codeYeongjong Lee
Summary: Introduction GetInternalEventCallback function to reduce duplicated event code. Test Plan: ninja test Reviewers: lauromoura Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10638
2019-11-12dotnet: Generate doc and check for warningsLauro Moura
Reviewers: segfaultxavi, brunobelo, felipealmeida Reviewed By: brunobelo Subscribers: cedric, #reviewers, #committers, woohyun Tags: #efl Differential Revision: https://phab.enlightenment.org/D10630
2019-11-12Efl.Ui.Scroll_Manager: Fix indentationXavi Artigas
2019-11-12evas_device: Fix typo in evas_device_popJunsuChoi
Summary: Fix wrong null check Test Plan: N/A Reviewers: cedric, Jaehyun_Cho Reviewed By: Jaehyun_Cho Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10648
2019-11-12Efl.Ui.Animation_View: Implement sector playing featureJunsuChoi
Summary: play_sector method is API for playing section. If the animation object has section information, user can play the section. Get the start and end section name and get the frame of each section. And set and play the min and max frames of the current animation object. Depends on D10506 Test Plan: For example. Animation objects have "first","second" and "third" sectors. And sector "second" has duration information. User can use it like this: efl_ui_animation_view_play_sector(anim_view, "first", "second"); efl_ui_animation_view_play_sector(anim_view, "second", NULL); efl_ui_animation_view_play_sector(anim_view, "first", NULL); // first sector ~ end frame of animation object. efl_ui_animation_view_play_sector(anim_view, "second", "third"); efl_ui_animation_view_play_sector(anim_view, "second", "wrong name"); Reviewers: Hermet, smohanty, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10507
2019-11-12Efl.Gfx.Frame_Controller: Add sector propertyJunsuChoi
Summary: These APIs to get and set frames for a specific section for playing section. Depends on D10505 Test Plan: N/A Reviewers: Hermet, smohanty, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10506
2019-11-12evas_cache_vg : Implements sector_get/set internal APIsJunsuChoi
Summary: These APIs to get and set frames for a specific section in vg animation. get API looks for a sector by name in the markerlist of VG_File_Data. Then return start and end frames. Depends on D10504 Test Plan: N/A Reviewers: Hermet, smohanty, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10505
2019-11-12vg_loader: Get markers information form json data.JunsuChoi
Summary: If json data has marker information, it is stored in vg file data. Test Plan: N/A Reviewers: Hermet, smohanty, kimcinoo Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10504
2019-11-12evas_filter: remove shader compile errorShinwoo Kim
Summary: When grayscale fillter works there is a compile error: implicit cast from "float" to "vec3" Test Plan: 1. Create filter_example with following . efl_gfx_filter_program_set(image, "grayscale ()", "grayscale"); 2. Run. ELM_ACCEL=gl ./filter_example Reviewers: Hermet, jsuya Reviewed By: Hermet Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10595
2019-11-11elm: apply the same fix we needed in entry to other scrollable widgetsMarcel Hollerbach
this here is the same effect as in my previous commit: When re retheme a object, we need to reset the signals, otherwise there would be wrongly displayed scrollbars. This fixes wrong scrollbars in enlightenment. Differential Revision: https://phab.enlightenment.org/D10628
2019-11-11efl_canvas_animation: correctly handle double signnessMarcel Hollerbach
Summary: start_delay and duration both have to be > 0.0 otherwise there should be an error. This also adds the neccessary checks, to ensure that. For now this is only added to the normal evas test suite, maybe we eed to refactor these efl_* API tests into theire own test suite. However, not for now. Reviewers: segfaultxavi Reviewed By: segfaultxavi Subscribers: segfaultxavi, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10617
2019-11-07csharp: Localization strings with CultureInfo.Bruno da Silva Belo
Summary: ref T8404 Reviewers: lauromoura, felipealmeida, YOhoho Reviewed By: lauromoura Subscribers: cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8404 Differential Revision: https://phab.enlightenment.org/D10608