summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Juyung Seo <seojuyung2@gmail.com>2013-01-16 01:11:02 +0000
committerDaniel Juyung Seo <seojuyung2@gmail.com>2013-01-16 01:11:02 +0000
commitb70667bd0e6f53988fafd8da41728f85d20ceb91 (patch)
tree6a0daaa04234f4a0436fb2afcbcd2be9957ac2e3
parent9836f5dc367f2e751756984445657fb9f0afc364 (diff)
elm check: Bug fix "changed" signal being sent twice in case of toggle style when check is clicked. Patch by Shilpa Singh <shilpa.shing@samsung.com>, Rajeev Ranjan <rajeev.r@samsung.com>
On Tue, Jan 15, 2013 at 6:02 PM, SHILPA ONKAR SINGH <shilpa.singh@samsung.com> wrote: Hi All, Please find attached bug fix for elm_check - toggle style. This patch prevents "changed" signal being sent twice in case of toggle style when check is clicked. This also fixes few indentation issues in the style. Change description: elm_check: Bug fix "changed" signal being sent twice in case of toggle style when check is clicked. Signed-Off by: Rajeev Ranjan(rajeev.r@samsung.com) Signed-Off by: Shilpa Singh(shilpa.singh@samsung.com) Thanks & Regards Shilpa Singh SVN revision: 82845
-rw-r--r--ChangeLog4
-rw-r--r--NEWS1
-rw-r--r--data/themes/widgets/check.edc30
3 files changed, 18 insertions, 17 deletions
diff --git a/ChangeLog b/ChangeLog
index 059e2aad7..bb3ce4e63 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -902,3 +902,7 @@
9022013-01-13 Daniel Juyung Seo (SeoZ) 9022013-01-13 Daniel Juyung Seo (SeoZ)
903 903
904 * Added "highlighted" and "unhighlighted" signals to list, genlist, and gengrid. 904 * Added "highlighted" and "unhighlighted" signals to list, genlist, and gengrid.
905
9062013-01-16 Shilpa Singh <shilpa.singh@samsung.com>, Rajeev Ranjan <rajeev.r@samsung.com>
907
908 * Fix "changed" signal being sent twice in case of toggle style when check is clicked.
diff --git a/NEWS b/NEWS
index daf20284b..95c4beecf 100644
--- a/NEWS
+++ b/NEWS
@@ -121,6 +121,7 @@ Fixes:
121 * Fix the usage of the checks in the fileselector test 2. 121 * Fix the usage of the checks in the fileselector test 2.
122 * Added the min_year and max_year in the standard profile config. 122 * Added the min_year and max_year in the standard profile config.
123 * Fix omitting signal emission when customized text parts change the text. 123 * Fix omitting signal emission when customized text parts change the text.
124 * Fix "changed" signal being sent twice in case of toggle style when check is clicked.
124 125
125Removals: 126Removals:
126 127
diff --git a/data/themes/widgets/check.edc b/data/themes/widgets/check.edc
index f6b25d615..6ba52b50b 100644
--- a/data/themes/widgets/check.edc
+++ b/data/themes/widgets/check.edc
@@ -576,29 +576,25 @@ group { name: "elm/check/base/toggle";
576 set_int(is_drag, 0); 576 set_int(is_drag, 0);
577 } 577 }
578 } 578 }
579 program { name: "drag_end"; 579 program { name: "drag_end";
580 signal: "mouse,up,1"; 580 signal: "mouse,up,1";
581 source: "button"; 581 source: "button";
582 script { 582 script {
583 new Float:dx, Float:dy; 583 new Float:dx, Float:dy;
584 get_drag(PART:"button", dx, dy); 584 get_drag(PART:"button", dx, dy);
585 if (dx > 0.5) 585 if (get_int(is_drag)) {
586 { 586 if (dx > 0.5)
587 set_drag(PART:"button", 1.0, 0.0); 587 set_drag(PART:"button", 1.0, 0.0);
588 } 588 else
589 else 589 set_drag(PART:"button", 0.0, 0.0);
590 { 590 if (((get_int(is_rtl) == 1) && (dx <= 0.5)) ||
591 set_drag(PART:"button", 0.0, 0.0); 591 (get_int(is_rtl) == 0) && (dx > 0.5))
592 } 592 emit("elm,action,check,on", "");
593 if (((get_int(is_rtl) == 1) && (dx <= 0.5)) || 593 else
594 (get_int(is_rtl) == 0) && (dx > 0.5)) { 594 emit("elm,action,check,off", "");
595 emit("elm,action,check,on", ""); 595 set_int(was_drag, 1);
596 } 596 set_int(is_drag, 0);
597 else {
598 emit("elm,action,check,off", "");
599 } 597 }
600 set_int(was_drag, get_int(is_drag));
601 set_int(is_drag, 0);
602 } 598 }
603 } 599 }
604 program { name: "check_on"; 600 program { name: "check_on";