summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVorobiov Vitalii <vi.vorobiov@samsung.com>2014-05-19 15:41:32 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2014-05-19 15:41:32 +0900
commit6dc6a96f803784eee2528fc42a07d4dc1a6aca88 (patch)
tree34c552029d8949b0e295f5c7e624bafd76324c95
parent734696fe99ee286ffceaf5ac4aa2f34b79d1bc7f (diff)
[Fileselector] Fix double-call of callback function on clicking "Enter" key.
Summary: This feature (Clicking on "Enter" key) was previously implemented by using "activate" signal of entry (the one for entering name of the file), so it was looking like "ok" button was clicked by pushing "Enter" key on the keyboard. This little feature was added in commit 4d761f3a63270c88fa516764d9288f8bf0ff4a11. Later the huge feature that adds key binding was implemented (commit 820f3dc907250c0c08ed8431b50567e58d6dab5c for ex). It allows to bind widgets with keys (certain function calls when certain keys is pressed on keyboard). This feature also adds same functionality to fileselecter, doing the same as previous (with "activate" signal) one. Because of that it was looks like "ok" button was clicked twice. This commit fixes this behavior and removes old and outdated method of "ok" button clicking processing. @fix Reviewers: cedric, seoz, raster CC: reutskiy.v.v Differential Revision: https://phab.enlightenment.org/D864
-rw-r--r--src/lib/elc_fileselector.c9
1 files changed, 0 insertions, 9 deletions
diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c
index 6e1199875..686369d76 100644
--- a/src/lib/elc_fileselector.c
+++ b/src/lib/elc_fileselector.c
@@ -1335,13 +1335,6 @@ _resource_deleted(void *data, int type EINA_UNUSED, void *ev)
1335 return ECORE_CALLBACK_PASS_ON; 1335 return ECORE_CALLBACK_PASS_ON;
1336} 1336}
1337 1337
1338static void
1339_name_entry_activated_cb(void *data, Evas_Object *obj EINA_UNUSED,
1340 void *event_info EINA_UNUSED)
1341{
1342 _ok(data, NULL, NULL);
1343}
1344
1345EOLIAN static void 1338EOLIAN static void
1346_elm_fileselector_evas_smart_add(Eo *obj, Elm_Fileselector_Data *priv) 1339_elm_fileselector_evas_smart_add(Eo *obj, Elm_Fileselector_Data *priv)
1347{ 1340{
@@ -1430,8 +1423,6 @@ _elm_fileselector_evas_smart_add(Eo *obj, Elm_Fileselector_Data *priv)
1430 elm_entry_line_wrap_set(en, ELM_WRAP_CHAR); 1423 elm_entry_line_wrap_set(en, ELM_WRAP_CHAR);
1431 evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); 1424 evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
1432 evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL); 1425 evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);
1433 evas_object_smart_callback_add(en, "activated",
1434 _name_entry_activated_cb, obj);
1435 1426
1436 elm_widget_sub_object_add(obj, en); 1427 elm_widget_sub_object_add(obj, en);
1437 priv->name_entry = en; 1428 priv->name_entry = en;