summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:29:22 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:34:35 +0900
commit8b8eb61bde425ec8c7443845445f22b91f840a70 (patch)
tree4e1c9d38b51357752c011d0c2c8300ab76133cbe
parent905b707f841c468a654005d9f10c33d5df5f8ae6 (diff)
elm - genlist item - index get start from 0 - unbreak api break
so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1 rather than 0. going back to elm code in 1.7 - it started at 0. this is an api break that shouldn't have happend, but did. this fixes that. yes - it's inconsistent with gengrid's index_get - but gengrid here is wrong. nth_get starts at 0. this will get fixed with eo api's, and in fact none of these index/nth api's should be in genlist's eo api. legacy only. i can see why this was changed - it matches gengrid and is more consistent, but we can't break things even if stupid. @fix
-rw-r--r--src/lib/elm_genlist.c2
-rw-r--r--src/lib/elm_genlist_item.eo2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index e55687652..8d263c4bb 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -7062,7 +7062,7 @@ elm_genlist_item_cursor_engine_only_get(const Elm_Object_Item *eo_it)
7062EOLIAN static int 7062EOLIAN static int
7063_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it) 7063_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it)
7064{ 7064{
7065 int cnt = 1; 7065 int cnt = 0;
7066 Elm_Gen_Item *tmp; 7066 Elm_Gen_Item *tmp;
7067 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1); 7067 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1);
7068 7068
diff --git a/src/lib/elm_genlist_item.eo b/src/lib/elm_genlist_item.eo
index 34a6179ca..fdfb6e527 100644
--- a/src/lib/elm_genlist_item.eo
+++ b/src/lib/elm_genlist_item.eo
@@ -169,7 +169,7 @@ class Elm_Genlist_Item(Elm_Widget_Item)
169 /*@ 169 /*@
170 Get the index of the item. It is only valid once displayed. 170 Get the index of the item. It is only valid once displayed.
171 171
172 The index start from 1. 172 The index start from 0.
173 173
174 @ingroup Genlist 174 @ingroup Genlist
175 */ 175 */