summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:29:22 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:33:52 +0900
commit0e977c83bd40515bdfbf6fd56079f916c286ce0e (patch)
tree7cb8618e363d16b8f8663a6928bcae6e7a605413
parenta1d26b3353c9f708faf41d078fe3a5fdc0a19bae (diff)
elm - genlist item - index get start from 0 - unbreak api break
so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1 rather than 0. going back to elm code in 1.7 - it started at 0. this is an api break that shouldn't have happend, but did. this fixes that. yes - it's inconsistent with gengrid's index_get - but gengrid here is wrong. nth_get starts at 0. this will get fixed with eo api's, and in fact none of these index/nth api's should be in genlist's eo api. legacy only. i can see why this was changed - it matches gengrid and is more consistent, but we can't break things even if stupid. @fix
-rw-r--r--src/lib/elm_genlist.c2
-rw-r--r--src/lib/elm_genlist_item.eo2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 22b5de134..aae1e0589 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -7237,7 +7237,7 @@ elm_genlist_item_cursor_engine_only_get(const Elm_Object_Item *eo_it)
7237EOLIAN static int 7237EOLIAN static int
7238_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it) 7238_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it)
7239{ 7239{
7240 int cnt = 1; 7240 int cnt = 0;
7241 Elm_Gen_Item *tmp; 7241 Elm_Gen_Item *tmp;
7242 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1); 7242 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1);
7243 7243
diff --git a/src/lib/elm_genlist_item.eo b/src/lib/elm_genlist_item.eo
index d78a06d47..a3cb674d7 100644
--- a/src/lib/elm_genlist_item.eo
+++ b/src/lib/elm_genlist_item.eo
@@ -206,7 +206,7 @@ class Elm.Genlist_Item(Elm.Widget_Item)
206 /*@ 206 /*@
207 Get the index of the item. It is only valid once displayed. 207 Get the index of the item. It is only valid once displayed.
208 208
209 The index start from 1. 209 The index start from 0.
210 210
211 @ingroup Genlist 211 @ingroup Genlist
212 */ 212 */