summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:29:22 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:32:32 +0900
commit2155eecb586888c70e7356eaa12f15c323e0077b (patch)
tree865655db3e4fe10361efc040b5471cce9de08571
parentb6e0282ad8b45990ca30ac3347ee2bf79ff932e3 (diff)
elm - genlist item - index get start from 0 - unbreak api break
so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1 rather than 0. going back to elm code in 1.7 - it started at 0. this is an api break that shouldn't have happend, but did. this fixes that. yes - it's inconsistent with gengrid's index_get - but gengrid here is wrong. nth_get starts at 0. this will get fixed with eo api's, and in fact none of these index/nth api's should be in genlist's eo api. legacy only. i can see why this was changed - it matches gengrid and is more consistent, but we can't break things even if stupid. @fix
-rw-r--r--src/lib/elm_genlist.c2
-rw-r--r--src/lib/elm_genlist_item.eo2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 538e95491..c51e62ee9 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -7300,7 +7300,7 @@ elm_genlist_item_cursor_engine_only_get(const Elm_Object_Item *eo_it)
7300EOLIAN static int 7300EOLIAN static int
7301_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it) 7301_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it)
7302{ 7302{
7303 int cnt = 1; 7303 int cnt = 0;
7304 Elm_Gen_Item *tmp; 7304 Elm_Gen_Item *tmp;
7305 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1); 7305 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1);
7306 7306
diff --git a/src/lib/elm_genlist_item.eo b/src/lib/elm_genlist_item.eo
index 695296ee9..abaf1e00b 100644
--- a/src/lib/elm_genlist_item.eo
+++ b/src/lib/elm_genlist_item.eo
@@ -170,7 +170,7 @@ class Elm.Genlist_Item(Elm.Widget_Item)
170 get { 170 get {
171 [[Get the index of the item. It is only valid once displayed. 171 [[Get the index of the item. It is only valid once displayed.
172 172
173 The index start from 1. 173 The index start from 0.
174 ]] 174 ]]
175 } 175 }
176 values { 176 values {