|author||Tom Hacohen <email@example.com>||2014-01-06 14:58:18 +0000|
|committer||Tom Hacohen <firstname.lastname@example.org>||2014-01-06 15:07:16 +0000|
Widget: Don't check if it's the correct class everywhere.
ELM_WIDGET_DATA_GET was checking it was the correct class. This is stupid and wrong (and makes tools rightfully complain) because these functions are implementations of that class anyway, so that would never be false. Functions that outside facing (that is, not called from eo_do) should use API_ENTRY.
1 files changed, 1 insertions, 2 deletions
|@@ -16,8 +16,7 @@ EAPI Eo_Op ELM_WIDGET_BASE_ID = EO_NOOP;|
|16||#define MY_CLASS_NAME_LEGACY "elm_widget"||16||#define MY_CLASS_NAME_LEGACY "elm_widget"|
|18||#define ELM_WIDGET_DATA_GET(o, wd) \||18||#define ELM_WIDGET_DATA_GET(o, wd) \|
|19||Elm_Widget_Smart_Data *wd = NULL; \||19||Elm_Widget_Smart_Data *wd = eo_data_scope_get(o, MY_CLASS)|
|20||if (eo_isa(o, MY_CLASS)) wd = eo_data_scope_get(o, MY_CLASS)|
|22||#define API_ENTRY \||21||#define API_ENTRY \|
|23||ELM_WIDGET_DATA_GET(obj, sd); \||22||ELM_WIDGET_DATA_GET(obj, sd); \|