summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:29:22 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2016-03-10 18:34:21 +0900
commitc1e79abe4b8fa71d62e0fab8a808475cbf8499fb (patch)
tree60f813aef4b76686dc4ffe3960a493cf6b32bde4
parent91db102d209437c68d4af336da0d0c3de7291dd7 (diff)
elm - genlist item - index get start from 0 - unbreak api break
so in feb 2015 seoz changed elm_genlist_item_index_get to start from 1 rather than 0. going back to elm code in 1.7 - it started at 0. this is an api break that shouldn't have happend, but did. this fixes that. yes - it's inconsistent with gengrid's index_get - but gengrid here is wrong. nth_get starts at 0. this will get fixed with eo api's, and in fact none of these index/nth api's should be in genlist's eo api. legacy only. i can see why this was changed - it matches gengrid and is more consistent, but we can't break things even if stupid. @fix
-rw-r--r--src/lib/elm_genlist.c2
-rw-r--r--src/lib/elm_genlist_item.eo2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index d351f28cf..cd7eac15e 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -7134,7 +7134,7 @@ elm_genlist_item_cursor_engine_only_get(const Elm_Object_Item *eo_it)
7134EOLIAN static int 7134EOLIAN static int
7135_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it) 7135_elm_genlist_item_index_get(Eo *eo_it EINA_UNUSED, Elm_Gen_Item *it)
7136{ 7136{
7137 int cnt = 1; 7137 int cnt = 0;
7138 Elm_Gen_Item *tmp; 7138 Elm_Gen_Item *tmp;
7139 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1); 7139 ELM_GENLIST_ITEM_CHECK_OR_RETURN(it, -1);
7140 7140
diff --git a/src/lib/elm_genlist_item.eo b/src/lib/elm_genlist_item.eo
index 80984ab94..32df599db 100644
--- a/src/lib/elm_genlist_item.eo
+++ b/src/lib/elm_genlist_item.eo
@@ -169,7 +169,7 @@ class Elm_Genlist_Item(Elm_Widget_Item)
169 /*@ 169 /*@
170 Get the index of the item. It is only valid once displayed. 170 Get the index of the item. It is only valid once displayed.
171 171
172 The index start from 1. 172 The index start from 0.
173 173
174 @ingroup Genlist 174 @ingroup Genlist
175 */ 175 */