AgeCommit message (Collapse)Author
2015-01-15genlist: don't access item after removing it.devs/hermet/developChunEon Park
2015-01-15genlist: guard the item deletion problem.ChunEon Park
this exceptional code prevents the deletion of the item in the middle of the callback.
2015-01-15Revert "Revert "genilst: get rid of lazy deletion.""ChunEon Park
This reverts commit 94f0f1ba40d6066d4bf8b7594c2c636b49966b16.
2015-01-15Revert "genilst: get rid of lazy deletion."ChunEon Park
This reverts commit 0e7d521151ba93f3b5955caaf9b906e160ab6057. Conflicts: src/lib/elm_genlist.c src/lib/elm_widget.h
2015-01-15genlist: revert partial code.ChunEon Park
this clearing items are still valid.
2015-01-15genlist: fix the access of the invalid items.ChunEon Park
still, there were case item or genlist is cleared in the user callback. don't access the cleared items if they are requested deletion.
2015-01-14genlist needs to also highlight items on keyboard selectMike Blumenkrantz
this should probably just happen in _item_select() to avoid future incidents ref T1986
2015-01-14Revert "genlist: fix a crash when deleting a item in selected callback."Mike Blumenkrantz
This reverts commit c80b24baf815e35c160bf0dbe8ecae6ea247aef8. this broke the selection callback completely and makes every genlist app unusable. please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.
2015-01-14genlist: fix a crash when deleting a item in selected callback.ChunEon Park
if user deletes the item in the callback, current function(_item_select) would be corrupted. just leave the callback call in the last of the function.
2015-01-14genilst: fix regression bug added in 0e7d521151ba93f3b5955caaf9b906e160ab6057ChunEon Park
some logic of deleting item were duplicated. this fixes fileselector crash issue.
2015-01-14Do not explicite include atspi headers.Lukasz Stanislawski
Summary: fixes make check failures on atspi tests. Reviewers: cedric Subscribers: seoz Maniphest Tasks: T2001 Differential Revision:
2015-01-14genlist: set missed item reference.ChunEon Park
this missing would cause crash of the genlist when it's items are cleared.
2015-01-14genlist: fix a crash of genlist group tree example.ChunEon Park
don't corrupt list pointer. we can clear items more simply. Thanks ya-kov for reporting.
2015-01-14widget: set missing elm_widget_item_magicChunEon Park
2015-01-13photocam: force reload of image on file_set.Cedric BAIL
Thanks, bug reported by .
2015-01-13elm image - fix image rotation in non-common casesCarsten Haitzler (Rasterman)
this fixes d6f4040d0c62c220f2339d2a57126fde43e85e19 for the non-common path that normalizes then applies new orientation @fix
2015-01-12elementary: Fix dereference of null return valueChris Michael
Summary: This fixes Coverity CID1261370. strrchr can return NULL here, so we need to check that 'p' is valid. @fix Signed-off-by: Chris Michael <>
2015-01-12release: Update NEWS and bump version for 1.13.0-alpha1 releasev1.13.0-alpha1Stefan Schmidt
2015-01-12Elm win: Fix added internal parameter to the win constructor.Tom Hacohen
Internal hacks should not affect user facing API. This commit adds a new API to do the internal hack. This is still bad, but it's much less than what was there before. This fixes the main issue introduced by commit: 63a5cdf0f8516c16a62233da0c2af0e10a13264b
2015-01-12Elm win: Fix elm_win_fake()'s name to follow conventions.Tom Hacohen
2015-01-12DnD: fix callbacks deletion for inline windows.Daniel Zaoui
During deletion of a window, widgets considered as droppable targets have to remove their DnD callbacks. To achieve this, elm_drop_target_del is called from the DEL callback (destructor). This function has to determine if X11 or Wayland is used. Since the parent is already unknown at this stage, only checking the engine name can give this information. On a regular window, the engine name is related to the target display. The problem happens when an inline window is used. The engine is a buffer and no information is given regarding the target display. The patch fixes it by checking the nature of the Ecore Evas parents. It supports nested windows (inline inside inline... inside XWin). @fix
2015-01-12elm_colorselector: Fixed to make palette_box have proper heightJee-Yong Um
Summary: palette_box had stretched height exceeding its items size. Now it will have proper height fitting to own items. Reviewers: Hermet, Jaehyun, raster Reviewed By: raster Subscribers: raster, Hermet Differential Revision:
2015-01-12elm - fix build problem with examples - elocation apiCarsten Haitzler (Rasterman)
this fixes build of location_example_01.c as per fix in D1863 but done properly so people can't use elm elocation unless they enable beta apis
2015-01-12Scroller : Fix elm_scroller_last_page_get API wrong return valueVBS
Summary: When first page is last page, elm_scroller_last_page_get need to return 0. But if pagesize is bigger then current content height or width, value will be returned -1. So fix this cases to return 0. Test Plan: If set elm_scroller_page_set bigger then current content size, then issue is occurred. Reviewers: seoz, jaehwan, raster Reviewed By: raster Subscribers: eagleeye Differential Revision:
2015-01-12elm - elm image orientation api fix - major bug in implementationCarsten Haitzler (Rasterman)
@fix The elm image orient_set api looks like it is a state, and it is documented to SET the orietnation, but the code actually DOEs that orientation when you set it. so docs and api name didnt match functionality at all. this was bad an an oversight. you didn't notice until you set orientation multiple times to an image. this fixes the implementation to be as documented - a state that is applied and remains that way until set to something else. setting to the same orientation has no efect as with color, size, etc. etc. in evas. you could look on this as an api break, but then either the docs change AND api name changes to match the code, or code changes to match the docs. we don't keep bug compatibility in efl and in this case i'm making the call to break the behavior of a function as it was broken already with respect to name and docs.
2015-01-12genlist: recommit 1879cc39258c63c24f0abcff56558b1f1b60167a with correction.ChunEon Park
2015-01-11elm_table now supports alignmentMike Blumenkrantz
2015-01-11fake win should not perform widget focus setting on canvas focus-inMike Blumenkrantz
2015-01-11Revert "genlist: use eina bool"Yakov Goldberg
This reverts commit 1879cc39258c63c24f0abcff56558b1f1b60167a. Hermet, please check this commit it makes Fileselector crash, looks like you inverted the values: 1 should be EINA_TRUE. I recommend you to use Exactness to run all the tests automatically.
2015-01-10genlist: remove unnecessary null check.ChunEon Park
2015-01-10genlist: revert 6f177e5db01553276058235a81cbfcc9b2cd4e23ChunEon Park
this broke decoration item text. reverted.
2015-01-10genlist: send decoration active signal to view item.ChunEon Park
emit signal to view item to do something additional.
2015-01-10genlist: fix regression bug. (T1986)ChunEon Park
newly added in 2955ebc5dd01fbfb5a3286b724c8a40915864ad8
2015-01-10ELM_WIN_FAKE types should allow focus callbacks on windowsMike Blumenkrantz
2015-01-10entry now finds its window object more effectively for cnp initMike Blumenkrantz
2015-01-10+elm_win_fake(), ELM_WIN_FAKE typeMike Blumenkrantz
this is a giant hack to provide widget parenting in e. do not use this function, do not use this type, do not even read the related documentation. @feature
2015-01-10genlist: code refactoring.ChunEon Park
clean up decorate_item_realize() function. use macro and remove old debug code. no actual logical change.
2015-01-09genlist: clean up genlist_smart_del() func.ChunEon Park
removed unnecessary calls.
2015-01-09widget: remove redundant internal macrosChunEon Park
we don't need these macros anymore since eo has introduced.
2015-01-09Do not call ecore_x_init() when not using X display.Jean Guyomarc'h
Summary: On some systems (e.g. OS X), both Apple's windows manager and X11 can cohabit, therefore we need to check for the DISPLAY environment variable only when ELM_DISPLAY is not specified. Reviewers: cedric, devilhorns, seoz, raster Reviewed By: raster Differential Revision:
2015-01-08client frame client clip should be relative to client during clip, not borderMike Blumenkrantz
ref T1930
2015-01-08genlist: if the item was selected, then skip item_select() procedure.ChunEon Park
2015-01-08genlist: simple code clean upChunEon Park
no logic change.
2015-01-08genlist: use eina boolChunEon Park
2015-01-08genilst: descriptive comment++ChunEon Park
2015-01-08genlist: remove internal callback usage.ChunEon Park
there were multiple ports for item procedures. one port is enough.
2015-01-08genilst: get rid of lazy deletion.ChunEon Park
delete genlist item directly. instead, remove the bunch of code that was related to lazy deletion. we can success, if we clean up the resources and callback calls properly. here i only found item focus callback that (may) required the lazy deletion.
2015-01-08theme: Add newly added icons to EXTRA_DIST to make sure they end up in the ↵Stefan Schmidt
tarball We need to list the icons here to let autotools know we want them int the release tarballs.
2015-01-08Revert "win INLINE_IMAGE test now crashes as expected when trying to use it ↵Daniel Zaoui
in a non-useless manner" This reverts commit fd71874024d14e5374aef93eae7d4cfbc0ea4521. As the commit message says, the test crashes now. The ticket 1973 is related to that issue. Now, I understand there could be a bug inside inline stuff but it doesn't mean that you have to push it and screw up all the test. You could just attach a patch to the ticket and that's all folks!
2015-01-08genlist: send signal to deco_all_view additionally.ChunEon Park