AgeCommit message (Collapse)Author
2015-06-09Cnp/Wl: remove entry-only codedevs/thiep/dndThiep Ha
This patch removes the entry-only code which is used to paste text to entry widget only. The function now is hanlded inside entry.
2015-06-09Cnp/Wl: correct object parameter in datacbThiep Ha
This patches corrects object parameter in datacb by changing it to the selection request object.
2015-06-09Dnd/X11: add dnd support for image, uri typeThiep Ha
This patch adds dnd support for image and uri type. @fix
2015-06-09Cnp/X11: correct object parameter in datacbThiep Ha
The object parameter in datacb must be the selection request object, not the selection owner object. This patch corrects that. Test case: open two windows with entry, copy text from one entry in first window, paste to entry in other window. @fix
2015-06-09Cnp/X11: move entry-only code in elm_cnp to entryThiep Ha
There is code in elm_cnp.c which is used to paste data to entry widget only. This can cause error if widget is not entry. This patch removes that code in elm_cnp.c and adds datacb to entry to insert content to entry. @fix
2015-06-02Revert "First review"Thiep Ha
Get back to working code but keep the review log This reverts commit ae12f0c835c7d2a9c4d7b292620842029669e9fe.
2015-06-02First reviewDaniel Zaoui
Hi Thiep, I finally had time to review dnd. I put my comments in this patch. One important thing is that we don't have to see the X11 implementation as a strong reference. A lot of code is shitty there and we should throw it on both implementations. I didn't review all the code as I think there is a lot to fix already and open issues. Concerning the notify stuff, I don't think we should conserve the X11 way (i.e call cb inside notify or entry/image functions). We could, for example, create data preparers that would be invoked before cb is called. Daniel
2015-06-02Dnd/Wl: remove hard-coded drop accept typeThiep Ha
Drop accept type is hard-coded and not fully supported for all types. This patch provides fixes it.
2015-06-02CnP_DnD/Wl: replace strcmp with eina hash functionThiep Ha
Replace for loop and strcmp by eina hash function.
2015-06-02CnP/Wl: Add data notify handling for cnpThiep Ha
Data notify handlers support only drag & drop for now. This patch adds data notify handling for copy & paste also.
2015-06-02CnP_DnD/Wl: only providing uri type when data is uri typeThiep Ha
When selection owner provides uri types (text/uri; text/uri-list), it should check if data is in correct format.
2015-06-02CnP/Wl: get list of supported types from selection ownerThiep Ha
When we get selection, it is better to get the list of supported types from selection owner first. And then, we can choose correct type we want.
2015-06-02CnP/Wl: Set selection for all data typesThiep Ha
Currently, we hardcode selection types when we do selection set. Besides, not all selection data types are set. This patch sets selection for all suitable types that we supported.
2015-06-02CnP/Wl: Remove duplicated data receive callbackThiep Ha
If we do drag & drop and then do copy & paste, both _wl_selection receive and _wl_dnd_receive are called for one action (dnd or cnp). It is redundant. We only need one data received callback to handle two cases dnd and cnp.
2015-06-02CnP/Wl: Remove duplicated data send callbackThiep Ha
If we do drag & drop and then do copy & paste, both _wl_selection_send and _wl_dnd_send are called for one action (dnd or cnp). It is reduntdant. We only need one callback to handle two cases dnd and cnp.
2015-06-02DnD/Wl: Entry should handle image dropThiep Ha
When image is dropped into entry, we should insert image to the entry. This patch checks drop format and inserts image to entry if needed. Test case: Run elementary_test with wayland, Types Dnd, drag image and drop it to right entry.
2015-06-02test/Dnd: Correct drag data extractThiep Ha
If data is not started with a FILESEP, extract function returns wrong data. This patch fixes this bug case. Test case: Drag two items in gengrid or genlist of dnd test cases and drop to others.
2015-06-02DnD/Wl: Add types' notify handlersThiep Ha
This patch adds notify handlers for types. It provides different ways to handle different data types.
2015-06-02DnD/Wl: Add type convertersThiep Ha
We support different types for DnD, but there is no converters. This patch adds converters for types, so that we can send different data for different types.
2015-06-02examples: Replace setenv() with elm_config_accel_preference_set().Jaehyun Cho
Replace environment value set with elm_config_accel_preference_set.
2015-06-02examples: Replace preferred engine "opengl_x11" with accel preference "3d".Jaehyun Cho
Replace preferred engine "opengl_x11" with accel preference "3d".
2015-06-02Focus: add and fix commentsDaniel Zaoui
2015-06-02missed from prvious commitWooHyun Jung
2015-06-02elm_focus: added new focus move policy and elm_object_focus_move_policy_set/getWooHyun Jung
New focus move policy, ELM_FOCUS_MOVE_POLICY_KEY_ONLY, is added. If you set this policy as base focus move policy, objects cannot steal focus by using mouse click or mouse in. Only keyboard input (such as Left, Right, Up, Down, ...) can make focus be moved. Additaionally, an object can have its own focus move policy by using elm_object_focus_move_policy_set API. @feature
2015-06-01Elm widget: Fix some Eolian warnings.Tom Hacohen
2015-05-29Revert "Spinner: Add changed callback call when spinner value set."ChunEon Park
This reverts commit 8278dff6a742c391f7c04c3de1033574d818dbb6. This is not good for scenarios and will break the compatibility. Thanks to David for reporting.
2015-05-28tooltip: fix positioning when tooltip is affixed to a window objectMike Blumenkrantz
2015-05-28glview: preserved changed state when altering render modeMike Blumenkrantz
fixes the case where glview is marked changed and then the render policy is modified prior to the render callback executing @fix
2015-05-28Adjust according to Eo changes.Tom Hacohen
2015-05-28gengrid/genlist: decrement item counter before triggering item del callbackMike Blumenkrantz
2015-05-28Gengrid: fix mirroring bug in gengrid widget.SangHyeon Lee
Summary: Below bugs are exist in gengrid widget when use horizontal mode and mirrored set. 1. Gengrid item is placed wrong position when mirrored set. Current calulation for mirroring in _item_place only consider pan object positions. if widget is mirrored, item should be placed opposited position so object x position must be consider in mirroring calculation also. 2. Gengrid scroll(pan) minimum size is returned wrong value when mirroed set. As the result of 1's calculation present oposite position of items, so align also reversed when mirrored. but current gengrid didn't change align x so minimum size is return wrong value and scroller expanded wrong direction. @fix Test Plan: 1. run elementary_test and set mirroring On 2. run Gengrid2 in elementary_test 3. see how items are placed by push append button repeatly. 4. see scroller shows correct position and items. 5. change usr/bin/test_gengrid.c to set another align value on gengrid and test again. Reviewers: raster, seoz, Hermet, jaehwan Subscribers: Jaehyun,, eagleeye, singh.amitesh Differential Revision:
2015-05-28Spinner: Add changed callback call when spinner value set.woochan lee
Summary: There is a code to compare value is changed. 1256: if (sd->val == val) return; Even value changed the value changed callback didn't called before. Reviewers: woohyun, shilpasingh, Hermet Reviewed By: shilpasingh, Hermet Differential Revision:
2015-05-28genlist: do a proper clean up in clear().Amitesh Singh
Summary: Signed-off-by: Amitesh Singh <> Reviewers: raster, Hermet Subscribers: seoz, Differential Revision:
2015-05-28clipper: removed.ChunEon Park
we've discussed and concluded it's unncessary.
2015-05-28elm - fix profile handling if ELM_PROFILE is set - dont listen to x msgCarsten Haitzler (Rasterman)
@fix don't listen to x profile set msg if ELM_PROFILE env var is used - this overrides.
2015-05-28elm = fix window norender handlingCarsten Haitzler (Rasterman)
this delays norender and throttle handling to allow for quick show/hide etc. changes an app may make so to not jump state so often. this also fixes an issue wqhere config may change leaving all windows in norender mode.
2015-05-28po/ko: Updated Korean translation.Daniel Juyung Seo
2015-05-28examples/evas3d: Use correct variable type for a return value.Daniel Juyung Seo
2015-05-27elm theme - remove commented out efm icon lines so as not to confus peopleCarsten Haitzler (Rasterman)
2015-05-27gengrid: implement Atspi_Selection interfaceLukasz Stanislawski
Allow to select and deselect gengrid items by Assistive Technology Clients through org.a11y.atspi.Selection dbus interface.
2015-05-26test_glview: remove warning while compiling the elementary packageAnand
Summary: test_glview.c: In function ‘_print_gl_log’: test_glview.c:347:10: warning: declaration of ‘log’ shadows a global declaration [-Wshadow] Reviewers: JackDanielZ Differential Revision: Signed-off-by: Cedric BAIL <>
2015-05-26toolbar: implement Atspi_Selection interfaceLukasz Stanislawski
Allow to select and deselect toolbar items by Assistive Technology Clients through org.a11y.atspi.Selection dbus interface.
2015-05-26genlist: implement Atspi_Selection interfaceLukasz Stanislawski
Allow to select and deselect genlist items by Assistive Technology Clients through org.a11y.atspi.Selection dbus interface.
2015-05-26theme - efm - redo folder to stand out more amongst all the file iconsCarsten Haitzler (Rasterman)
the paper with earmarked corner and dir in it just doesn't stand out. too plain and so you can't tell dirs from other files easily at all. replace with a more normal foler icon that now stands out.
2015-05-25update po'sCarsten Haitzler (Rasterman)
2015-05-25theme - add more efm basic file type iconsCarsten Haitzler (Rasterman)
Icons by ApB - see T1582 - fixes T1582 not really a bug ... just more icons. :)
2015-05-22Genlist: support of ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY mode of genlist item ↵Umesh Tanwar
for ELM_ITEM_SELECT_ON_FOCUS_DISABLE config variable. Summary: When environment variable ELM_ITEM_SELECT_ON_FOCUS_DISABLE is set _item_focused_next() function doesn't support for ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY mode. Signed-off-by: Umesh Tanwar <> @fix Reviewers: raster, Hermet Subscribers: singh.amitesh, Differential Revision:
2015-05-22elm config - init wl if env vars indicate we shouldCarsten Haitzler (Rasterman)
this ensures event id's are initted and more if we are in wl mode like in x11 mode @fix
2015-05-22test_genlist: Fix warnings while running "Genlist Textblock".Amitesh Singh
Summary: 'Genlist Textblock' uses message style which does not have elm.swallow.icon part. Signed-off-by: Amitesh Singh <> Test Plan: elementary_test -to "Genlist Textblock" Reviewers: raster, Hermet, JackDanielZ Subscribers: seoz, Differential Revision:
2015-05-22fileselector button: correct window parent findingThiep Ha
Summary: Fileselector button fails to run in inwin mode. It is caused by incorrect window parent finding. This patch corrects the window parent finding. @fix Test Plan: run FileSelector Button, toggle Inwin mode option to on, eo gives error and nothing is shown. Reviewers: Hermet, seoz Reviewed By: seoz Differential Revision: