Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
|
|
code.
- removed unnecessary casting.
- removed unnecessary internal variables.
- removed wrong window resize object addition.
- changed parent parameter correctly.
- fixed wrong grammar in command line message.
- fixed resource leak.
- enhanced comments.
- removed unnecessary size hint align set.
- removed unnecessary parameter passing.
|
|
|
|
Summary: This fixes coverity issue CID 1162751.
Reviewers: seoz, woohyun, tasn
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D482
|
|
As all efl public free apis and free function get null as valid parameter,
we do not need to check null. I also used ELM_SAFE_FREE if necessary.
After this job code got cleaner.
This is a continue of a commit e3372339.
|
|
elm_widget_stringlist_free.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
to recommended APIs.
|
|
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
|
|
recommended
APIs.
|
|
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
|
|
- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.
|
|
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
|
|
Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().
Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.
This patch introduced fileselector interface and applied it to elm_fileselector.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D475
|
|
Do not create the internal entry on smart add. Create that when it is
needed with editable mode.
|
|
|
|
If edje_object_part_text_get gives different text from original one,
length of text can be changed. So the last position of tmpbuf should
be calculated again refering to the current text to be returned.
|
|
space key works as same as Return key.
|
|
|
|
This is a successor commit of 64fd5a825b24591aedb9cac695d03f5b4d867442.
Window show call triggers all smart objects' smart calculation and in case of
X11, XMapWindow() is called directly.
Also moved resize of window accordingly.
|
|
|
|
There are elm_widget_theme/theme_set/theme_get functions.
In Eolian these functions will be described as "theme" method and
"theme" property. There is clash here.
So add suffix "_apply" to Eo API for "elm_widget_theme".
|
|
Summary:
Gengrid _item_show_region function calculate gengrid x, y moving postion with scroll to type.
Belows are summaries of this refactoring works.
1. Refactoring recalculation of scroll type.
2. Bug fix :
- when x or y is 0, y or x value is set as default value, it->position-1.
- when x or y is less then 1, calculation is not correct.
- make calculate correct position of y when even though scroll direction is horiziontal
(when virtical, x is also calculation correct position).
3. change smart data variable s_type to scroll_to_type to make unity on gen widget.
(genlist smart data variable name is scroll_to_type);
Reviewers: seoz, Hermet, raster
Reviewed By: raster
CC: bluezery
Differential Revision: https://phab.enlightenment.org/D474
|
|
Also the image used by the edc need to be included in the tarball
|
|
|
|
|
|
Adding it to EXTRA_DIST makes ure it gets packaged in the tarball
and is available for a plain tarball build.
|
|
Summary:
The geometry of elm_widget_show_region_get is only updated by elm_widget_show_region_set.
If the geometry of *show_region_get is not updated, the result of show_region_job would be incorrect.
So, we need to get a proper geometry using *focus_region_get for focused object.
Reviewers: seoz, woohyun, Hermet, raster, tasn
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D466
|
|
Summary:
In TTS mode, when the entry is highlighten and double tap to the entry,
the entry will be focused. But "clicked" smart callback is not called, input panel is not shown.
So I we need to call the callback and show input panel in smart activate.
Reviewers: seoz, Hermet, woohyun, tasn, jaehwan, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D465
|
|
scr_edje too.
Summary:
Default theme of entry does not have any disabled state in "elm/scroller/entry/*" styles.
But EFL developer can make any custom style for entry and scroller and it can has disabled state.
So _elm_entry_smart_disable has to emit "*disabled" signal to scr_edje.
Reviewers: woohyun, tasn, seoz, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D464
|
|
|
|
documentation.
fileselector_button initialize inwin mode using the configuration.
Fixed wrong information about default value in API documentation.
In addition, fixed test_fileselector_button.cpp not to show wrong information at initial time.
|
|
|
|
seriously, this is and has been bullshit since it was added. I don't need an error message every time I do ANYTHING just because some module has never been found.
|
|
T793
|
|
The data for callback is stored in Widget's data variable.
So, Elm_Flipselector_Item's data variable is not needed.
|
|
intended.
Since e2db48abe, disabled flipselector was passed button callbacks.
So, buttons just print warnings instead of the intended behavior.
|
|
_smart_add
There are some warnings in elm_object_disabled_set() because elm_layout_theme_set()
calls _elm_datetime_smart_disable() before creating file->item_obj.
This patch refactors _smart_add to initialize file->item_obj before calling
elm_layout_theme_set().
|
|
elementary/src/lib/elm_access.h:238: warning: Found unknown command `\type'
elementary/src/lib/elm_bg_legacy.h:98: warning: Found unknown command `\r'
elementary/src/lib/elm_bg_legacy.h:98: warning: Found unknown command `\g'
elementary/src/lib/elm_object.h:124: warning: Found unknown command `\content'
elementary/src/lib/elm_image_legacy.h:82: warning: Found unknown command `\group'
elementary/src/lib/elm_image_legacy.h:56: warning: Found unknown command `\group'
|
|
- Check whether ret is NULL.
- Guarantee hidden variable is only EINA_TRUE or EINA_FALSE.
|
|
sd->content can be NULL when elm_panel_hidden_set is called.
|