path: root/src/lib/elm_toolbar.c (follow)
AgeCommit message (Collapse)Author
2014-11-12Object Items: remove data variable from widget item.Daniel Zaoui
Now, data is stored in Eo layer via eo_key_data_set/get. Two macros have been added to facilitate access.
2014-11-12Object Items: remove legacy APIs.Daniel Zaoui
They are now generated by Eolian.
2014-11-12Elm Toolbar Item: Migrate to EoDaniel Zaoui
2014-11-12Elm Widget Item: Migrate to EoDaniel Zaoui
Since we want to support legacy inheritance mechanism, code is not finished and will have to be cleaned when all the items are ported.
2014-10-17atspi: properly include at-spi headers.Lukasz Stanislawski
Summary: Change requested by TAsn. Previuosly AT-SPI headers were kept private and included directly into elementary source code. From now on, AT-SPI headers can be included from Elementary.h public header, however will be marked as beta APIs. Commit includes following changes: * include all atspi headers into new elm_interfaces.h header. * marking all at-spi interfaces methods/properties as @protected. * wrap all common headers with EFL_BETA_API_SUPPORT. * make some common APIs visible in lib, by adding EAPI attribute (if someone decides to use beta APIs). Test Plan: out-off tree build with gcc, g++ Reviewers: tasn Reviewed By: tasn Subscribers: seoz, q66, kuuko Maniphest Tasks: T1721 Differential Revision:
2014-09-25Eo related: Change according to recent changes in eo_add().Tom Hacohen
For more info check out a7560dbc61953c3652780f232e38adbd2d711972 in the EFL tree.
2014-08-22gengrid, genlist, list, toolbar: Fixed DISPLAY_ONLY select mode for an object.Daniel Juyung Seo
DISPLAY_ONLY select mode for elm_xxx_item_select_mode_set works fine but elm_xxx_select_mode_set was broken. @fix
2014-07-25atspi: expose more actions through atspi bus.Lukasz Stanislawski
Summary: Main purpose of exposing widget actions and keyboard shortcuts is to allow accessibility clients to implement alternative methods of GUI navigation. Reviewers: z.kosinski Reviewed By: z.kosinski Subscribers: seoz Differential Revision:
2014-07-21Focus: first item should be focused when there is no focused/selected itemAnil Kumar Nahak
Summary: First item of widget should be focused when focus comes to the widget for first time. Test Plan: elementary_test -to "Genlist Focus" elementary_test -to "Gengrid Focus" elementary_test -to "List Focus" elementary_test -to "toolbar Focus" Reviewers: seoz Differential Revision:
2014-07-20toolbar: added selected and unselected smartcallbacks to toolbar.Daniel Juyung Seo
- Item based widget should emit this signal. This is good for the consistency and makes application developers easy to guess. - Added test case to elementary_test -> toolbar @feature
2014-07-20toolbar: changed internal variable name sanely.Daniel Juyung Seo
Do not need to use 'obj2' as an object variable name as we can use 'obj' as usual.
2014-07-07list/genlist/gengrid/toolbar: removed unused smart data member ↵Amitesh Singh
prev_focused_item. Reviewers: raster, seoz CC: seoz Differential Revision:
2014-07-04toolbar: fix focus highlight bug in toolbarWooHyun Jung
When getting focus_highlight geometry from toolbar, there can be a case that no item has focus. Then, geometry of toolbar should be refered.
2014-06-25Toolbar: Fixed wrong toolbar resize logicHosang Kim
Summary: When toolbar use ELM_TOOLBAR_SHRINK_SCROLL and toolbar viewport size is decreased rapidly, toolbar box size is not changed. Test Plan: elementary_test -> toolbar 2 increase window size -> decrease window size(presto) -> toolbar size is wrong Reviewers: seoz, woohyun, jaehwan, Hermet, raster Reviewed By: seoz Differential Revision:
2014-06-11atspi:Set roles for widgetsZbigniew Kosinski
Reviewers: stanluk, m.jagiello, raster Differential Revision:
2014-06-03Elm: Update code to use the new class names generated by eolian.Tom Hacohen
2014-05-26genlist: fixed wrong item focus set on item_focus_set API call.Daniel Juyung Seo
Reset the last_focused_item on _item_focus_set_hook. This fixes the issue which sets the focus to the wrong item when the focus is set by an API. Reproduction step: elementary_test -> genlist focus -> click an item (not the 2nd item) -> click "Focus 2nd Item after 1.5 seconds" button. Focus is not moved to the 2nd item. @fix
2014-05-26toolbar: changed internal variable types to sync with other widgets.Daniel Juyung Seo
Changed the variable type from (Elm_Toolbar_Item *) to (Elm_Object_Item *) for focused_item, last_focused_item, and prev_focused_item.
2014-05-12focus: update the focus in_theme status on each item's focus set.Daniel Juyung Seo
As widget and widget item can have different in_theme value (since 30cada369), we need to update in_theme value whenever the widget or widget item get the focus. Applied this logic to genlist, gengrid, toolbar first. List focus is not working well at the moment. This fixes small focus highlight on the left top corner of genlist when the genlist scroller is clicked before the genlist is focused. Special thanks to zmike for the report.
2014-05-11focus: Change new API names related to focus auto scrolling.Daniel Juyung Seo
elm_config_focus_auto_scroll_bring_in_enabled_get/set() -> elm_config_focus_autoscroll_mode_get/set() The main reason is that bring_in_enabled_get/set() APIs are too restricted and thus not flexible. I got more requirements for the focus autoscrolling such as none, wholely visible not just bring_in and show. So it is correct to add mode_set/get() APIs for the focus auto scrolling. Thanks god, we've found this before the release :) @feature
2014-05-11Revert "remove all scrolling changes for focused items."Daniel Juyung Seo
This reverts commit 377179bdaf84aa1a86621cdfa64ed43613ab9d45. The main claim of was fixed in the previous commit 30cada369. This code will be modifed again in the next commit due to the api change during development life cycle. Note: do not blindly revert this commit if you have any problem with widget item focus. This commit is not related to any fundamental cause of the issues. If you have a problem, please contact me first. or SeoZ on IRC. Thanks.
2014-05-11gengrid/genlist/list/toolbar: Do not set the focus to the item on widget's ↵Daniel Juyung Seo
first focus. This was introduced during 1.10 development phase but this changed the default focus behavior and got a lot of complaints. (especially from discomfitor) So I would like to comment this out now and make it optional on 1.11 by keeping the default behavior.
2014-05-07Revert "Revert "focus: Removed unused parameter from an internal focus ↵zmike
function."" This reverts commit b8549f3e83a8592145a50085182583adead2c74e. this build system is bad and whoever did the eo integration should not feel pleased with themselves.
2014-05-07Revert "focus: Removed unused parameter from an internal focus function."zmike
This reverts commit 5832b692aa5f68a2924bd7886390d489eb13aefb. broke build
2014-05-07remove all scrolling changes for focused items.zmike SERIOUSLY. you cannot go scrolling all over the place in every widget that has a scroller just because the widget gets focus. what user wants that? no user anywhere, under any circumstances, ever, in all of history. if you dare to put this back in, I will continue to remove it for the rest of eternity until it never, ever scrolls in any unwanted case. the focused item doesn't have to always be in the viewport, and should never be moved into the viewport [[[[[[[ except to maintain an already-existing position inside the viewport ]]]]]]] too much of my time wasted on this stupid "feature" which should have been MUCH more thoroughly tested and reviewed before it was merged. T1205 STILL NOT FIXED
2014-05-07focus: Removed unused parameter from an internal focus function.Daniel Juyung Seo
is_next parameter is not used for elm_widget_focus_highlight_geometry_get() function. But this parameter was not cleaned up in the commit 5320cca.
2014-04-27config: Added two APIs to enable/disable focus auto scroll bring in feature.Amitesh Singh
Summary: Summary: - APIs - elm_config_focus_auto_scroll_bring_in_enabled_set - elm_config_focus_auto_scroll_bring_in_enabled_get - list/genlist/toolbar/gengrid: Using this feature for scrolling for focus movement. - Added test case in "List Focus", "Genlist Focus", "Toolbar Focus" and "Gengrid Focus" @feature Test Plan: elementary_test->"List Focus", "Genlist Focus", "Toolbar Focus" & "Gengrid Focus". Reviewers: raster, seoz CC: seoz Differential Revision:
2014-04-27toolbar: Fixed wrong edje api usage for elm objects.Daniel Juyung Seo
This bug was introduced by the commit 4c8677166163316468da56c53b203ac572085c40 this January. @fix
2014-04-21entry: wrong viewport value calculation issue fixCarsten Haitzler (Rasterman)
Summary: Issue: As entire scroller edje co-ordinates was being taken instead of the actual viewport value, if in scroller edje more parts are added apart from just "elm.swallow.content", then the viewport value set will be wrong. hence the selection handlers will not hide when they have to hide. solution: Instead of taking scroller edje's geometry, get the actual viewport values. To get viewport x,y a new scrollable interface is also added. signed-off by: Shilpa Singh <> @fix Test Plan: Selection handlers have to hide correctly when the text is scrolled in a scrolled entry, if the scroller edc of entry has more parts added other than elm.swallow.content, then when we scroll the selection handlers are not hidden correctly. Reviewers: jaehwan, woohyun, seoz, Hermet, raster CC: govi, rajeshps, thiepha Differential Revision:
2014-04-16widgets - don't handle the events(key,mouse) if the object is disabled.ChunEon Park
we can prevent to handle the widget events from the widget infra, if the object is disabled. conceptually, disabled object should not be interacted to user input(key, mouse)
2014-04-15toolbar: apply key bindingJaeun Choi
Summary: This patch applies key binding to elm_toolbar. Test Plan: None Reviewers: Hermet, raster Differential Revision:
2014-04-13toolbar: Initialized some internal variables.Daniel Juyung Seo
This fixes coverity CID 1199658, 1199659.
2014-04-10toolbar: Adjusted to Eo2.Tom Hacohen
2014-04-04list/genlist/gengrid/toolbar: Fix - _nearest_visible_item_get() should ↵Amitesh Singh
always return an item. Test Plan: Bug: - elementary_test->genlist/list/toolbar/gengrid Focus - Resize the window to a state when no item is fully visible. only partially visible. - Move Focus from outer widgets (Up/Down/Left/right buttons) to list/genlist/gengrid/toolbar. - Focus goes away (size - 0). Reason: _nearest_visible_item_get returns NULL. @fix Reviewers: seoz, raster, woohyun Reviewed By: raster CC: seoz, nirajkr, Differential Revision:
2014-04-01toolbar: Added focus movement on widget items by mouse in.Amitesh Singh
Summary: - Added a test case in "Toolbar Focus". @feature Test Plan: elementary_test->Toolbar Focus Reviewers: raster, cedric, woohyun Reviewed By: raster CC: seoz Differential Revision:
2014-03-31Eolian: Integration of ToolbarDaniel Zaoui
2014-03-25toolbar - fixed to use elm apis for elm objectsChunEon Park
2014-03-25fix segv in toolbar item focus (new feature)Carsten Haitzler (Rasterman)
2014-03-24toolbar: Check disabled status of an item in nearest visible item.Amitesh Singh
Summary: Also - corrected the code for getting the toolbar item from the list. - added a test for it. Test Plan: elementary_test -> "Toolbar Focus" Reviewers: seoz CC: seoz Differential Revision:
2014-03-24toolbar: implemented widget item focus feature.Amitesh Singh
Summary: 1. Added "item,focused" and "item,unfocused" smart callbacks. 2. Added _elm_toolbar_focus_highlight_geometry_get(). 3. Implemented elm_object_item_focus_set() and elm_object_item_focus_get(). 4. Implemented elm_object_focused_item_get() 5. Ported _elm_toolbar_nearest_visible_item_get from cc827fef6. 6. Added Test Case "Toolbar Focus". @feature Test Plan: elementary_test->Toolbar Item Focus Reviewers: seoz, woohyun, raster CC: nirajkr, raster Differential Revision:
2014-03-20toolbar: Fixed wrong parameter for elm_widget_sub_object_del.Daniel Juyung Seo
Remove the icon from the sub object list for a widget not for an edje object.
2014-03-18Eolian: Integration of Scrollable InterfaceDaniel Zaoui
2014-03-17Eolian: Integration of Elm WidgetDaniel Zaoui
2014-03-16segment_control, toolbar: Fixed broken scale of widget item.Daniel Juyung Seo
@fix. This needs to be partially backported.
2014-03-12Ship missing headers, and remove wrong includesTom Hacohen
elm_gen_common.h was not installed, but is needed by installed headers. Remove dependencies on internal headers from shipped headers.
2014-02-08access: Add smart signal "access,changed"Jaehwan Kim
It occurs that access mode is changed. Application can add this callback for each widget.
2014-01-23elementary - override widget translation but work also the base widget's ↵ChunEon Park
behavior. Some widgets override the widget translation but it didn't inherit the base widget's function. Becuase of it,The language changed won't be properly called in the widget tree. Now it fixed it.
2014-01-23elementary - send signal "language,changed" with one way in the widget.ChunEon Park
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call. This makes reducing duplicated code and supporting language,chagned from all widgets.
2014-01-23elementary - use the focused/unfocused string in widget defined.ChunEon Park
Now, it will share the strings so that reduce the binary size also user uses it in one way.
2014-01-22fix some typos in comment and descriptionJihoon Kim