path: root/src/lib/elm_toolbar.c (follow)
AgeCommit message (Collapse)Author
2016-03-11Revert "Automatic migration to the new eo_add syntax."Tom Hacohen
This reverts commit d1a1819813d74361b25fd5c1123f7ac76be9b84f.
2016-03-09Automatic migration to the new eo_add syntax.Tom Hacohen
2016-03-03Fix warnings following migration to Eo4.Tom Hacohen
Mostly unused variables.
2016-03-03Automatic migration to Eo4.Tom Hacohen
I just ran my script (email to follow) to migrate all of the EFL automatically. This commit is *only* the automatic conversion, so it can be easily reverted and re-run.
2016-01-30[toolbar] Adjust icon size along with text etc.Andy Williams
As discussed on the mailing list elm should scale the whole UI based on the scale value. Make toolbar icons match this. @fix
2016-01-29[toolbar] don't leak icons into the UIAndy Williams
This cleans up orphan icons being left in the UI if you call icon_set after the toolbar has been displayed. This was most noticable if the toolbar or buttons move first @fix
2016-01-04toolbar: Send a signal when shrink mode is changed.Youngbok Shin
Summary: It is useful for changing item's state according to shrink mode. @feature Test Plan: It includes a use case for the patch in toolbar default theme. Run "elementary_test -to toolbar2". Reviewers: jaehwan, woohyun, cedric, raster Subscribers: eagleeye Differential Revision: Notes: breaks toolbar layouts: before -> after
2015-12-21Elm config: use a name instead of elm_widget_type_getMarcel Hollerbach
Summary: The use of elm_widget_type_get here is pretty harmfull, for the usecase of inheriting a widget elm_widget_type_get is something else than before. But the key binding should still work. @fix T2891 Reviewers: tasn Reviewed By: tasn Maniphest Tasks: T2891 Differential Revision:
2015-12-17atspi: return previous name in overloaded gettersLukasz Stanislawski
Some overloaded accessible name getters did not respect values set by developer. @fix
2015-12-02atspi: always use widget's subobj as accessible childrenLukasz Stanislawski
Patch fixes issue when widgets could be orphaned in accessibility tree due to overloaded accessible_children_get methods in widgets returning Elm_Object_Items. Widgets like genlist, gengrid, list and toolbar returned only items as its accessibility children so if some widget was attached directly to those widgets (like ctxpopup/popup) it become orphaned in accessibility tree.
2015-11-09toolbar: reduce changing widget parent-child relationship when an item is added.Youngbok Shin
Summary: It is an legacy of old code. When the view object of item was edje, I think there was no meaningless parent-child relationship changes. But, now, the view object is elm_layout and if we add object in proper order, we don't need to make an useless parent-child realationship in any moments. Test Plan: None Reviewers: woohyun, cedric Reviewed By: cedric Differential Revision: Signed-off-by: Cedric BAIL <>
2015-11-09toolbar: add item_signal_emit.Shilpa Singh
Summary: Application cannot send signals to toolbar item using elm_object_item_signal_emit API. @feature Test Plan: Send signal to toolbar item from app using elm_object_item_signal_emit widget. Reviewers: cedric Reviewed By: cedric Subscribers: cedric Differential Revision: Signed-off-by: Cedric BAIL <>
2015-11-09toolbar: remove a legacy code.Youngbok Shin
Summary: The icon is already sub object of VIEW(item) by content_set. We don't need to make icon as a sub object of obj again. It was used when VIEW(item) is Edje object. Test Plan: None Reviewers: Hermet, eagleeye, cedric Reviewed By: cedric Differential Revision: Signed-off-by: Cedric BAIL <>
2015-11-05atspi: add missing SELECTED changed signalsLukasz Stanislawski
2015-10-19toolbar: limit number of min restricted calc to exacly what we need.Cedric BAIL
This change is the simplest I could do, but I think it would be better to move _item_theme_hook inside _item_new. This is a further attempt to fix T2777.
2015-10-19atspi: clean-up children-changed event emission.Lukasz Stanislawski
Patch fixes bugs caused by difference between elm widget and atspi objects hierarchy.
2015-10-15toolbar: shutup compiler warning.Cedric BAIL
2015-10-15toolbar: delay evaluation of the toolbar size until it stabilize.Cedric BAIL
Elementary is not using much the calculate callback from Evas. This create all sort of problem where it transform O(n) algorithm. Like sizing a toolbar for next frame to O(n^n) by actually sizing the toolbar every time an object is inserted. T2777
2015-10-15toolbar: remove useless call to _sizing_eval.Cedric BAIL
_sizing_eval is very costly on toolbar as it recalc all edje part and sends signal to all of them. _item_theme_hook was already calling _sizing_eval doubling the cost of adding new item.
2015-10-12toolbar: Fix crash on more_item when shrink mode is set with no item.Jaehyun Cho
Toolbar creates a more_item when shrink mode is ELM_TOOLBAR_SHRINK_EXPAND. If select mode is ELM_OBJECT_SELECT_MODE_ALWAYS and there is no item appended, then toolbar sets a selection on a newly created item. In this case, sd->more_item is referenced before the new more_item is assigned to sd->more_item. @fix
2015-10-02atspi: properly set parent.Lukasz Stanislawski
Set proper atspi parents in cases when AT-SPI object tree structure should be different then elementary tree (mostly in cases of elm_widget_items) Add regression tests for those cases.
2015-09-23elm_toolbar: fix elm_toolbar_select_mode_set APIHosang Kim
Summary: Item is unselected when I changed select mode "ELM_OBJECT_SELECT_MODE_DEFAULT" to "ELM_OBJECT_SELECT_MODE_ALWAYS". Reviewers: Hermet, cedric, raster, seoz, woohyun Reviewed By: woohyun Differential Revision:
2015-09-15focus: add the APIs to set the focus next about item.Jaehwan Kim
Add elm_object_focus_next_item_set/get, elm_object_item_focus_next_object_set/get and elm_object_item_focus_next_item_set/get. If the item and object is set at the same time, the item is preference to object when the focus moves. This feature is implemented about gengrid. It will be implemented about ohter widgets. @feature
2015-09-12elm toolbar 0 size items fix if icon not foundCarsten Haitzler (Rasterman)
this fixes a bug with horizontal style toolbar items and toolbar code itself simply emitting the wrong signals that causes 0 height items. this fixes T2710 @fix
2015-09-10elm autofocus show - fix cases where focus is inside containersCarsten Haitzler (Rasterman)
i found that the focus doesnt auto-show when focusing things inside scrollers and so on. i had to add more points to trigger auto show. this fixes that @fix
2015-08-26toolbar: fix issue of focus not coming to item on mouse clickAmitesh Singh
resize object was not getting focused in case of mouse click. Steps to reproduce: 1. elementary_test -to "toolbar focus". 2. set focus to toolbar item via mouse. 3. focus does not come to toolbar. fixes T2697 @fix
2015-08-07elm_toolbar: fix icon_size to consider edje base scaleSung-Taek Hong
Summary: When icon is set, icon size is calculated without considering edje base scale. This can lead to a miscalculation when base scale is set other than 1.0. @fix Reviewers: seoz, woohyun, cedric, Hermet Reviewed By: Hermet Subscribers: cedric Differential Revision:
2015-07-16toolbar: item content unset function called when user content unset to ↵woochan lee
toolbar item. Summary: It's related with I missed doing on content_unset case. Reviewers: Hermet Reviewed By: Hermet Differential Revision:
2015-07-10toolbar: Check return value of elm_layout_theme_set.Amitesh Singh
2015-07-02toolbar: content_set function called when user content set to toolbar item.woochan lee
Summary: If User want to content set something to item area. there is no way to except elm customizing. So i added this feature and make the toolbar item object to layout before. Now user can content set something on item area only call "elm_object_item_part_content_set" API. Test Plan: Make some swallow part on toolbar edc. and content set some layout to that swallow part to using "elm_object_item_part_content_set" Reviewers: cedric, Hermet Subscribers: SanghyeonLee, eagleeye, id213sin Differential Revision:
2015-07-02toolbar: item object change from edje object to layout.woochan lee
Summary: Its for support elm_object_item_XXXX APIs for toolbar item. Its the pre work for toolbar item content set some layout to toolbar item layout automatically. (without implement item_content_set with part name.) I abandoned for check the other side of this change. but its not has problem so i reclaim this commit and put on another commit for this. Test Plan: To all of the action on elementary toolbar test sample. Reviewers: cedric, Hermet Reviewed By: cedric Differential Revision:
2015-07-02elm_toolbar: porting evas smart callbacks to eoAvi Levin
2015-06-25elm: constify Eolian methods correctly because of recent Eolian changesDaniel Kolesa
2015-05-26toolbar: implement Atspi_Selection interfaceLukasz Stanislawski
Allow to select and deselect toolbar items by Assistive Technology Clients through org.a11y.atspi.Selection dbus interface.
2015-05-20Adjust usage of eo_constructor() according to recent changes.Tom Hacohen
2015-04-27elm_toolbar: fix memory leaksAndrii Kroitor
Summary: incorrect evas_object_box_children_get usage: returned list must be freed @fix Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet Differential Revision:
2015-04-21elm: add safety checkJaeun Choi
when insert a new item before/after an item, the relative item should not be NULL. this patch fixes naviframe, gengrid, genlist, list, and toolbar. @fix
2015-04-14toolbar: fix conditional compiler warning in horizontal_setMike Blumenkrantz
2015-04-06atspi: add AT-SPI support for elm_toolbar_itemsLukasz Stanislawski
2015-03-25elm_toolbar: add toolbar item size calculation and setting min values for ↵taehyub
fixed items Summary: In case of the toolbar item size is fixed, the size of toolbar item became finger size. so, after signal emission in _inform_item_number(), edje_object_size_min_restricted_calc() and evas_object_size_hint_min_set() function are added. Test Plan: change edc for supporting fixed toolbar item and run examples of toolbar in elementary_test Reviewers: woohyun, seoz, Hermet, raster Reviewed By: raster Differential Revision:
2015-03-21toolbar: remove useless codesWooHyun Jung
2015-03-19Elm_toolbar: Sizing evaluation improvement.Subodh Kumar
Summary: Issue: Flickering when toolbar was set/unset Solution: Unnecessary resizes and show caused the flicker, removed unnecessary resizes. Reviewers: seoz, raster, shilpasingh Reviewed By: shilpasingh Subscribers: poornima.srinivasan, rajeshps, govi Differential Revision:
2015-02-23Fix code to conform to recent Eo changes.Tom Hacohen
2015-02-23elm: Remove redundant finger size adjustment.Daniel Juyung Seo
This is a successor of a54da8aab.
2015-02-11elm_toolbar: remove code duplicationJee-Yong Um
Summary: elm_coords_finger_size_adjust() is called twice. It might not be intended. Reviewers: Hermet, Jaehyun, seoz Reviewed By: seoz Subscribers: raster, seoz, Hermet Differential Revision:
2015-02-03list/genlist/gengrid/toolbar: set focus/unfocus on item when focus is ↵Amitesh Singh
actually set on widget. Summary: @Fix Reviewers: raster, Hermet, seoz Reviewed By: seoz Subscribers: seoz Differential Revision:
2014-12-26gengrid, genlist, list, toolbar: Fix memory leak and enhance performance.Daniel Juyung Seo
1. Fix memory leak by freeing eina_list. 2. Enhance performance by getting the item list when it is really needed. @fix
2014-12-26elm_toolbar: fix memory leak in _elm_toolbar_nearest_visible_item_getAndrii Kroitor
@fix Reviewers: cedric, seoz, Hermet, raster Subscribers: reutskiy.v.v Differential Revision:
2014-11-13elm_box: inappropriate size_hint_align value usage fixAndrii Kroitor
Summary: size_hint_align was used instead of evas_box's internal value for aligning of internal items. Because of that layout functions of elm_box and evas_box were incompatable Fixed elm_box, els_box layout and widgets that used this behaviour. @fix Test Plan: Run "elementary_test". All buttons should be left-aligned "elm_box_align_set(tbx2, 0.0, 0.5);" (test.c:332) Reviewers: cedric, Hermet, stefan_schmidt, seoz Reviewed By: seoz Subscribers: shilpasingh, reutskiy.v.v Differential Revision:
2014-11-12Object Items: replace most of del_pre functions with destructor.Daniel Zaoui
This change is not simple because Elementary has not been built from the first day to work with Eo. Code had to be adapted to fit the new design. The del_pre that have not been replaced yet can return FALSE and prevent deletion. For these classes, code modification has to be deeper and will be done later.