aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChidambar Zinnoury <illogict@online.fr>2013-02-02 13:16:56 +0000
committerChidambar Zinnoury <illogict@online.fr>2013-02-02 13:16:56 +0000
commit965ab8081966f9cdc2756cef5b9df1a02a0f96a4 (patch)
tree6643c8a7801b70448500a209f517921d310b1d57
parentsave bindings config immediately after transferring to ensure it doesn't get ... (diff)
downloadenlightenment-965ab8081966f9cdc2756cef5b9df1a02a0f96a4.tar.gz
e music-control: add check-changed.
Bonus: some unused lovin’. SVN revision: 83573
-rw-r--r--ChangeLog4
-rw-r--r--NEWS3
-rw-r--r--src/modules/music-control/ui.c19
3 files changed, 20 insertions, 6 deletions
diff --git a/ChangeLog b/ChangeLog
index 8930b8b0d..32cb0c564 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2013-02-02 Chidambar Zinnoury (ilLogict)
+
+ * Music-control settings: add check changed.
+
2013-02-01 Mike Blumenkrantz
* split out binding configs into separate config domain
diff --git a/NEWS b/NEWS
index e9c93aa67..c18b14d66 100644
--- a/NEWS
+++ b/NEWS
@@ -53,7 +53,8 @@ Improvements:
- startup theme,
- desktop environments,
- language,
- - notification.
+ - notification,
+ - music-control.
* Improve UI of desk settings.
* Add icons for gadcon settings.
* Improve strings of pager settings.
diff --git a/src/modules/music-control/ui.c b/src/modules/music-control/ui.c
index b32e96bcd..8b1f04402 100644
--- a/src/modules/music-control/ui.c
+++ b/src/modules/music-control/ui.c
@@ -29,7 +29,7 @@ music_control_state_update_all(E_Music_Control_Module_Context *ctxt)
}
static void
-_btn_clicked(void *data, Evas_Object *obj, const char *emission, const char *source)
+_btn_clicked(void *data, Evas_Object *obj __UNUSED__, const char *emission __UNUSED__, const char *source)
{
E_Music_Control_Instance *inst = data;
if (!strcmp(source, "play"))
@@ -41,7 +41,7 @@ _btn_clicked(void *data, Evas_Object *obj, const char *emission, const char *sou
}
static void
-_label_clicked(void *data, Evas_Object *obj, const char *emission, const char *source)
+_label_clicked(void *data, Evas_Object *obj __UNUSED__, const char *emission __UNUSED__, const char *source __UNUSED__)
{
E_Music_Control_Instance *inst = data;
music_control_popup_del(inst);
@@ -182,12 +182,20 @@ _cfg_data_create(E_Config_Dialog *cfd)
}
static void
-_cfg_data_free(E_Config_Dialog *cfd, E_Config_Dialog_Data *cfdata)
+_cfg_data_free(E_Config_Dialog *cfd __UNUSED__, E_Config_Dialog_Data *cfdata)
{
free(cfdata);
}
static int
+_cfg_check_changed(E_Config_Dialog *cfd, E_Config_Dialog_Data *cfdata)
+{
+ E_Music_Control_Instance *inst = cfd->data;
+
+ return inst->ctxt->config->player_selected != cfdata->index;
+}
+
+static int
_cfg_data_apply(E_Config_Dialog *cfd, E_Config_Dialog_Data *cfdata)
{
E_Music_Control_Instance *inst = cfd->data;
@@ -204,7 +212,7 @@ _cfg_data_apply(E_Config_Dialog *cfd, E_Config_Dialog_Data *cfdata)
}
static void
-_cb_menu_cfg(void *data, E_Menu *m, E_Menu_Item *mi)
+_cb_menu_cfg(void *data, E_Menu *m, E_Menu_Item *mi __UNUSED__)
{
E_Config_Dialog_View *v;
@@ -213,6 +221,7 @@ _cb_menu_cfg(void *data, E_Menu *m, E_Menu_Item *mi)
v->free_cfdata = _cfg_data_free;
v->basic.create_widgets = _cfg_widgets_create;
v->basic.apply_cfdata = _cfg_data_apply;
+ v->basic.check_changed = _cfg_check_changed;
e_config_dialog_new(m->zone->container, "Music control Settings", "E",
"_e_mod_music_config_dialog",
@@ -220,7 +229,7 @@ _cb_menu_cfg(void *data, E_Menu *m, E_Menu_Item *mi)
}
void
-music_control_mouse_down_cb(void *data, Evas *evas, Evas_Object *obj, void *event)
+music_control_mouse_down_cb(void *data, Evas *evas __UNUSED__, Evas_Object *obj __UNUSED__, void *event)
{
E_Music_Control_Instance *inst = data;
Evas_Event_Mouse_Down *ev = event;