summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcel Hollerbach <marcel-hollerbach@t-online.de>2016-01-16 12:09:00 +0100
committerMike Blumenkrantz <zmike@osg.samsung.com>2016-01-18 15:43:33 -0500
commitd093fc8e337c7be9ecd09e53fd4eb115dce97080 (patch)
treebb49167d0f45e5e71cac5639bce6acf7bae66c8b
parentb8a5f960b9fa6bfb21edb9a1449375fd01a097b5 (diff)
e_grabinput: do not pass a faulty time
Summary: currently there is ecore_x_current_time passed, which is the time of the last event. if this is passed to ecore_x_window_focus_at_time the request can be ignored because the last event can be in the past. Instead using ecore_x_window_focus fixes this, because current time is passed, which means that x is just using this event at the time it is called. @fix T2948 Test Plan: Try to run spotify and try to trigger the bug, I cannot anymore. Reviewers: zmike, raster Subscribers: raster, abyomi0, cedric, billiob Maniphest Tasks: T2948 Differential Revision: https://phab.enlightenment.org/D3471
-rw-r--r--src/bin/e_grabinput.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/bin/e_grabinput.c b/src/bin/e_grabinput.c
index a67d39f36..c050a0825 100644
--- a/src/bin/e_grabinput.c
+++ b/src/bin/e_grabinput.c
@@ -173,7 +173,7 @@ _e_grabinput_focus_do(Ecore_Window win, E_Focus_Method method)
173#ifndef HAVE_WAYLAND_ONLY 173#ifndef HAVE_WAYLAND_ONLY
174 if (e_comp_util_has_x()) 174 if (e_comp_util_has_x())
175 { 175 {
176 ecore_x_window_focus_at_time(win, ecore_x_current_time_get()); 176 ecore_x_window_focus(win);
177 ecore_x_icccm_take_focus_send(win, ecore_x_current_time_get()); 177 ecore_x_icccm_take_focus_send(win, ecore_x_current_time_get());
178 } 178 }
179#endif 179#endif
@@ -189,7 +189,7 @@ _e_grabinput_focus_do(Ecore_Window win, E_Focus_Method method)
189 case E_FOCUS_METHOD_PASSIVE: 189 case E_FOCUS_METHOD_PASSIVE:
190#ifndef HAVE_WAYLAND_ONLY 190#ifndef HAVE_WAYLAND_ONLY
191 if (e_comp_util_has_x()) 191 if (e_comp_util_has_x())
192 ecore_x_window_focus_at_time(win, ecore_x_current_time_get()); 192 ecore_x_window_focus(win);
193#endif 193#endif
194 break; 194 break;
195 195