summaryrefslogtreecommitdiff
path: root/src/modules
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2017-09-23 23:08:37 +0900
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2017-09-23 23:10:35 +0900
commitb9d166f804718ae14e5158496baeab5e29864f82 (patch)
tree617857c9fe462cda80dd247b99a9369e8eb53b0a /src/modules
parent40e8bb044c049d7a3a16f61aebef6ea6977509ce (diff)
use safer ecore_exe flags that close stdin/out/err if possible
this is specifically needed for wayland but is relevant to x with startx too ... dont let processes that e runs like apps inherit stdin/out/err as it may be a tty and thus allow apps to do nasty things with that tty. @fix
Diffstat (limited to 'src/modules')
-rw-r--r--src/modules/conf_intl/e_int_config_imc.c4
-rw-r--r--src/modules/mixer/e_mod_main.c2
-rw-r--r--src/modules/mixer/gadget/mixer.c2
3 files changed, 4 insertions, 4 deletions
diff --git a/src/modules/conf_intl/e_int_config_imc.c b/src/modules/conf_intl/e_int_config_imc.c
index f66d5f2..64aa15a 100644
--- a/src/modules/conf_intl/e_int_config_imc.c
+++ b/src/modules/conf_intl/e_int_config_imc.c
@@ -264,7 +264,7 @@ _e_imc_setup_cb(void *data, void *data2 EINA_UNUSED)
264 264
265 cmd = imc->e_im_setup_exec; 265 cmd = imc->e_im_setup_exec;
266 266
267 exe = ecore_exe_run(cmd, NULL); 267 exe = e_util_exe_safe_run(cmd, NULL);
268 268
269 if (!exe) 269 if (!exe)
270 { 270 {
@@ -518,7 +518,7 @@ _e_imc_adv_setup_cb(void *data, void *data2 EINA_UNUSED)
518 518
519 cmd = cfdata->imc.e_im_setup_exec; 519 cmd = cfdata->imc.e_im_setup_exec;
520 520
521 exe = ecore_exe_run(cmd, NULL); 521 exe = e_util_exe_safe_run(cmd, NULL);
522 522
523 if (!exe) 523 if (!exe)
524 { 524 {
diff --git a/src/modules/mixer/e_mod_main.c b/src/modules/mixer/e_mod_main.c
index f973637..d2ae88b 100644
--- a/src/modules/mixer/e_mod_main.c
+++ b/src/modules/mixer/e_mod_main.c
@@ -445,7 +445,7 @@ _emixer_exec_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info EINA_
445 _popup_del(inst); 445 _popup_del(inst);
446 if (mixer_context->emixer) return; 446 if (mixer_context->emixer) return;
447 447
448 mixer_context->emixer = ecore_exe_run("emixer", NULL); 448 mixer_context->emixer = e_util_exe_safe_run("emixer", NULL);
449 if (mixer_context->emix_event_handler) 449 if (mixer_context->emix_event_handler)
450 ecore_event_handler_del(mixer_context->emix_event_handler); 450 ecore_event_handler_del(mixer_context->emix_event_handler);
451 mixer_context->emix_event_handler = 451 mixer_context->emix_event_handler =
diff --git a/src/modules/mixer/gadget/mixer.c b/src/modules/mixer/gadget/mixer.c
index 0eb6401..94af5a0 100644
--- a/src/modules/mixer/gadget/mixer.c
+++ b/src/modules/mixer/gadget/mixer.c
@@ -383,7 +383,7 @@ _emixer_exec_cb(void *data, Evas_Object *obj EINA_UNUSED, void *event_info EINA_
383 elm_ctxpopup_dismiss(inst->popup); 383 elm_ctxpopup_dismiss(inst->popup);
384 if (gmixer_context->emixer) return; 384 if (gmixer_context->emixer) return;
385 385
386 gmixer_context->emixer = ecore_exe_run("emixer", NULL); 386 gmixer_context->emixer = e_util_exe_safe_run("emixer", NULL);
387 if (gmixer_context->emix_event_handler) 387 if (gmixer_context->emix_event_handler)
388 ecore_event_handler_del(gmixer_context->emix_event_handler); 388 ecore_event_handler_del(gmixer_context->emix_event_handler);
389 gmixer_context->emix_event_handler = 389 gmixer_context->emix_event_handler =