summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>2020-05-30 21:56:08 +0100
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>2020-05-30 21:56:29 +0100
commit7062c0fa4c7351a000259dbd6b1b01627881d7bd (patch)
treed29f1f4124b0584d1bf61989c8c0365ca0dc5518 /src
parent3fdd7d31185e2539579da6cc430d3c530907b40d (diff)
efm - make some comment notes for exec verify
Diffstat (limited to 'src')
-rw-r--r--src/modules/fileman/e_fwin.c5
-rw-r--r--src/modules/fileman/e_mod_dbus.c4
2 files changed, 8 insertions, 1 deletions
diff --git a/src/modules/fileman/e_fwin.c b/src/modules/fileman/e_fwin.c
index 4c79264cf..1bdd3e4b3 100644
--- a/src/modules/fileman/e_fwin.c
+++ b/src/modules/fileman/e_fwin.c
@@ -1521,6 +1521,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
1521 1521
1522 case E_FWIN_EXEC_DIRECT: 1522 case E_FWIN_EXEC_DIRECT:
1523 snprintf(buf, sizeof(buf), "%s/%s", e_fm2_real_path_get(fwin->cur_page->fm_obj), ici->file); 1523 snprintf(buf, sizeof(buf), "%s/%s", e_fm2_real_path_get(fwin->cur_page->fm_obj), ici->file);
1524 // XXX: exec verify buf
1524 if (fwin->win) 1525 if (fwin->win)
1525 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin"); 1526 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
1526 else if (fwin->zone) 1527 else if (fwin->zone)
@@ -1529,6 +1530,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
1529 1530
1530 case E_FWIN_EXEC_SH: 1531 case E_FWIN_EXEC_SH:
1531 snprintf(buf, sizeof(buf), "/bin/sh %s", e_util_filename_escape(ici->file)); 1532 snprintf(buf, sizeof(buf), "/bin/sh %s", e_util_filename_escape(ici->file));
1533 // XXX: exec verify buf
1532 if (fwin->win) 1534 if (fwin->win)
1533 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin"); 1535 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
1534 else if (fwin->zone) 1536 else if (fwin->zone)
@@ -1537,6 +1539,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
1537 1539
1538 case E_FWIN_EXEC_TERMINAL_DIRECT: 1540 case E_FWIN_EXEC_TERMINAL_DIRECT:
1539 snprintf(buf, sizeof(buf), "%s %s", e_config->exebuf_term_cmd, e_util_filename_escape(ici->file)); 1541 snprintf(buf, sizeof(buf), "%s %s", e_config->exebuf_term_cmd, e_util_filename_escape(ici->file));
1542 // XXX: exec verify buf
1540 if (fwin->win) 1543 if (fwin->win)
1541 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin"); 1544 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
1542 else if (fwin->zone) 1545 else if (fwin->zone)
@@ -1545,6 +1548,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
1545 1548
1546 case E_FWIN_EXEC_TERMINAL_SH: 1549 case E_FWIN_EXEC_TERMINAL_SH:
1547 snprintf(buf, sizeof(buf), "%s /bin/sh %s", e_config->exebuf_term_cmd, e_util_filename_escape(ici->file)); 1550 snprintf(buf, sizeof(buf), "%s /bin/sh %s", e_config->exebuf_term_cmd, e_util_filename_escape(ici->file));
1551 // XXX: exec verify buf
1548 if (fwin->win) 1552 if (fwin->win)
1549 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin"); 1553 e_exec(e_comp_object_util_zone_get(fwin->win), NULL, buf, NULL, "fwin");
1550 else if (fwin->zone) 1554 else if (fwin->zone)
@@ -1553,6 +1557,7 @@ _e_fwin_file_exec(E_Fwin_Page *page,
1553 1557
1554 case E_FWIN_EXEC_DESKTOP: 1558 case E_FWIN_EXEC_DESKTOP:
1555 snprintf(buf, sizeof(buf), "%s/%s", e_fm2_real_path_get(page->fm_obj), ici->file); 1559 snprintf(buf, sizeof(buf), "%s/%s", e_fm2_real_path_get(page->fm_obj), ici->file);
1560 // XXX: exec verify buf
1556 desktop = efreet_desktop_new(buf); 1561 desktop = efreet_desktop_new(buf);
1557 if (desktop) 1562 if (desktop)
1558 { 1563 {
diff --git a/src/modules/fileman/e_mod_dbus.c b/src/modules/fileman/e_mod_dbus.c
index 2df0fc785..c571bef20 100644
--- a/src/modules/fileman/e_mod_dbus.c
+++ b/src/modules/fileman/e_mod_dbus.c
@@ -244,7 +244,7 @@ _e_fileman_dbus_daemon_open_file_cb(const Eldbus_Service_Interface *iface EINA_U
244 errmsg = "couldn't open desktop file"; 244 errmsg = "couldn't open desktop file";
245 goto error; 245 goto error;
246 } 246 }
247 247 // XXX: exec verify real_file
248 e_exec(zone, desktop, NULL, NULL, NULL); 248 e_exec(zone, desktop, NULL, NULL, NULL);
249 efreet_desktop_free(desktop); 249 efreet_desktop_free(desktop);
250 goto end; 250 goto end;
@@ -252,11 +252,13 @@ _e_fileman_dbus_daemon_open_file_cb(const Eldbus_Service_Interface *iface EINA_U
252 else if ((strcmp(mime, "application/x-executable") == 0) || 252 else if ((strcmp(mime, "application/x-executable") == 0) ||
253 ecore_file_can_exec(param_file)) 253 ecore_file_can_exec(param_file))
254 { 254 {
255 // XXX: exec verify param_file
255 e_exec(zone, NULL, param_file, NULL, NULL); 256 e_exec(zone, NULL, param_file, NULL, NULL);
256 goto end; 257 goto end;
257 } 258 }
258 else if (_mime_shell_script_check(mime)) 259 else if (_mime_shell_script_check(mime))
259 { 260 {
261 // XXX: exec verify param_file
260 Eina_Strbuf *b = eina_strbuf_new(); 262 Eina_Strbuf *b = eina_strbuf_new();
261 const char *shell = getenv("SHELL"); 263 const char *shell = getenv("SHELL");
262 if (!shell) 264 if (!shell)