From 0b26b1bd8950b0e385a2f96c3a123d0dee1b67b4 Mon Sep 17 00:00:00 2001 From: Sebastian Dransfeld Date: Wed, 16 Oct 2013 04:56:51 +0200 Subject: [PATCH] eina: And guard the right function with umask Thanks Cedric. --- src/lib/eina/eina_file_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/lib/eina/eina_file_common.c b/src/lib/eina/eina_file_common.c index 9a222c2b47..3a68345c6e 100644 --- a/src/lib/eina/eina_file_common.c +++ b/src/lib/eina/eina_file_common.c @@ -878,15 +878,16 @@ eina_file_mkstemp(const char *templatename, Eina_Tmpstr **path) tmpdir = (char *)evil_tmpdir_get(); #endif /* ! HAVE_EVIL */ + snprintf(buffer, PATH_MAX, "%s/%s", tmpdir, templatename); + /* * Make sure temp file is created with secure permissions, * http://man7.org/linux/man-pages/man3/mkstemp.3.html#NOTES */ old_umask = umask(0077); - snprintf(buffer, PATH_MAX, "%s/%s", tmpdir, templatename); + fd = mkstemp(buffer); umask(old_umask); - fd = mkstemp(buffer); if (path) *path = eina_tmpstr_add(buffer); if (fd < 0) return -1;