dimmus
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eio: revert r75445 and add a comment to prevent it to happen again. 

Yes, it's the second time someone "fix" that and get reverted. Actually
looking at svn log would have shown the issue as it was just the previous
commit.


SVN revision: 75482
This commit is contained in:
Cedric BAIL 2012-08-21 02:22:20 +00:00
parent 335912df94
commit 153afa9283
2 changed files with 12 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
legacy/eio/ChangeLog
View File

@ -17,3 +17,8 @@
2012-08-07 Cedric Bail
* Properly shutdown monitor when calling eio_shutdown.
2012-08-21 Cedric Bail
* Add a comment describing the false positiv detected by static analyzer
when calling eio_file_set.

27
legacy/eio/src/lib/eio_single.c
View File

@ -421,10 +421,9 @@ eio_file_direct_stat(const char *path,
_eio_file_stat,
_eio_file_stat_done,
_eio_file_stat_error))
{
free(s);
return NULL;
}
/* THERE IS NO MEMLEAK HERE, ECORE_THREAD CANCEL CALLBACK HAS BEEN ALREADY CALLED
AND s HAS BEEN FREED, SAME FOR ALL CALL TO EIO_FILE_SET ! */
return NULL;
return &s->common;
}
@ -485,10 +484,7 @@ eio_file_unlink(const char *path,
_eio_file_unlink,
_eio_file_unlink_done,
_eio_file_unlink_error))
{
free(l);
return NULL;
}
return NULL;
return &l->common;
}
@ -518,10 +514,7 @@ eio_file_mkdir(const char *path,
_eio_file_mkdir,
_eio_file_mkdir_done,
_eio_file_mkdir_error))
{
free(r);
return NULL;
}
return NULL;
return &r->common;
}
@ -551,10 +544,7 @@ eio_file_chmod(const char *path,
_eio_file_chmod,
_eio_file_mkdir_done,
_eio_file_mkdir_error))
{
free(r);
return NULL;
}
return NULL;
return &r->common;
}
@ -586,10 +576,7 @@ eio_file_chown(const char *path,
_eio_file_chown,
_eio_file_chown_done,
_eio_file_chown_error))
{
free(c);
return NULL;
}
return NULL;
return &c->common;
}