From 21ad5e011f6c4033924ef854b1837052c37c3ba7 Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Sat, 24 Dec 2022 18:40:00 +0000 Subject: [PATCH] elm config tool - fix string mis-use of stale string ptrs from efreet if efreet updates its in memory db of themes/icons etc. the ptrs you get from it will be invalid. always dup them out if you keep them around after going back to main loop control. in this case a tiny possible leak in stringshare won't ever matter... sot his fixes it @fix --- src/bin/elementary/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bin/elementary/config.c b/src/bin/elementary/config.c index 26e723d549..1a661c8b8e 100644 --- a/src/bin/elementary/config.c +++ b/src/bin/elementary/config.c @@ -2455,7 +2455,8 @@ _status_config_icons(Evas_Object *win, ic = elm_icon_add(li); elm_image_file_set(ic, efreet_icon_path_find(th->name.internal, "folder", 48), NULL); list_it = elm_list_item_append(li, th->name.name, ic, NULL, - _icon_theme_sel, th->name.internal); + _icon_theme_sel, + eina_stringshare_add(th->name.internal)); if (!strcmp(th->name.internal, "hicolor")) def_it = list_it;