From 299d0f410655ce711ea9411967b6c09d356f8f44 Mon Sep 17 00:00:00 2001 From: Daniel Juyung Seo Date: Wed, 7 Sep 2011 15:02:27 +0000 Subject: [PATCH] elm diskselector: Fixed elm_diskselector_item_selected_set() hanging bug. Patch by Hyoyoung Chang On Wed, Sep 7, 2011 at 6:51 PM, Hyoyoung Chang wrote: > Dear developers. > > This patch is fixing - hangs after using elm_diskselector_item_selected_set. > Elm_diskselector add a idler and remove in _move_scroller with checking > wd->idler > But in elm_diskselector_item_selected_set, it's not use wd->idler. > So idler is called infinite. > > It also registered in ticket ( http://trac.enlightenment.org/e/ticket/854 ) > > Thank you On Wed, Sep 7, 2011 at 7:00 PM, Hyoyoung Chang wrote: > I omitted about credit. > With cnook, I can easily find this bug. > Thanks to cnook SVN revision: 63269 --- legacy/elementary/src/lib/elm_diskselector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/legacy/elementary/src/lib/elm_diskselector.c b/legacy/elementary/src/lib/elm_diskselector.c index e467aeb5fc..66625f628f 100644 --- a/legacy/elementary/src/lib/elm_diskselector.c +++ b/legacy/elementary/src/lib/elm_diskselector.c @@ -1181,7 +1181,7 @@ elm_diskselector_item_selected_set(Elm_Diskselector_Item *it, Eina_Bool selected } if (!wd->idler) - ecore_idler_add(_move_scroller, it->base.widget); + wd->idler = ecore_idler_add(_move_scroller, it->base.widget); } EAPI Eina_Bool