From 2f1894d054bb2b340117169204f8a01ff7e5dd3e Mon Sep 17 00:00:00 2001 From: Cedric Bail Date: Wed, 16 Oct 2019 16:45:50 -0700 Subject: [PATCH] eina: only the type need to be NULL to assume EINA_VALUE_EMPTY. This avoid comparison with potentially uninitialized byte. Reviewed-by: Mike Blumenkrantz Differential Revision: https://phab.enlightenment.org/D10479 --- src/lib/eina/eina_value.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eina/eina_value.c b/src/lib/eina/eina_value.c index 63f45b9bbe..0596b70e9f 100644 --- a/src/lib/eina/eina_value.c +++ b/src/lib/eina/eina_value.c @@ -5664,7 +5664,7 @@ eina_value_copy(const Eina_Value *value, Eina_Value *copy) EINA_SAFETY_ON_NULL_RETURN_VAL(value, EINA_FALSE); - if (!memcmp(value, &_eina_value_empty, sizeof (Eina_Value))) + if (value->type == NULL) { memcpy(copy, &_eina_value_empty, sizeof (Eina_Value)); return EINA_TRUE;