dimmus
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eldbus_fake_server: Fix unchecked return value 

Small patch to check return values of
eldbus_message_iter_arguments_get reported by Coverity.

Fixes CID1401042
This commit is contained in:
Christopher Michael 2021-02-25 09:18:46 -05:00
parent 598b7a1be6
commit 3a07f18294
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/tests/eldbus/eldbus_fake_server.c
View File

@ -153,12 +153,20 @@ _fake_server_property_set(const Eldbus_Service_Interface *iface,
ck_assert_ptr_ne(NULL, data);
if (strcmp(propname, FAKE_SERVER_WRITEONLY_PROPERTY) == 0)
eldbus_message_iter_arguments_get(iter, "i", &data->writeonly_property);
{
if (!eldbus_message_iter_arguments_get(iter, "i", &data->writeonly_property))
ck_abort_msg("error getting iter arguments on _fake_server_property_set");
}
else
if (strcmp(propname, FAKE_SERVER_READWRITE_PROPERTY) == 0)
eldbus_message_iter_arguments_get(iter, "i", &data->readwrite_property);
else
return eldbus_message_error_new(msg, "Invalid property", "Invalid property.");
{
if (strcmp(propname, FAKE_SERVER_READWRITE_PROPERTY) == 0)
{
if (!eldbus_message_iter_arguments_get(iter, "i", &data->readwrite_property))
ck_abort_msg("error getting iter arguments on _fake_server_property_set");
}
else
return eldbus_message_error_new(msg, "Invalid property", "Invalid property.");
}
return eldbus_message_method_return_new(msg);
}