From 3d9b2f66665783d653b2124aee749a9af767579c Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Tue, 24 Sep 2019 16:59:56 -0400 Subject: [PATCH] efl_ui/alert_popup: rename show/hide signals to visible,on/off Summary: this is consistent with the efl api ref T8231 Depends on D10081 Reviewers: segfaultxavi, cedric Reviewed By: cedric Subscribers: segfaultxavi, cedric, #reviewers, #committers Tags: #efl Maniphest Tasks: T8231 Differential Revision: https://phab.enlightenment.org/D10095 --- data/elementary/themes/edc/efl/popup.edc | 10 ++++++++-- src/lib/elementary/efl_ui_alert_popup.c | 6 +++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/data/elementary/themes/edc/efl/popup.edc b/data/elementary/themes/edc/efl/popup.edc index 22f1a94507..462fe29365 100644 --- a/data/elementary/themes/edc/efl/popup.edc +++ b/data/elementary/themes/edc/efl/popup.edc @@ -106,13 +106,19 @@ group { "efl/alert_popup"; data.item: "version" "123"; } programs { program { - signal: "efl,title,show"; source: "efl"; + signal: "efl,title,visible,on"; source: "efl"; action: STATE_SET "title_visible" 0.0; target: "title_bg"; target: "efl.text.title"; } program { - signal: "efl,buttons,show"; source: "efl"; + signal: "efl,title,visible,off"; source: "efl"; + action: STATE_SET "default" 0.0; + target: "title_bg"; + target: "efl.text.title"; + } + program { + signal: "efl,buttons,visible,on"; source: "efl"; action: STATE_SET "button_visible" 0.0; target: "efl.buttons"; } diff --git a/src/lib/elementary/efl_ui_alert_popup.c b/src/lib/elementary/efl_ui_alert_popup.c index 9acc174c3a..0c5fc1bbd9 100644 --- a/src/lib/elementary/efl_ui_alert_popup.c +++ b/src/lib/elementary/efl_ui_alert_popup.c @@ -44,9 +44,9 @@ _efl_ui_alert_popup_text_set(Eo *obj, Efl_Ui_Alert_Popup_Data *pd, const char *p { efl_text_set(efl_part(efl_super(obj, MY_CLASS), part), label); if (label) - elm_layout_signal_emit(obj, "efl,title,show", "efl"); + elm_layout_signal_emit(obj, "efl,title,visible,on", "efl"); else - elm_layout_signal_emit(obj, "efl,title,hide", "efl"); + elm_layout_signal_emit(obj, "efl,title,visible,off", "efl"); ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd, EINA_FALSE); edje_object_message_signal_process(wd->resize_obj); @@ -225,7 +225,7 @@ _efl_ui_alert_popup_button_set(Eo *obj, Efl_Ui_Alert_Popup_Data *pd, Efl_Ui_Aler pd->button[EFL_UI_ALERT_POPUP_BUTTON_NEGATIVE]); } - elm_layout_signal_emit(obj, "efl,buttons,show", "efl"); + elm_layout_signal_emit(obj, "efl,buttons,visible,on", "efl"); edje_object_message_signal_process(wd->resize_obj); }