forked from enlightenment/efl
evas-gl-3d: Fix compiler warning about 'ld' may be used uninitialized
Summary: This commit fixes compiler warning: modules/evas/engines/gl_common/evas_gl_3d.c:1322:48: warning: 'ld' may be used uninitialized in this function [-Wmaybe-uninitialized]. We declare 'ld' as NULL now, and check it is valid before using it. @fix Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
parent
cc4921a873
commit
40247decd3
|
@ -1283,7 +1283,7 @@ e3d_drawable_scene_render(E3D_Drawable *drawable, E3D_Renderer *renderer, Evas_3
|
||||||
const Evas_Mat4 *matrix_eye;
|
const Evas_Mat4 *matrix_eye;
|
||||||
Evas_3D_Node *light;
|
Evas_3D_Node *light;
|
||||||
Evas_Mat4 matrix_light_eye;
|
Evas_Mat4 matrix_light_eye;
|
||||||
Evas_3D_Light_Data *ld;
|
Evas_3D_Light_Data *ld = NULL;
|
||||||
Evas_3D_Node_Data *pd_light_node;
|
Evas_3D_Node_Data *pd_light_node;
|
||||||
|
|
||||||
/* Get eye matrix. */
|
/* Get eye matrix. */
|
||||||
|
@ -1319,8 +1319,9 @@ e3d_drawable_scene_render(E3D_Drawable *drawable, E3D_Renderer *renderer, Evas_3
|
||||||
{
|
{
|
||||||
evas_mat4_multiply(&matrix_mv, &matrix_light_eye,
|
evas_mat4_multiply(&matrix_mv, &matrix_light_eye,
|
||||||
&pd_mesh_node->data.mesh.matrix_local_to_world);
|
&pd_mesh_node->data.mesh.matrix_local_to_world);
|
||||||
evas_mat4_multiply(&matrix_light, &ld->projection,
|
if (ld)
|
||||||
&matrix_mv);
|
evas_mat4_multiply(&matrix_light, &ld->projection,
|
||||||
|
&matrix_mv);
|
||||||
}
|
}
|
||||||
|
|
||||||
evas_mat4_multiply(&matrix_mv, matrix_eye, &pd_mesh_node->data.mesh.matrix_local_to_world);
|
evas_mat4_multiply(&matrix_mv, matrix_eye, &pd_mesh_node->data.mesh.matrix_local_to_world);
|
||||||
|
|
Loading…
Reference in New Issue