dimmus
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix bugs spotted by clang static analyser. 

We had some problems with preload and after running LLVM's CLang
Static Analyser we found out that current->target could be NULL after
loop.

Also fixed some GCC and CLang warnings, kudos to these wonderful tools
that "Saved The Day".

PS: we should put some CLang Static Analyser results so others can
help fix other parts of E.



SVN revision: 38293
This commit is contained in:
Gustavo Sverzut Barbieri 2008-12-23 18:14:16 +00:00
parent fb238897e5
commit 586979c07b
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
legacy/evas/src/lib/cache/evas_cache_image.c vendored
View File

@ -870,6 +870,7 @@ evas_cache_image_load_data(Image_Entry *im)
assert(im);
assert(im->cache);
cache = im->cache;
if (im->flags.loaded) return ;
@ -879,8 +880,6 @@ evas_cache_image_load_data(Image_Entry *im)
if (im->flags.loaded) return ;
#endif
cache = im->cache;
error = cache->func.load(im);
if (cache->func.debug)
@ -908,7 +907,8 @@ evas_cache_image_preload_data(Image_Entry *im, const void *target)
if (im->flags.loaded)
{
evas_async_events_put(target, EVAS_CALLBACK_IMAGE_PRELOADED, NULL, evas_object_event_callback_call);
evas_async_events_put(target, EVAS_CALLBACK_IMAGE_PRELOADED, NULL,
(void (*)(void*, Evas_Callback_Type, void*))evas_object_event_callback_call);
return ;
}
@ -930,6 +930,7 @@ evas_cache_image_preload_cancel(Image_Entry *im)
assert(im);
assert(im->cache);
cache = im->cache;
_evas_cache_image_entry_preload_remove(cache, im);
#else
@ -1023,7 +1024,7 @@ evas_cache_private_set(Evas_Cache_Image *cache, const void *data)
{
assert(cache);
cache->data = data;
cache->data = (void *)data;
}
EAPI DATA32 *
@ -1078,11 +1079,13 @@ _evas_cache_background_load(void *data)
}
current->flags.preload = 0;
evas_async_events_put(current->target, EVAS_CALLBACK_IMAGE_PRELOADED, NULL,
(void (*)(void*, Evas_Callback_Type, void*))evas_object_event_callback_call);
current = NULL;
}
evas_async_events_put(current->target, EVAS_CALLBACK_IMAGE_PRELOADED, NULL, evas_object_event_callback_call);
current = NULL;
pthread_cond_signal(&cond);
}