From 6256978b61ca1ecf0bcc29ead3729c8c6484421e Mon Sep 17 00:00:00 2001 From: "Carsten Haitzler (Rasterman)" Date: Sat, 27 Aug 2016 09:06:49 +0900 Subject: [PATCH] fix filselector legacy cb call order and entry set - fix file,chosen The visible bug for this issue is that the Elm External Video example is broken: elementary_test -to "ExtVideo" The root cause is that the "file,choose" event of the FileselectorEntry is (wrongly) not listed by the function: evas_object_smart_callbacks_descriptions_get() This evas functions is used in elm_external to forward all the widget events to edje, but it cannot forward the "file,chosen" event because it's not listed. Thus the video test is not working for the lacks of that event. I think the fix should be somewhere in elc_fileselector_entry.c, there are some hacks there for the incriminated signal, but I don't know how to properly fix. as pointed out by dave: DaveMDS added a comment.Fri, Aug 26, 5:19 PM I think the problem is in this function: (elc_fileselector_entry.c) ... this fixes T4337 --- src/lib/elementary/elc_fileselector_entry.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/elc_fileselector_entry.c b/src/lib/elementary/elc_fileselector_entry.c index bb189792ba..c062ec341f 100644 --- a/src/lib/elementary/elc_fileselector_entry.c +++ b/src/lib/elementary/elc_fileselector_entry.c @@ -75,11 +75,11 @@ _file_chosen_path_then(void *data, void *v) if (!file) return; ELM_FILESELECTOR_ENTRY_DATA_GET(data, sd); - evas_object_smart_callback_call(data, "file,chosen", (void *) file); - s = elm_entry_utf8_to_markup(file); elm_object_text_set(sd->entry, s); free(s); + + evas_object_smart_callback_call(data, "file,chosen", (void *) file); } static void