dimmus
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elm/ctxpopup: check list existence before trying to delete list items 

this is kinda gross, but if the list is already deleted then the list
items are also gone and this is an invalid object access

@fix

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9402
This commit is contained in:
Mike Blumenkrantz 2019-07-25 10:38:12 -04:00 committed by Marcel Hollerbach
parent b1986363db
commit 62d4d4c5b8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/elementary/elc_ctxpopup.c
View File

@ -862,7 +862,9 @@ _elm_ctxpopup_item_elm_widget_item_del_pre(Eo *eo_ctxpopup_it EINA_UNUSED,
{
if (ctxpopup_it->list_item)
{
elm_object_item_del(ctxpopup_it->list_item);
Elm_Ctxpopup_Data *sd = efl_data_scope_safe_get(WIDGET(ctxpopup_it), MY_CLASS);
if (sd->list)
elm_object_item_del(ctxpopup_it->list_item);
ctxpopup_it->list_item = NULL;
}
}