From 669d95252a6a31660f43f075e743ecde316f7fb6 Mon Sep 17 00:00:00 2001 From: Minkyu Kang Date: Tue, 7 Feb 2017 15:00:35 -0800 Subject: [PATCH] elm_genlist: do not check scroll if show_item is NULL Summary: If show_item is NULL then does not need to check scroll. But, sometimes show_item is NULL but check_scroll is true. It was wrong and can makes a crash. Signed-off-by: Minkyu Kang Reviewers: cedric, Hermet, SanghyeonLee, raster Subscribers: jpeg Differential Revision: https://phab.enlightenment.org/D4569 Signed-off-by: Cedric BAIL --- src/lib/elementary/elm_genlist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_genlist.c index d880809d69..fe79a12c22 100644 --- a/src/lib/elementary/elm_genlist.c +++ b/src/lib/elementary/elm_genlist.c @@ -833,6 +833,7 @@ _calc_job(void *data) if (!sd->must_recalc_idler) sd->must_recalc_idler = ecore_idler_add(_must_recalc_idler, data); } + if (!sd->show_item) sd->check_scroll = EINA_FALSE; if (sd->check_scroll) { elm_obj_pan_content_size_get(sd->pan_obj, &pan_w, &pan_h);