dimmus
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

elm_test: fix crashing in efl.ui.popup when closing windows 

avoid double free on pointer in callback

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9540
This commit is contained in:
Mike Blumenkrantz 2019-08-09 09:16:45 -04:00 committed by Cedric BAIL
parent 189ddd9c81
commit 769fa4b592
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/bin/elementary/test_ui_popup.c
View File

@ -214,8 +214,12 @@ static void
_win_del(void *data, const Efl_Event *ev EINA_UNUSED)
{
efl_ui_popup_data *p_data = data;
efl_unref(p_data->panel_win);
free(p_data);
Eo *win = p_data->panel_win;
p_data->panel_win = NULL;
/* only free pointer if the other window has already been freed */
if (!p_data->win)
free(p_data);
efl_unref(win);
printf("window is deleted\n");
}
@ -223,8 +227,12 @@ static void
_panel_win_del(void *data, const Efl_Event *ev EINA_UNUSED)
{
efl_ui_popup_data *p_data = data;
efl_unref(p_data->win);
free(p_data);
Eo *win = p_data->win;
p_data->win = NULL;
/* only free pointer if the other window has already been freed */
if (!p_data->win)
free(p_data);
efl_unref(win);
printf("window is deleted\n");
}