From 77541f7ba2b2383b5995e7b86cde49586316f451 Mon Sep 17 00:00:00 2001 From: Andrii Kroitor Date: Mon, 21 Sep 2015 23:46:27 +0200 Subject: [PATCH] edje_edit: remove save from group_del and group_copy Summary: edje_edit_save_all includes source code generation that is way more expensive than save itself. User should be able to save manually with or without sources Reviewers: cedric, Hermet, seoz, reutskiy.v.v Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D3051 Signed-off-by: Cedric BAIL --- src/lib/edje/Edje_Edit.h | 7 +++++++ src/lib/edje/edje_edit.c | 8 -------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/lib/edje/Edje_Edit.h b/src/lib/edje/Edje_Edit.h index 8a31f1471e..54928813c3 100644 --- a/src/lib/edje/Edje_Edit.h +++ b/src/lib/edje/Edje_Edit.h @@ -342,6 +342,10 @@ EAPI Eina_Bool edje_edit_group_add(Evas_Object *obj, const char *name); * loaded with. This group can be manipulated by other API functions, * like @c edje_edit_part_add(), for example. * + * You need to save everything to make sure the file won't have broken + * references the next time is loaded. + * @see edje_edit_save_all(), edje_edit_without_source_save(). + * * @attention This group will copy the whole group and this operation can't be undone as all references to the group will be added to the file. * (for example all scripts will be written to the file directly) * @@ -360,6 +364,9 @@ EAPI Eina_Bool edje_edit_group_copy(Evas_Object *obj, const char *group_name, co * operation can't be undone as all references to the group are removed from * the file. * This function may fail if the group to be deleted is currently in use. + * You need to save everything to make sure the file won't have broken + * references the next time is loaded. + * @see edje_edit_save_all(), edje_edit_without_source_save(). * * @attention be carefull, if you deleting group, it will delete all it's aliases also, * if you deleting alias, then it will delete alias only. diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c index 68f3e0c100..c229d4d7f9 100644 --- a/src/lib/edje/edje_edit.c +++ b/src/lib/edje/edje_edit.c @@ -1693,10 +1693,6 @@ edje_edit_group_copy(Evas_Object *obj, const char *group_name, const char *copy_ eet_close(eetf); - /* we need to save everything to make sure the file won't have broken - * references the next time is loaded */ - edje_edit_save_all(obj); - return EINA_TRUE; } @@ -1871,10 +1867,6 @@ edje_edit_group_del(Evas_Object *obj, const char *group_name) if (die) _edje_collection_free(ed->file, die, e); eina_hash_del(ed->file->collection, group_name, e); - /* we need to save everything to make sure the file won't have broken - * references the next time is loaded */ - edje_edit_save_all(obj); - return EINA_TRUE; }