From 7d57c9c4329124d3d5a105d251149966cc1b29dd Mon Sep 17 00:00:00 2001 From: Bruno Dilly Date: Tue, 25 May 2010 13:36:20 +0000 Subject: [PATCH] Fix misuse of win_resize_object on test_flip3 and add comments explaining better the sorted insertion of index widget. Thanks to Sachiel for spotting that stuff. SVN revision: 49195 --- legacy/elementary/src/bin/test_flip.c | 6 ------ legacy/elementary/src/lib/elm_index.c | 5 ++++- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/legacy/elementary/src/bin/test_flip.c b/legacy/elementary/src/bin/test_flip.c index 911317b2a1..f8932a2ee1 100644 --- a/legacy/elementary/src/bin/test_flip.c +++ b/legacy/elementary/src/bin/test_flip.c @@ -301,7 +301,6 @@ test_flip3(void *data, Evas_Object *obj, void *event_info) bx3 = elm_box_add(win); evas_object_size_hint_align_set(bx3, EVAS_HINT_FILL, EVAS_HINT_FILL); evas_object_size_hint_weight_set(bx3, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - elm_win_resize_object_add(win, bx3); evas_object_show(bx3); fl_f = elm_flip_add(win); @@ -311,7 +310,6 @@ test_flip3(void *data, Evas_Object *obj, void *event_info) bx5 = elm_box_add(win); evas_object_size_hint_align_set(bx5, EVAS_HINT_FILL, EVAS_HINT_FILL); evas_object_size_hint_weight_set(bx5, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - elm_win_resize_object_add(win, bx5); evas_object_show(bx5); o = elm_bg_add(win); @@ -334,7 +332,6 @@ test_flip3(void *data, Evas_Object *obj, void *event_info) bx5 = elm_box_add(win); evas_object_size_hint_align_set(bx5, EVAS_HINT_FILL, EVAS_HINT_FILL); evas_object_size_hint_weight_set(bx5, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - elm_win_resize_object_add(win, bx5); evas_object_show(bx5); o = elm_bg_add(win); @@ -366,7 +363,6 @@ test_flip3(void *data, Evas_Object *obj, void *event_info) bx4 = elm_box_add(win); evas_object_size_hint_weight_set(bx4, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - elm_win_resize_object_add(win, bx4); evas_object_show(bx4); fl_b = elm_flip_add(win); @@ -376,7 +372,6 @@ test_flip3(void *data, Evas_Object *obj, void *event_info) bx5 = elm_box_add(win); evas_object_size_hint_align_set(bx5, EVAS_HINT_FILL, EVAS_HINT_FILL); evas_object_size_hint_weight_set(bx5, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - elm_win_resize_object_add(win, bx5); evas_object_show(bx5); o = elm_bg_add(win); @@ -399,7 +394,6 @@ test_flip3(void *data, Evas_Object *obj, void *event_info) bx5 = elm_box_add(win); evas_object_size_hint_align_set(bx5, EVAS_HINT_FILL, EVAS_HINT_FILL); evas_object_size_hint_weight_set(bx5, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); - elm_win_resize_object_add(win, bx5); evas_object_show(bx5); o = elm_bg_add(win); diff --git a/legacy/elementary/src/lib/elm_index.c b/legacy/elementary/src/lib/elm_index.c index fb601b88ab..6cd0ee2520 100644 --- a/legacy/elementary/src/lib/elm_index.c +++ b/legacy/elementary/src/lib/elm_index.c @@ -744,7 +744,10 @@ elm_index_item_prepend_relative(Evas_Object *obj, const char *letter, const void * be used when cmp_func return 0. It means the index item already exists. * So, to decide which data item should be pointed by the index item, a function * to compare them is needed. If this function is not provided, index items - * will be duplicated. + * will be duplicated. If cmp_data_func returns a non-negative value, the + * previous index item data will be replaced by the inserted @p item. So + * if the previous data need to be free, it should be done in this function, + * because the reference will be lost. * * @ingroup Index */