From 8730b8d9909a13771bc80b64288adb8692cab0bd Mon Sep 17 00:00:00 2001 From: Youngbok Shin Date: Wed, 14 May 2014 13:26:33 +0100 Subject: [PATCH] entry: Enable context menu with mosue down even if the entry is not editable in some case. Summary: Even if a entry is not editable, user can select text in the entry. When the entry has selection, we have to support "copy" option. @fix Test Plan: Precondition: Apply D852 patch for fixing a bug in elementary_test 1. elementary_test -to entry7 2. Select some text in the non-editable entry. 3. Press mouse right button. Note: You can test it in Desktop profile. Reviewers: tasn, woohyun, seoz Differential Revision: https://phab.enlightenment.org/D848 --- legacy/elementary/src/lib/elm_entry.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/legacy/elementary/src/lib/elm_entry.c b/legacy/elementary/src/lib/elm_entry.c index 53c334ed02..dc97a24e2f 100644 --- a/legacy/elementary/src/lib/elm_entry.c +++ b/legacy/elementary/src/lib/elm_entry.c @@ -1421,7 +1421,8 @@ _menu_call(Evas_Object *obj) { /* prevent stupid blank hoversel */ if (sd->have_selection && sd->password) return; - if (_elm_config->desktop_entry && ((!sd->editable) || (!ownersel))) return; + if (_elm_config->desktop_entry && (!sd->have_selection) && ((!sd->editable) || (!ownersel))) + return; } if (sd->hoversel) evas_object_del(sd->hoversel); else elm_widget_scroll_freeze_push(obj);