From 946b47430dcebeb91f8a4a9ab49ee8cd71d4e5e9 Mon Sep 17 00:00:00 2001 From: Lauro Moura Date: Tue, 16 Oct 2018 18:39:32 -0300 Subject: [PATCH] eina_cxx: Fix eina::value copy constructor. Summary: The previous declaration was causing the implicit copy constructor to be invoked when copying a new eina::value from an existing eina::value, thus leading to two wrappers pointing to the same underlying C pointer. This showed some error messages when running the tests but under autotools it didn't fail, while building with meson caused it to segfault. Reviewers: vitor.sousa Reviewed By: vitor.sousa Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7166 --- src/bindings/cxx/eina_cxx/eina_value.hh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bindings/cxx/eina_cxx/eina_value.hh b/src/bindings/cxx/eina_cxx/eina_value.hh index 36e6baa92a..5775aeb914 100644 --- a/src/bindings/cxx/eina_cxx/eina_value.hh +++ b/src/bindings/cxx/eina_cxx/eina_value.hh @@ -702,7 +702,7 @@ struct value : value_view * @brief Copy Constructor. Create an generic value storage holding the same value of @p other. * @param other Another eina::value object. */ - value(value_view const& other) + value(value const& other) : value_view(_eina_value_traits::create()) { if(!eina_value_copy(other.native_handle(), _raw))