From 9f2d1ae6ca051c48db0c2c7983eaba4cf9c006cc Mon Sep 17 00:00:00 2001 From: JunsuChoi Date: Fri, 21 Sep 2018 19:29:57 +0900 Subject: [PATCH] ctxpopup: Add return value check Summary: Using elm_widget_theme_object_set without checking return value. so add return value check and log message Test Plan: N/A Reviewers: herb, cedric, Hermet Reviewed By: Hermet Subscribers: Hermet, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7072 --- src/lib/elementary/elc_ctxpopup.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/elementary/elc_ctxpopup.c b/src/lib/elementary/elc_ctxpopup.c index 9c3ddc743f..178e76e797 100644 --- a/src/lib/elementary/elc_ctxpopup.c +++ b/src/lib/elementary/elc_ctxpopup.c @@ -1060,7 +1060,9 @@ _elm_ctxpopup_efl_canvas_group_group_add(Eo *obj, Elm_Ctxpopup_Data *priv) //Background priv->bg = edje_object_add(evas_object_evas_get(obj)); - elm_widget_theme_object_set(obj, priv->bg, "ctxpopup", "bg", "default"); + if (!elm_widget_theme_object_set(obj, priv->bg, "ctxpopup", "bg", "default")) + CRI("ctxpopup(%p) failed to set theme [efl/ctxpopup/bg/default]!", obj); + edje_object_signal_callback_add (priv->bg, "elm,action,click", "*", _bg_clicked_cb, obj); evas_object_smart_member_add(priv->bg, obj);