From b1c9b8cec0ea03cc4f95d5a6096b2a3fbe5019e6 Mon Sep 17 00:00:00 2001 From: Wonki Kim Date: Thu, 24 Dec 2020 11:48:53 +0900 Subject: [PATCH] eeze_syspaty: fix a potention memory leak Summary: if udev device get sysname fails, memory leaks. this patch fixes the problem. Change-Id: I2d02a6e6eb98e9262255ab3c02cf99f347b8c5f9 Reviewers: bu5hm4n, Hermet, zmike Reviewed By: Hermet Subscribers: vtorri, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12222 --- src/lib/eeze/eeze_udev_syspath.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/lib/eeze/eeze_udev_syspath.c b/src/lib/eeze/eeze_udev_syspath.c index 4aca7fa74b..87b2c0fa78 100644 --- a/src/lib/eeze/eeze_udev_syspath.c +++ b/src/lib/eeze/eeze_udev_syspath.c @@ -78,7 +78,10 @@ eeze_udev_syspath_get_devpath(const char *syspath) return NULL; if (!(name = udev_device_get_devnode(device))) - return NULL; + { + udev_device_unref(device); + return NULL; + } name = eina_stringshare_add(name); udev_device_unref(device); @@ -98,7 +101,10 @@ eeze_udev_syspath_get_devname(const char *syspath) return NULL; if (!(name = udev_device_get_sysname(device))) - return NULL; + { + udev_device_unref(device); + return NULL; + } name = eina_stringshare_add(name); udev_device_unref(device);