dimmus
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eo - fix bug vector when unparenting of an eo obj may affect others 

it is possible that a destructor/parent_set override or function could
go modifying the children list of objects in a parent, this the
EINA_LIST_FREE may actually miss objects in the process since within
the "free" func the list may have been altered etc.

@fix
This commit is contained in:
Carsten Haitzler 2015-08-18 17:23:16 +09:00
parent e9c5f37ab4
commit cbc1a217bf
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/eo/eo_base_class.c
View File

@ -977,11 +977,21 @@ EOLIAN static void
_eo_base_destructor(Eo *obj, Eo_Base_Data *pd)
{
Eo *child;
Eo_Base_Data *child_pd;
DBG("%p - %s.", obj, eo_class_name_get(MY_CLASS));
EINA_LIST_FREE(pd->children, child)
eo_do(child, eo_parent_set(NULL));
// special removal - remove from children list by hand after getting
// child handle in case unparent method is overridden and does
// extra things like removes other children too later on in the list
while (pd->children)
{
child = eina_list_data_get(pd->children);
child_pd = eo_data_scope_get(child, EO_BASE_CLASS);
pd->children = eina_list_remove_list(pd->children, pd->children);
child_pd->parent_list = NULL;
eo_do(child, eo_parent_set(NULL));
}
_eo_generic_data_del_all(pd);
_wref_destruct(pd);