From d5c8311470e398421d960bd6109051f5f59d2ea3 Mon Sep 17 00:00:00 2001 From: Taehyub Kim Date: Tue, 30 Nov 2021 10:48:37 +0900 Subject: [PATCH] edje lua2: check string ptr before dereference Summary: fix null pointer dereference Reviewers: Hermet, kimcinoo, jsuya, raster Reviewed By: kimcinoo Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D12309 --- src/lib/edje/edje_lua2.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/lib/edje/edje_lua2.c b/src/lib/edje/edje_lua2.c index 28e6667fda..1ea61e5ca0 100644 --- a/src/lib/edje/edje_lua2.c +++ b/src/lib/edje/edje_lua2.c @@ -491,12 +491,15 @@ _elua_scan_params(lua_State *L, int i, char *params, ...) // Stack usage - size_t len; char *temp = (char *)lua_tolstring(L, j, &len); // Stack usage [-0, +0, m] - len++; // Cater for the null at the end. - *v = malloc(len); - if (*v) + if (temp) { - memcpy(*v, temp, len); - n++; + len++; // Cater for the null at the end. + *v = malloc(len); + if (*v) + { + memcpy(*v, temp, len); + n++; + } } } break;