From e05311a99a215800b08a815067750aeb241b4c55 Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Thu, 24 Oct 2019 18:23:03 +0200 Subject: [PATCH] tests/ecore: unset app args after app args unit test to prevent invalid reads Summary: various internal components in efl access the app args and read them which will result in invalid memory access since these are stack-allocated strings Depends on D10412 Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10413 --- src/tests/ecore/ecore_test_ecore.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/tests/ecore/ecore_test_ecore.c b/src/tests/ecore/ecore_test_ecore.c index 6439bc32d2..66544d0f98 100644 --- a/src/tests/ecore/ecore_test_ecore.c +++ b/src/tests/ecore/ecore_test_ecore.c @@ -461,9 +461,16 @@ EFL_START_TEST(ecore_test_ecore_app) int argc_out = 0; char **argv_out = NULL; + int pargc; + char **pargv; + + ecore_app_args_get(&pargc, &pargv); + ecore_app_args_set(argc_in, argv_in); ecore_app_args_get(&argc_out, &argv_out); + ecore_app_args_set(pargc, (const char**)pargv); + fail_if(argc_in != argc_out); int i; for (i = 0; i < argc_out; i++)