dimmus
/
efl
forked from enlightenment/efl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

eet: do not load data when the file is open in read/write mode. 

I do think that it was a left over from previous file format. Removing
this memcpy should make Enlightenment startup faster and should reduce
by 500KB the memory it use.
This commit is contained in:
Cedric BAIL 2014-01-20 12:03:02 +09:00
parent 55a56fe5c0
commit f8b0322704
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/lib/eet/eet_lib.c
View File

@ -482,7 +482,12 @@ eet_flush2(Eet_File *ef)
{
for (efn = ef->header->directory->nodes[i]; efn; efn = efn->next)
{
if (fwrite(efn->data, efn->size, 1, fp) != 1)
if (efn->data)
{
if (fwrite(efn->data, efn->size, 1, fp) != 1)
goto write_error;
}
else if (fwrite(ef->data + efn->offset, efn->size, 1, fp) != 1)
goto write_error;
}
}
@ -904,15 +909,8 @@ eet_internal_read2(Eet_File *ef)
efn->next = ef->header->directory->nodes[hash];
ef->header->directory->nodes[hash] = efn;
/* read-only mode, so currently we have no data loaded */
if (ef->mode == EET_FILE_MODE_READ)
efn->data = NULL; /* read-write mode - read everything into ram */
else
{
efn->data = malloc(efn->size);
if (efn->data)
memcpy(efn->data, ef->data + efn->offset, efn->size);
}
/* There is no need to load data at this stage */
efn->data = NULL;
/* compute the possible position of a signature */
if (signature_base_offset < efn->offset + efn->size)