Subject: [E-devel] elm_cnp_helper patch(check string length)
Dear Brett Nash, and Elementary developers.
It's a elm_cnp_helper patch.
main changes are
1. check string length when retrieving filename
2. adding bmp filetype and ignoring filetype case
(also a type error fix for utf8).
SVN revision: 55656
Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
It's a elm_label patch.
My previous patch is too big to submit.
So I did split into patch files.
(Thanks for Gastavo and Rasterman)
2. adding label text sliding feature
SVN revision: 55654
Subject: Re: [E-devel] elm_label patch(ellipsis, sliding)
Dear Elementary developers.
It's a elm_label patch.
My previous patch is too big to submit.
So I did split into patch files.
(Thanks for Gastavo and Rasterman)
main changes are
1. refine ellipsis algorithm
- improve to cut string to fit
SVN revision: 55653
Subject: [E-devel] [PATCH] Patch for elm_slider.c (if you click the
bar of the slider, the button will be at there.)
I made one patch for elm_slider.c file.
If you click the bar of the slider, the button will be located at there.
(If you keep your "mouse_down" after moving of the button, you can
continuously move the button.)
SVN revision: 55610
Subject: [E-devel] [PATCH] elm scroller, scrolled entry: events
propagation, min size
It's not possible to connect event handler such as
EVAS_CALLBACK_KEY_UP to
elm_scrolled_entry because the scroller inside the scrolled entry does
not
propagate events. So this is the patch for adding events propagation set
function to scroller and setting it to EINA_TRUE in elm scrolled entry.
And one more thing in scrolled entry, while evaluating its size,
scrolled
entry does not consider its min size.
(It just refers to the min size of its scroller object instead of
scrolled
entry object.)
So here in the attached patch, scrolled entry compares its min size to
the
min size of the scroller object and set the bigger one to its min size
to
keep the min size set by intent.
looks good - some mistakes you made. you forgot the patch that adds
elm_scroller_propagate_events_set() to Elementary.h.in .... i added it
for
you. but remember to include it in your patch next time. Also the
documentation could be a LOT better! i fixed that for you too. also -
you
could have added a elm_scroller_propagate_events_get(). i added that
too for
you. oh.. and you didn't use ELM_CHECK_WIDTYPE().
SVN revision: 55609
Subject: Re: [E-devel] [PATCH] elm widget: make show_region_set
function call all region show functions set by parents
I'm trying to send several patches that I've changed.
This is just the beginning of my patch rushes..
'elm_widget_show_region_set' function works fine in the simple case (any
widget inside one scroller) however, in the complex parent-child case
(such
as entry in the box in the horizontal scroller in the layout in the
vertical
scroller) it doesn't work correctly because all show region functions
set by
scrollers are not called.
So I changed it to call all show region functions set by its parents
widgets
if exist.
Please review the attached patch file and feel free to give me any
kind of
feedback.
SVN revision: 55592
If you try to create a new widget, you must be sure that the parent
is really an evas object.
With the previous implementation it was possible to call an _add
function for an elementary widget with any non-null pointer as parent
eventually causing crashes (like with the elm_box).
SVN revision: 55521
elm_widget_disabled_set was calling focus_jump and it broke the focus tree.
Now, using focus_cycle to pass focus to next object.
Added test to disable focused button in test_focus.
SVN revision: 55408
Subject: Re: [E-devel] [PATCH] els_scroller
els_scroller has some problems.
First, when the function "elm_scroller_page_size_set" is used and the
scroller is bounced,
the signal "scroll,anim,stop" is not called.
Second, the signal "scroll,anim,stop" is called at the time
"ELM_THUMBSCROLL_FRICTION",
even if the animation of scroller end before the time.
So I changed the code "els_scroller.c".
Patch code is the following.
SVN revision: 55341
Subject: [E-devel] [PATCH] elm_slider patch for disable state
elm_slider does not support disable state, so I make this patch.
Please review it and upload in svn if it is ok.
(nb - also fixed vertical slider sizing in defaul theme and changed
jihoons changes to slider test to make the vertical sliders in a
horizontal box so they dont get silly long windows)
SVN revision: 55340
Subject: [E-devel] [PATCH] Some modifications for adapting
elm_longpress_timeout_get().
I made a patch for adapting elm_longpress_timeout_get() function to all
winsets, using long press event.
And I checked one warning in elm_entry.c , so I modified it.
SVN revision: 55339
When we have time, we'll research a way of signalling
mouse events from bottom up, too (or at least emulate that).
Might be useful for "trapping" mouse wheel events, what
Elementary can't do as is.
SVN revision: 55325
The Api is very large, probably there is some EINA_ARG_NONNULL that are
missing in some parameters and others that I put that should not be
there, I tried my best to not have these mistakes, if you find
any, please, fix it :).
SVN revision: 55189
As we talked last week, I made a version of adding external image in
elm_entry. It seeks a local file if prefix is 'file://' then it loads image and adds it. If image file can't be loaded, adding
wft emoticon.
patch in with minor fix for path and an added actual test case in elm
entry test.
SVN revision: 55134
The reason for modifying about elm_colorselector can be "readability".
Each bar in the colorselector has its own color type (like hue, saturation,
...)
So I thought it will be better, if I added enum for each color type.
And, for about elm_entry.c , I thought that "SIG_CLICKED" was wrongly
emitted (by "MOUSE_UP" event).
I deleted mouse_up callback function (as you advised),
because this function didn't do anything by my modification.
By: WooHyun Jung <wh0705.jung@samsung.com>
SVN revision: 55097
Discomfitor, go fix ecrustify :(. Sucking hard for functions like
elm_object_signal_callback_add, i.e., big function prototypes as
argument types.
SVN revision: 55055
When searching for an icon in a theme, efreet needs to load the specific
cache for the theme. So if an icon doesn't exist, this will be a huge
overhead. So it is better to find a theme on init, and then stick with
it.
SVN revision: 55004
elm_scroller_policy_get was not verifying if its parameters are null.
elm_scroller_region_get was not getting the y if you pass x = null
and y != null
SVN revision: 54987
If the file is a NULL pointer, it will delete the old imagem and set its
internal strings about file and group to NULL.
In the get function if the file argument is null does not mean that
it will not retrieve the group too.
SVN revision: 54986
This commit fix the first issue with launcher in elm_test, when was appearing a
white rect all over it and the icons names seemed to be missing. It also fix
a related issue reported by the editje guys.
SVN revision: 54979
As I’ve talked to you just before, I’m sending you the patch file for
applying max size in sizing_eval function in the scroller.
This patch will work in the case below
- elm_scroller_content_min_limit() function is set to 1 (either
width or height)
- the content’s min size is growing up unlimitedly (such as
entry case)
Then the min size of the scroller cannot exceed the max size of itself.
(if we let it be grown up to the content’s min size, there is no way
to limit the size of the scroller and to enable scrolling.)
Please consider this way to avoid failure case (min is greater than
max) in the sizing_eval function,
and give me a feedback if it doesn’t meet any other requirement.
Thank you.
P.S.) patch file was created based on Rev. 54766.
SVN revision: 54978
NB: we got textblock parts as some of our text elements, everyone
knows. They support text_class fallbacking, but what would be an
elegant solution to achive reasonable mapping for styling tags (bold,
highlight, etc)? e17 has some "blah_hilight" text classes, which imho
are ugly...
SVN revision: 54915
Although some widgets are modified in this patch there should not be any visible
change. Actually this patch is intended to fix a Gengrid issue (patch following).
In Gengrid when the items were bigger than the grid itself the scroll would not
work correctly when the alignment was other than 0.0. That happened because the
smart scroller object was assuming the pan origin to be (0,0) and doing some
miscalculations based on that.
SVN revision: 54902
Edje caching primitives exposed in Elm, too, now, and stored at
config. Also, there's now a poller running for all Elm apps doing
cache flushing. All these things have configurable values, of course.
Testing config version bumping too, it should work.
SVN revision: 54851
Spank watchwolf. The last added externals dont compile with the flags
that we try to keep OK, since revision 53683.
Replace calloc(1,X) to use ELM_NEW, i want do tests with mem pool.
SVN revision: 54778
Now working on exposing edje caching too, and having a cache dumping
poller. Patch also replaces some focus_overalay object functions,
too.
SVN revision: 54770