th pending cancel may call callbacks... which can mess with the list
and thus the pending_add we have, sso do our work before calling this
(like set pending_call to NULL).
Summary:
due to wrong return value checking, annoying error message is coming out.
@fix
Test Plan: terminology -> tyls in the directory contains pictures -> clear screen (clear) -> check whether error message is coming out or not
Reviewers: raster, cedric
CC: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1159
Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
Summary:
setup related API was not working at all due to below problems
1. dbus type signature is wrong. it's array of dictionary not array of struct
2. since quality value was assigned to compress value, there was a problem during saving png image (out of bound)
3. orientation_set API was not working except NONE and ORIGINAL
@fix
Test Plan: make thumbnail by using elm_thumb_add -> orientation set to 90 CCW -> check whether image is rotated properly or not
Reviewers: raster, cedric
CC: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1138
Signed-off-by: Cedric BAIL <c.bail@partner.samsung.com>
Being annoyed by different types of eina critical macros - CRI, CRIT,
CRITICAL -, I concluded to unify them to one. Discussed on IRC and
finally, CRI was chosen to meet the consistency with other macros -
ERR, WRN, INF, DBG - in terms of the number of characters.
If there is any missing bits, please let me know.
NB: Above, _ethumb_client_async_free Could have been called, which
will free the async client. Add valid check for async before we append.
Signed-off-by: Chris Michael <cp.michael@samsung.com>