Allows setting a trap in elm_win that intercepts calls to
ecore_evas. If there is a trap and the trap returns EINA_FALSE, then
the corresponding call is NOT issued. If it does not exist or returns
EINA_TRUE, then the call is executed.
Enlightenment window manager will set these traps and will call
e_border directly, allowing E17 to use Elementary! A major feature
given e_widgets painful usage.
This should also help integrating into Wayland or even debug.
SVN revision: 74156
widgets.
Some of them have initting code using the parent ptr for some logic.
Now there's a new idiom on instantiating widgets which adresses
that. It'll be used for all widgets from now on.
SVN revision: 74147
When smart obj was set as the contents the _configure would be called recursively.
In this process the lastest size could be reverted as the previous one.
SVN revision: 74064
Subject: [E-devel] [PATCH] Add frame size when calculating minimized
elm_win size
Hi,
I found frame size including width and height isn't counted in
_elm_win_resize_objects_eval() when calculating minimized elm_window
size.
It is OK for X engine because elementary only draw client area and X
provides widow frame. So both the width and height from
evas_output_framespace_get are 0.
But it cause bug for wayland engine because elementary need draw
window
frame by itself. So real client area size is smaller than window size.
If frame size isn't counted into minimized window size, there isn't
enough client area to layout widgets.
So it is bug for any engine in which elementary draws window frame by
itself. It is the reason of
http://trac.enlightenment.org/e/ticket/1064.
Could you please my attached patch for this issue?
Thanks.
SVN revision: 74049
an app. they printf as OUTPUT. alkso u broke build:
/home/raster/C/elm/src/bin/test_genlist.c:2862: undefined reference to
_elm_log_dom'
of course there is no symbol exposed that is an INTERNAL LOG DOMAIN to
elm! it's for elm not for outside.
SVN revision: 73957
The ERRs thrown on the terminal while exiting some tests were already
there -- check that those decorate and stuff modes add lots of NULL
children on lists.
Genlist work exactly as before. All the bugs and feature were kept :)
SVN revision: 73941
knew him well. disable because it seems nothing i try requests it
except thunderbird, and thunderbird seems to sumarrily ignore the text
we provide. why - don't know. would have to now dig into thunderbir
src, but suffice to say plaintext is working a charmer, so let's stick
to that.
SVN revision: 73913
elementary configuration environment. Patch by Bluezery
<ohpowel@gmail.com>
On Thu, Jul 12, 2012 at 1:00 AM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> Vertical bounce enable value can be changed by elementary
> configuration environment.
> But currently It was always EINA_FALSE. I fix that this value can be
> got from elm_config value.
>
> Please review this patch.
> Thanks
SVN revision: 73596
ecore_evas_window_get with a replacement function that checks the
currently used engine first. This fixes a segfault when running elm
with the wayland engines.
SVN revision: 73568
trying to use an invalid X window when running under the Wayland
backend. Replaces the non-safe call to ecore_evas_window_get, with an
_elm_ee_xwin_get function that checks the used engine first. Replace
call to ecore_evas_window_get inside elm_cnp.
SVN revision: 73567
Everytime a icon not on edje file is used (an standard icon),
an error was printed because it was trying to set it from
edje first.
Now it checks if the group exists on edje first.
SVN revision: 73543
We had an inconsistency of two missing getters, that would "leak" API
deprecation on specialized scrollers (scrollables). Putting them in
for good now.
SVN revision: 73540
i know - freeze is on. last thing going into elm. only because i
rejected the patch at the last minute and it was small enough to do
now.
SVN revision: 73450
Subject: [E-devel] [patch][elementary] diskselector, duplicate icon
for rounded item
minor fix to diskselector to repeat icons right.
The diskselector has round mode which can be set by
elm_diskselector_round_enabled_set().
In case of round mode is enabled, the icon does not display properly
because diskselector replace the icon for the additional items - not copy
and paste. To enable round mode, diskselector adds over/under itmes(additional
itmes) by using normal mode items. So there is a icon to set two places in
diskselector. But diskselector does not duplicate the icon.. this makes item
without icon but there should be.. I'm not sure the best way to duplicate icon.
SVN revision: 73397
Subject: Re: [E-devel] [Patch][layout] select layout in access mode
I revised the patch which has the way to get the state of
accessibility now. elm_layout_edje_object_can_access_set/get().
SVN revision: 73393
Its API will be the the common one on ALL scrollable widgets, too.
Any scrollable widget having a function behaviour clashing with one of
the elm_scroller_* will be marked as DEPRECATED from now on.
SVN revision: 73309
This is meant to be used for all widgets implementing scrolling views.
An Elementary interface adds a given behaviour to whichever widget,
from any class.
SVN revision: 73307
last to be evaluated.
Porting of the basic scrolling infra to an interface will happenfirst, as well as the scrolling widgets porting.
Patch by: Gustavo Lima Chaves <glima@profusion.mobi>
SVN revision: 73306
Subject: [E-devel] [Patch][elm_widget] access hook
Real time setting would be necessary in case of running applications
which
have elm_layout or elm_widget_item.
If the access mode does not care of this, running applications should
restart. The attached for this. Please review the patch and give any
feedbacks. Thanks.
SVN revision: 73229
Subject: [E-devel] [E-deve] [Patch] Add new apis for editable set/get
in multibuttonentry
Typically multibuttonentry is used as a composer.
But sometimes, Multibuttonentry can be used as a viewer.
Currently there is no way to use multibuttonentry as non-editable
viewer.
So I added new APIs which are elm_multibuttonentry_editable_set/get().
If editable is true, entry in multibuttonentry is activated and user can
compose item by pressing the return key.
If not, entry is hidden and muttibuttonentry works as a non-editable
viewer.
SVN revision: 73223
Subject: [E-devel] [Patch] Added new style for hoversel (hoversel_horizontal)
Problem:
Ticket #838 (new Bug). Items appear without background on a
horiz-hoversel.
Just add: elm_hoversel_horizontal_set(bt, EINA_TRUE); to the first
hoversel
added in test_hoversel.c then try to open it.
Items appear without black background.
SVN revision: 73078
Subject: [E-devel] [Patch] Patch for test case for panel widget
(genlist expand automatically)
Problem:
In test case for panel widget genlist not expand automatically
Commit log:
Added patch for test case for panel widget (genlist expand
automatically).
SVN revision: 73077
Subject: [E-devel] [Patch] Patch for normal scaling in elm_panel.c
widget
Problem:
Ticket #656 (new Bug) . The whole test window size will just grow
larger and
larger on each _theme_hook called.
Easy to reproduce: 1. Open elementary_test's panel test 2. Do
something that
issues a theme_hook (change scale etc)
SVN revision: 73076
Subject: [E-devel] [Patch][elementary] elm_access, use widget_item in
focus chain
It has been possible to use widget_item in access mode. The mouse-in
event
makes the widget_item speak.
But focus chain is not useful in access mode, because the widget_item
cannot get the focus as the edje object.
The accessibility highlight will move by keeping the attached patch
and you
can hear the sound of widget item information.
Please review the patch and give some feedbacks. There would be further
works such as dynamic setting focus next hook,
the previous _elm_access_list_register();, but please keep this first if
there is no big trouble. I'll do those also. Thanks.
SVN revision: 73074
Subject: [E-devel] Fwd: [Patch] elm_toolbar add signals patch.
For new style of toolbar (align icon and text to center of item) are
necessary some signals ("elm,state,text,visible",
"elm,state,text,hidden", "elm,state,icon,visible",
"elm,state,icon,hidden")
New style for toolbar, where icon and text are align to center of item.
SVN revision: 73028
It seems that the elementary examples still use some deprecated functions,
most notably elm_icon_* that has been replaced by elm_image_*.
This patch fixes that.
Patch by: Daniel Willmann <d.willmann@samsung.com>
SVN revision: 72958
One should either listen to mouse events and filter the corrosponding multi
events, or listen only to multi events. We chose the former, so we should
handle it correctly.
SVN revision: 72905
The datetime module has unnecessary lines.
The datetime resets ctxpopup parent in ctxpopup parent resize callback.
But ctxpopup has its own callback for the parent resize.
In this callback, ctxpopup hides itself. then, ctxpopup recalculates its
parent size when ctxpopup shows itself.
So the parent resize callback in the datetime is not necessary.
Then, please review the patch and give some feedbacks. Thanks.
Patch by Shinwoo Kim.
SVN revision: 72518
revert ->
Log:
From: Daniel Willmann <d.willmann@samsung.com>
Subject: Re: [E-devel] [PATCH] elementary: Add
elm_progressbar_maxunit_{set, get} functions
Some more discussion in IRC led to the conclusion that this should be a
handled in a signal callback I've attached the new patch where I also
updated the progress bar example.
Author: raster
Date: 2012-06-19 02:26:29 -0700 (Tue, 19 Jun 2012)
New Revision: 72459
SVN revision: 72506
Implements the module unloading to all modules on elm_module_shutdown.
This change also fixes a memory leak within elm_module picked by valgrind.
Here follows the valgrind log:
96 bytes in 1 blocks are definitely lost in loss record 105 of 168
at 0x4C29DB4: calloc (
in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x52065B6: _elm_module_add (elm_module.c:223)
by 0x520669E: _elm_module_parse (elm_module.c:77)
by 0x51F1249: elm_quicklaunch_sub_init (elm_main.c:437)
by 0x51F12BE: elm_init (elm_main.c:180)
Patch by Leandro Dorileo <dorileo@profusion.mobi>
SVN revision: 72499
Removes the event callback list within _smart_del. The current
implementation does not care about the node data resulting on
memory leaks.
Here follows the valgrind log:
16 bytes in 1 blocks are definitely lost in loss record 11 of 168
at 0x4C29DB4: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x522EC34: elm_widget_event_callback_add (elm_widget.c:1996)
by 0x5A7AA2B: _edje_emit_handle (edje_program.c:1322)
by 0x5A766B6: _edje_message_queue_process (edje_message_queue.c:764)
by 0x5A76856: _edje_job (edje_message_queue.c:160)
by 0x628C02A: _ecore_job_event_handler (ecore_job.c:115)
by 0x6288C1F: _ecore_event_call (ecore_private.h:319)
by 0x628D09B: _ecore_main_loop_iterate_internal (ecore_main.c:1814)
by 0x628D566: ecore_main_loop_begin (ecore_main.c:931)
by 0x4023B0: elm_main (test.c:198)
Patch by Leandro Dorileo <dorileo@profusion.mobi>
SVN revision: 72498
Subject: Re: [E-devel] [PATCH] elementary: Add
elm_progressbar_maxunit_{set, get} functions
Some more discussion in IRC led to the conclusion that this should be a
handled in a signal callback I've attached the new patch where I also
updated the progress bar example.
SVN revision: 72459
Thanks to Daniel Willmann pointing them out to me. Actually I wonder
why we need all this define and undef for ENGINE_COMPARE. Will dig a
bit deeper into that and see if we may can go with a single one.
SVN revision: 72144
strncmp() really does not like that. So we should not be lazy and check for it. Say thanks to
scan-build which reported these to me.
SVN revision: 72142
Subject: [PATCH] elementary: Minor fix to the documentation of ActionSlider
Date: Thu, 14 Jun 2012 15:31:05 +0100
Yeah, the most overhead I could imagine. :-)
SVN revision: 72141
Subject: [E-devel] [Patch] elm_config_font_overlay_apply bug fix
[Current Issue]
- The API applies the changes with elm_config_font_overlay_set().
But at the first time, application fonts have not been changed after
elm_config_font_overlay_apply api is called.
The application fonts changed only when the display is updated or
elm_config_font_overlay_apply api is called again.
[Main cause]
- When the elm_config_font_overlay_apply is called at fist time, it
calls
edje_text_class_del and edje_text_class_set in locally. But
edje_text_class_set just returns without _ejde_reclc() when new text
class
is ceated.
So in this case, there is nothing to be changed.
Since second call the api, edje_text_class_del api calls
_edje_recalc() in
locally. So the application fonts are changed.
[Change Description]
- There is two method. The first is to enable ejde_test_class_set api
is
can be recalced when the fist calling.
The second is to add _elm_rescale() function in
elm_config_font_overlay_apply API. This occurs edje_recalc effect
after font
overay set.
I attached the second method.
SVN revision: 72124
evas_map_point_coord APIs have the int values but evas_map_point_image_uv_set have the double parameters on the other hand.
This inconsistency causes the inexact result(flickering).
It's not good APIs for users.
SVN revision: 71979
Dear all, hello.
There is a case, in the _ctxpopup_parent_resize_cb() is called even
though the datetime is removed.
It makes a crash, so the callback should be deleted before removing
datetime. That's it.
Sincerely,
Shinwoo Kim.
Submitted-By-Off: Kim Shinwoo <kimcinoo.efl@gmail.com>
SVN revision: 71929
An EVAS_CALLBACK_DEL event cb will take place before the smart del
function, so there'll be more action taking place after that, and Elm
has be on.
SVN revision: 71867
Instead of them, add the APIs elm_toolbar_standard_priority_set/get.
The items which are lower than standard priority are located in more menu or panel.
SVN revision: 71777
* Move X related window items into their own substruct of
_Elm_Win_Smart_Data to allow grouping based on engine.
* Move X related cursor items into their own substruct of Elm_Cursor
to make supporting cursors on other platforms cleaner.
* Add support for setting the cursor under Wayland:
* Introduce a configure option and #define to as per other engines
* Add always-built API function to allow identification of running
under Wayland (like for X11)
* Call into Ecore to set the cursor when the mouse enters the desired
widget.
SVN revision: 71754
The Makefile rule building that is commented out -- meant to be run
locally once in a while (when changes on overall widget tree happen)
and changed images commited.
SVN revision: 71721
Subject: Re: [E-devel] [Patch] [elm_entry] New APIs for user style
Thank you for your comments.
I would like to send you the modified patch.
Followings are my modification:
- Add my part to ChangeLog, AUTHORS files as Raster's comment.
- Add const to the parameter of elm_entry_text_style_user_peek and
example for pop and peek to test_entry_style_user as Daniel's comment.
SVN revision: 71557
This a team work, half of the borkage by zmike and half by me. I hope we succeed.
NOTE: It is better to do one smart object that you apply map on it, that to apply
map on it's 10 childs separately.
SVN revision: 71520
Patch by Jérôme Pinot <ngc891@gmail.com>.
- #link on the beginning of a new line does give ugly output:
http://ngc891.blogdns.net/pub/projects/debug/doxygen-formating-eww.png
- some typos
- some missing @c
- in elm_web, convert remaining @li parameter lists to @param
- minor random fixes
SVN revision: 71486
window representation.
The attached change to Elementary makes a small refactor to use
existing code that was already conditional on the Elm engine to
retrieve the underlying window - thus allowing elm_win_xwindow_get to
return 0 in the case when called on a Wayland based Elm window.
Patches have been tested against X11 and Wayland built together by
running elementary_test.
SVN revision: 71455
new schema.
els_icon smart object was brought to be the base of the image widget,
in the form of an image class.
An elm icon is now a elm image, with a little more on top of it.
An elm photo is a now base widget aggregating an icon.
Toolbar's internal usage of the former els_icon is now changed to
icons, instead.
Some naviframe instantiations were set to enable events during
transitions, because this code is buggy and my chages exposed the
problem. It will be fixed as soon as I get to port Naviframe.
SVN revision: 71429
Subject: [E-devel] [Patch][elm_map] Add New "loaded" signal
I want to add new "loaded" signal to elementary map. This signal
notify users when all map tiles are loaded. Timer is used for this signal.
Currently "tile,loaded" can be used for each separated tile. So the
users are hard to know whether all tiles are loaded or not.
Please review this patch.
SVN revision: 71406
Subject: [E-devel] [patch] allow copy and paste operations for
non-widget evas objects
I am currently implementing a clipboard for WebKit-EFL. When using
elm_cnp_selection_get and set function an evas object passed has to be
a widget. Currently in WebKit-EFL we are using an view which is an
Evas_Object, but not a widget. Sample WebKit applications like
EWebLauncher and tests applications does not use elementary so I
cannot obtain parent widget for a view object and finally we cannot
perform copy and paste operations.
Widgets are used in elm_cnp_selection functions to obtain
Ecore_X_Window. My patch leaves current way of obtaining it and adds
an another in case when the standard one fails. When Evas_Object is
not a widget I am trying to get an Ecore_X_Window using ecore.
SVN revision: 71381
Subject: [E-devel] [Patch][elm_map] Add elm_map_overlays_get &
elm_map_overlay_visible_get
I want to add 2 new APIs (elm_map_overlays_get & elm_map_overlay_visible_get).
There are no way to get the group overlays because group overlay,
something like virtual overlay, is created and deleted dynamically.
So elm_map_overlays_get returns total overlay's list and user can get
any type of overlays including group overlays.
Overlays which is grouped can not be visible. Because overlay grouping
is performed by elm_map, user do not know whether overlays are visible
or not. So elm_map_overlay_visible_get is added for this reason.
SVN revision: 71354
parent is deleted.
On Tue, May 22, 2012 at 4:46 PM, Sohyun Kim <anna1014.kim@samsung.com>
wrote:
>
> Hi all.
> When I use elm_notify, I got a crash in the deleting routine. (you
can test it in elementary_test > Video)
>
> When parent window of elm_notify is deleted, elm_notify set its
parent to NULL.
> However, it doesn't delete event callbacks of the parent window.
>
> In the smart_del callback of elm_notify, it tries to delete event
callbacks of parent window.
> However, its parent is already set to NULL, the deleting is skipped.
> Then the widget data gets freed.
> In this case, when other objects in the window are deleted, they can
create the parent window's event (e.g. CHANGED_SIZE_HINTS,,)
>
> Please find a patch to delete event callbacks when parent window is
deleted.
>
> Regards, Sohyun
SVN revision: 71307
There is a case that parent can be NULL when you call
elm_ctxpopup_add().
This reverts commit 8bc665a6ebc9daf0d5faa46223635f46f3d0f682.
SVN revision: 71305
<ohpowel@gmail.com>
On Mon, May 21, 2012 at 5:32 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> When ctx_popup is deleted, it calls "elm_widget_sub_object_del(parent,
> popup)" so that ctx_popup's parent can delete it's sub_ojbect,
> "ctx_popup".
> But this is not needed because parent already deletes it's sub-object
> in elm_widget.c
>
> Thanks
>
> --
> BRs,
> Kim.
SVN revision: 71301
Dear all, hello.
If an item of diskselector has only icon without label, then the icon
displays at left side of its space.
So if there is no label, the icon should display at the middle of its
space.
Please review the patch. Thanks.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Kim Shinwoo <kimcinoo.efl@gmail.com>
SVN revision: 71279
Instead of a global 400msec value, we now have 200msec between mouse downs.
E.g if the first timestamp is 0, we get:
valid: down(0) up(50) down(150) up(300)
invalid: down(0) up(100) down(201) up(250)
SVN revision: 71200
I've received feedback on being bad to expose the thumb's frame.
So, making it a base widget here. Let me know what you guys think.
SVN revision: 71176
Documentation was wrong too and code had a slight bug stopping
genlist from contracting to min size.
Optimize the case of COMPRESS + homogeneous mode to avoid
queue entirely and use existing known item sizes.
SVN revision: 71140
sometimes the only separators are shown even though the items are hidden.
So the separator's visibility is desided by it's previous item.
SVN revision: 71093
behaves.
Containers like boxes should not be resizing themselves, but flagging
desireable sizes via size hints to parent widgets.
Let it be that way for now, though. Ctxpopup is giving me A LOT OF
HEADACHE to port to the new schema without having to rewrite it :(.
It has the craziest code flow on sizing things, and of course that
code is uber fragile to borks.
SVN revision: 71085
should be called prior to edje_object_part_swallow. This is because
evas-callback function(about EVAS_CALLBACK_CHANGED_SIZE_HINTS) which is
registered by _smart_sub_object_add should be called after the one
registered by edje_object_part_swallow.
SVN revision: 70985
Hi! All,
[test_menu]
I have added test code for following APIs, even though Elementary 1.0 is
released. :-)
- elm_menu_close()
- elm_menu_item_icon_name_set()
- elm_menu_item_is_separator()
- elm_menu_item_selected_set()
- elm_menu_parent_set()
Then, please review those patches and keep on the upstream.
Sincerely,
Shinwoo Kim.
SVN revision: 70983
* Fileselector test: add a check to enable/disable buttons
Updated Changelog and NEW, also add myself as authors...
btw: the EIO code in the Fileselector is crazy-complex, about 200
lines of code just to have the list of files ina dir... :/
SVN revision: 70965
Currently there's semi-ready code (1 liner) that does nothing. Hermet, you
promised you'll add ui-mirroring support AGES ago when this widget got in.
SVN revision: 70960
NOTE: This is not very robust yet. But that's not related to this patch.
You can see the issue when switching between two different theme in
elementary_config. At some point elementary_test start to loose information.
SVN revision: 70895
Hi Mr. Park,
Please find attached theme bug fix patch of elm_colorselector.
Bug:
1. Colorselector spreading its size to whole window.
2. Colorselector size not adjusting properly when shifted in between different modes.
Change Log: Color selector Theme fixed to adjust size properly based on mode and demo
application appropriately fixed with proper size.
Signed-Off-By : Shilpa Singh<shilpa.singh@samsung.com>
Thanks & Regards
Shilpa Singh
SVN revision: 70869
Hi!
I have just modified the elm_menu.c because there are some improper
indentation.
That's it... Thanks.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Shinwoo Kim <kimcinoo@gmail.com>
SVN revision: 70758