Mr. Wonguk Jeong made a patch for elm_module.
This patch is for changing the timing of module loading.
For now, module loading is done in elm_init
Thus, modules are always loaded, even if the application does not use
them.
So this patch deferred the timing of module loading to
"_elm_module_find_as".
SVN revision: 56586
Subject: [E-devel] [Patch] genlist item cache exception handling patch
I added "no cached item" handling.
In some case, items should not be cached and should not use caches.
For example,
if there was a state change in item style, it should not be cached
because it remembers the state changes.
And if we use elm_genlist_item_item_class_update() API,
item should not be cached as well.
It needs to be a fresh item style without remembering the state changes.
SVN revision: 56585
Subject: [E-devel] [Patch] elm_genlist patch regarding inlist
I made a patch for elm_genlist.
For getting genlist item from inlist, ELM_GENLIST_ITEM_FROM_INLIST macro
should be used.
SVN revision: 56582
Subject: [E-devel] [Patch] Removed dead code in elm_genlist.c
I removed dead macro LONGPRESS_TIMEOUT.
Genlist's longpress_time value is read from
_elm_config->longpress_timeout.
SVN revision: 56581
Subject: [E-devel] [Patch] els_scroller - Cannot click even if it
reach to end
I have another issue in scroller when the bounce is off.
Scroller cannot be clicked even if it reach to edge and animation is
end.
The reason is why the momentum animation is running even if it reach
end and bounce animation is off.
So I change the code that if it reach the edge in case of bounce-off,
the momentum animation is stoped.
The following is the patch code.
SVN revision: 56580
Subject: [E-devel] [Patch] els_scroller -
elm_smart_scroller_child_region_show
I have some issue in scroller.
Sometimes the scroller move to wrong region when the child get first
focus.
It use "scroller -> layout -> button".
So I checked the code and found a suspected thing in
elm_smart_scroller_child_region_show.
Please refer following pictures.
In the pictures, the rect which be written "x, y, w, h" is the area
which be made with the parameters of
"elm_smart_scroller_child_region_show".
The rect which be written "Pan" is the pan area of the scroller.
If the situation is 1) or 2) and the function is called, the result
have to be 7).
In case of 3) or 4), it have to be 8).
In case of 5) or 6), it have to remain as it is.
Is it right??
But if the situation is 6) and the function is called, the result will
be 7) in current code.
I think it is wrong.
I attached patch code. please find it below the pictures.
1)
---------------
| |
| x, y, w, h |
| |
---------------
---------------------
| |
| |
| |
| Pan |
| |
| |
| |
---------------------
2)
---------------
| |
| x, y, w, h |
---------------------
| | | |
| --------------- |
| |
| Pan |
| |
| |
| |
---------------------
3)
---------------------
| |
| |
| |
| Pan |
| |
| --------------- |
| | | |
---------------------
| x, y, w, h |
| |
---------------
4)
---------------------
| |
| |
| |
| Pan |
| |
| |
| |
---------------------
---------------
| |
| x, y, w, h |
| |
---------------
5)
---------------------
| |
| --------------- |
| | | |
| | x, y, w, h | |
| | | |
| --------------- |
| Pan |
---------------------
6)
---------------
| |
--------------------- <---Pan
| | | |
| | x, y, w, h | |
| | | |
---------------------
| |
---------------
7)
---------------------
| | | |
| | x, y, w, h | |
| | | |
| --------------- |
| |
| Pan |
| |
---------------------
8)
---------------------
| |
| Pan |
| |
| --------------- |
| | | |
| | x, y, w, h | |
| | | |
---------------------
SVN revision: 56579
Subject: [E-devel] [Patch] small patch for elm_main.c
I made small patch for elm_main.c
In elm_all_flush function, I was suspicious about,
if _elm_win_list is NULL then following codes should not be called or
not.
ejde_file_cache_flush();
edje_collection_cache_flush();
eet_clearcache();
I thinks above functions should be called without any consideration
about
the state of _elm_win_list.
SVN revision: 56574
Subject: [E-devel] [Patch] elm_genlist patch for group index handling
and bug fix
I attached a small patch for elm_genlist.c
1. _item_block_position() fix
This patch realizes group index even there is no sub-items.
There was a request about this.
And it shows that there is no sub-items explicitly.
2. Bug Fix
Null check routine was wrong-placed.
I fixed it.
SVN revision: 56573
Subject: [E-devel] [Patch] environment parameter - ELM_EFFECT_ENABLE
I want to add the environment parameter "ELM_EFFECT_ENABLE".
It will play a role as the enablement for the effect of all widget.
SVN revision: 56572
Subject: [E-devel] [PATCH] elm_transit
Here is a minor patch for elm_transit
(indentation & removed unuseful calls - evas_map_smooth_set)
SVN revision: 56571
In this change I also introduced elm_smart_scroller_child_region_set thats used to change the position of the scroller, without actually saving it as a wanted position.
SVN revision: 56284
Revert "Elementary scroller: Fixed an issue in scroller. When a resize happens (or any change for that matter), we should go to the last "asked for" location. This for example fixes an issue with elm_scrolled_entry (and many other widgets) showing "empty regions" on some resizes."
This reverts commit f322bd28101518849c53e6d56b93c206e4129162.
SVN revision: 56282
Revert "Elemenatry: Fixed an issue with elm_scrolled_entry_cursor_end_set not showing the correct region."
This reverts commit 90e80c4045d0c7031b0b01b67b06f62ea8efb14f.
SVN revision: 56281
(for that matter externals has a problem in design - it loads every
module for externals and thus links in every lib even if never used by
the app/edje obj).
SVN revision: 56218
can't. its a matter of simply some element re-rendering that is hidden
- rendering into a mapped buffer. i disable the animation in the
layout (layout2) and no cpu usage. that's my bet.
SVN revision: 56204
Subject: [E-devel] [Patch] small patch for elm_pager.c
I felt strange with the following codes in elm_pager.c
Why it->content should be hidden after deleted ?
Is it a bug ?
I made a small patch for this
SVN revision: 56127
By default it's text only for single line entries (you can toggle it back on
if you want to). Otherwise images are enabled for multiline entries.
SVN revision: 56078
So basically you can request markup without images. If you want both request
MARKUP | IMAGES. Then when an image comes in you'll get an image as markup.
SVN revision: 56076
Subject: [E-devel] [Patch] elm_map downloading progress info & bug fix
I added one new signal, one new API and fixed seg fault bug.
- signal : "download" (this signal is called when map_tile is
downloaded)
- API : elm_map_utils_downloading_status_get(const Evas_Object *obj, int
*try_num, int *finish_num)
- seg fault : if user select custom map provider, seg fault occurs,
because
there is no url_cb in the custom map provider
you can check download progress using these signal & API.
the example is in "test_map.c".
SVN revision: 56039
Subject: [PATCH] elc_ctxpopup
Here code is for the ctxpopup.
Since the functionalities of ctxpopup are somewhat different,
I'm trying to overwrite the ctxpopup code entirely first.
The main reason is,
Original ctxpopup could determine it's size and position by itself.
Of course, upstreamed version supports this. But it can not be reduced
it's
size
And it supposes the arrow position to center of box edje.
Basically,
This version calculates it's box size first then find available space
from
the it's position.
The origin position of the box is not expected, it finds the available
positions.
But if there is not enough space to be shown, then it finds a best
direction
to be shown again.
In this case, it reduces it's size also as to be shown entirely.
Since the ctxpopup supports scroller, the reduced box could show the all
items also.
(The point is ctxpopup should know the size of total items...)
I'm not sure the upstreamed version could cover the above scenario,
If then, I need to modify it first.
(fixed some minor formatting issue too)
SVN revision: 56021
Subject: [E-devel] [Patch] elm_genlist doxygen fix and addition.
I fixed some typos of Genlist doxygen and added more explanations.
Please review this and apply this to upstream.
SVN revision: 56017
Subject: [E-devel] [PATCH] Change the second parameter type of
elm_slidershow_timeout_set
Most of APIs related to timeout_set / get uses double type as parameter,
but elm_slidershow uses integer type.
For uniformity, the second parameter type of elm_slideshow_timeout_set
is changed into double type.
SVN revision: 56015
Patch original from Hyoyoung Chang.
Modified by me a lot, with some extra debug.
Also I removed the sizeof(char). That was defined to be one before most of us
where born.
SVN revision: 55986
Even it looks somewhat alien elm,
I hope EFL supports basic effect by using c and edc.
In some cases, it is useful for app developers.
They want to use effects easily and quickly as Other F/W does
providing.
Here is patch again.
Added two lines for elm_transit_duration_set exception handling.
I guess there are possibilities still to add/modify some functions to
the
transit.
So, currently the exception cases does not defined yet.
But I will try patches soon as perfect things.
Please consider about transit.
And.. if this transit is acceptable,
How about deprecate elm_animator as soon as possible?
SVN revision: 55966
Subject: RE: [E-devel] [Patch] Group index support
I added a small patch for Genlist group item clear.
And I changed git->minh to git->h in item_block_position function.
Thanks Govi
SVN revision: 55965
raster: may I rename elementary_config.h to config.h ? If I
add macros for all the init stuff, it would be nice to have
consistent name for that file
SVN revision: 55952
Subject: RE: [E-devel] [Patch] Group index support
I added a small patch for Genlist Group.
I missed one. Thanks Govi!
Can you review this and apply it to upstream?
SVN revision: 55929
Subject: [E-devel] [Patch] Group index support
I added group index feature.
This feature support to show item indicates group index.
I attached capture images showing group index.
As you can see attached png images, Group index item includes same group
items.
The group index is shown until every items that have same group index
are scrolled. so group index realize/unrealize is not excuteded in
_item_block_position function.
instead of the function, group index is controlled in _pan_calculate
function.
"Genlist Group" and "Genlist Group Tree" menu is added in
elementary_test. you can test group index operations in elementary_test.
This patch is not support elm_genlist_item_insert_before/after
operation of group index. We are now considering the operations in group index.,
This patch assumes that the previous 2 patches are already applied to upstream.
'[E-devel] [Patch] Tree support for elm_genlist_item_prepend() API.'
'[E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after() APIs',
So this patch does not include the changes of the previous patch.
I separated this patch.
- 004.elm_genlist.c.patch.txt
Patch for src/lib/elm_genlist.c
- 005.test_genlist.c.patch.txt
Patch for src/bin/test_genlist.c
- 006.genlist.patch.txt
Patch for data/theme/default.edc
And you have to add attached group_index.png file into 'data/themes'
'group_index.png' file is group index background image.
Daniel Juyung Seo help make test code and refactoring group index code.
SVN revision: 55925
Subject: Re: [E-devel] [Patch] elm_map pinch zoom
This is a patch for elm_map pinch zoom.
you can zoom in/out using two fingers.
- add event handler for multi touch.
(also fixed the TOUCH_HOLD_RANGE to use finger size as it should be)
SVN revision: 55920
I fixed a bug for elm_genlist_item_insert_before/after() declarations.
(Thanks glima.)
I should have modified EINA_ARG_NONNULL() when I added a new parameter.
1st and 5th parameter should not be NULL.
Anybody can review and apply this to upstream?
Thanks.
Daniel Juyung Seo (SeoZ)
SVN revision: 55880
Subject: [E-devel] [Patch] elm_genlist multi-touch smart callbacks
added
I added 6 multi-touch smart callbacks in elm_genlist, please refer to
below.
"multi,sweep,left" - Genlist has been multi-touch swept left.
"multi,sweep,right" - Genlist has been multi-touch swept right.
"multi,sweep,top" - Genlist has been multi-touch swept top.
"multi,sweep,bottom" - Genlist has been multi-touch swept bottom.
"multi,pinch,out" - Genlist has been multi-touch pinched out.
"multi,pinch,in" - Genlist has been multi-touch pinched in.
I think these smart callbacks are very useful for elm_genlist
multi-touch
effect.
If this patch have any issue, please let me know.
SVN revision: 55878
Subject: [E-devel] [Patch] elm_actionslider feature patch for
elementary.
This patch is for elementary elm_actionslider.
Mr. Sumanth created this patch. I reviewed it and fixed some.
This patch includes below features.
- Indicator label Set/Get APIs.
- _del_hook fix for wd->drag_button_base.
- Added magnet disable feature. _drag_button_up_cb fix for no magnet
handling. If magnet position is set to ELM_ACTIONSLIDER_NONE, it disables
magnetic. Added a test case to elementary_test.
SVN revision: 55872
Subject: [E-devel] elm_label patch(bugfix)
It's a bugfix patch of elm_label.
In strbuf_key_value_replace, null pointer reference can be occured
SVN revision: 55870
Subject: [E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after() APIs
I added tree feature support to
elm_genlist_item_insert_before/after() APIs.
This patch assumes that the previous patch, '[E-devel] [Patch] Tree
support
for elm_genlist_item_prepend() API.', is already applied to upstream.
So this patch does not include the changes of the previous patch.
This patch includes API break. I added parent parameter.
To support genlist group index feature, it should have a parent
parameter
like elm_genlist_item_append/prepend() do.
Raster already agreed to this API break.
I or my co-worker will introduce genlist group index feature today.
But for the reviewer's convenience, I separated this patch.
- 001.elm_genlist.patch.txt
Patch for src/lib/elm_genlist.c
- 002.elm_genlist.patch.txt
Patch for src/lib/Elementary.h.in, src/bin/test_genlist.c
- 003.elm_genlist.patch.txt
Due to API break, I changes other EFL libraries and applications on SVN.
SVN revision: 55869
Subject: [E-devel] [Patch] Tree support for elm_genlist_item_prepend()
API.
I added tree feature support to elm_genlist_item_prepend() API.
(elm_genlist_item_append() already supports tree.)
This patch is tested with elementary_test -> Genlist Tree.
Please review this and apply it to upstream.
SVN revision: 55868
elm_photocam widget does not support keyboard input.
This patch makes elm_photocam be able to process keyboard input such
as Left,
Right, Up, Down, PgDn, and PgUp key.
In addition, image will be zoomed in or out when '+' or '-' key in
keypad is pressed.
Please review it and let me know if there is any problem in this patch.
SVN revision: 55842
I found one small bug in elm_gengrid.c
"item" is used after "free(item)" in elm_gengrid_item_del() function.
Can anybody check about this ?
SVN revision: 55841
Subject: [E-devel] elm_map patch for supporting keyboard input
Most of elementary widgets can process keyboard input, but elm_map widget
has not. This patch makes elm_map be able to process keyboard input such as
Left, Right, Up, Down, PgDn, and PgUp key. In addition, map image will be
zoomed in or out when '+' or '-' key in keypad.
Please review it and let me know if there is any problem in this patch.
Merry Christmas!
SVN revision: 55840
Subject: [E-devel] [Patch] elm_bubble theme patch
I'm Sohyun Kim. Nice to meet you.
This is a patch for bubble theme.
The bubble has a region for icon, label and info text.
However, it has the region, if icon, label and info text are not set.
I modified theme and added edje signals.
1. add edje signal for label and info text state
2. remove text size for label and info text default state
-> set it on "visible" state
3. add base image state for info text only
SVN revision: 55839