Subject: Re: [E-devel] [Patch] [elm_entry] New APIs for user style
Thank you for your comments.
I would like to send you the modified patch.
Followings are my modification:
- Add my part to ChangeLog, AUTHORS files as Raster's comment.
- Add const to the parameter of elm_entry_text_style_user_peek and
example for pop and peek to test_entry_style_user as Daniel's comment.
SVN revision: 71557
This a team work, half of the borkage by zmike and half by me. I hope we succeed.
NOTE: It is better to do one smart object that you apply map on it, that to apply
map on it's 10 childs separately.
SVN revision: 71520
Patch by Jérôme Pinot <ngc891@gmail.com>.
- #link on the beginning of a new line does give ugly output:
http://ngc891.blogdns.net/pub/projects/debug/doxygen-formating-eww.png
- some typos
- some missing @c
- in elm_web, convert remaining @li parameter lists to @param
- minor random fixes
SVN revision: 71486
window representation.
The attached change to Elementary makes a small refactor to use
existing code that was already conditional on the Elm engine to
retrieve the underlying window - thus allowing elm_win_xwindow_get to
return 0 in the case when called on a Wayland based Elm window.
Patches have been tested against X11 and Wayland built together by
running elementary_test.
SVN revision: 71455
new schema.
els_icon smart object was brought to be the base of the image widget,
in the form of an image class.
An elm icon is now a elm image, with a little more on top of it.
An elm photo is a now base widget aggregating an icon.
Toolbar's internal usage of the former els_icon is now changed to
icons, instead.
Some naviframe instantiations were set to enable events during
transitions, because this code is buggy and my chages exposed the
problem. It will be fixed as soon as I get to port Naviframe.
SVN revision: 71429
Subject: [E-devel] [Patch][elm_map] Add New "loaded" signal
I want to add new "loaded" signal to elementary map. This signal
notify users when all map tiles are loaded. Timer is used for this signal.
Currently "tile,loaded" can be used for each separated tile. So the
users are hard to know whether all tiles are loaded or not.
Please review this patch.
SVN revision: 71406
Subject: [E-devel] [patch] allow copy and paste operations for
non-widget evas objects
I am currently implementing a clipboard for WebKit-EFL. When using
elm_cnp_selection_get and set function an evas object passed has to be
a widget. Currently in WebKit-EFL we are using an view which is an
Evas_Object, but not a widget. Sample WebKit applications like
EWebLauncher and tests applications does not use elementary so I
cannot obtain parent widget for a view object and finally we cannot
perform copy and paste operations.
Widgets are used in elm_cnp_selection functions to obtain
Ecore_X_Window. My patch leaves current way of obtaining it and adds
an another in case when the standard one fails. When Evas_Object is
not a widget I am trying to get an Ecore_X_Window using ecore.
SVN revision: 71381
Subject: [E-devel] [Patch][elm_map] Add elm_map_overlays_get &
elm_map_overlay_visible_get
I want to add 2 new APIs (elm_map_overlays_get & elm_map_overlay_visible_get).
There are no way to get the group overlays because group overlay,
something like virtual overlay, is created and deleted dynamically.
So elm_map_overlays_get returns total overlay's list and user can get
any type of overlays including group overlays.
Overlays which is grouped can not be visible. Because overlay grouping
is performed by elm_map, user do not know whether overlays are visible
or not. So elm_map_overlay_visible_get is added for this reason.
SVN revision: 71354
parent is deleted.
On Tue, May 22, 2012 at 4:46 PM, Sohyun Kim <anna1014.kim@samsung.com>
wrote:
>
> Hi all.
> When I use elm_notify, I got a crash in the deleting routine. (you
can test it in elementary_test > Video)
>
> When parent window of elm_notify is deleted, elm_notify set its
parent to NULL.
> However, it doesn't delete event callbacks of the parent window.
>
> In the smart_del callback of elm_notify, it tries to delete event
callbacks of parent window.
> However, its parent is already set to NULL, the deleting is skipped.
> Then the widget data gets freed.
> In this case, when other objects in the window are deleted, they can
create the parent window's event (e.g. CHANGED_SIZE_HINTS,,)
>
> Please find a patch to delete event callbacks when parent window is
deleted.
>
> Regards, Sohyun
SVN revision: 71307
There is a case that parent can be NULL when you call
elm_ctxpopup_add().
This reverts commit 8bc665a6ebc9daf0d5faa46223635f46f3d0f682.
SVN revision: 71305
<ohpowel@gmail.com>
On Mon, May 21, 2012 at 5:32 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> When ctx_popup is deleted, it calls "elm_widget_sub_object_del(parent,
> popup)" so that ctx_popup's parent can delete it's sub_ojbect,
> "ctx_popup".
> But this is not needed because parent already deletes it's sub-object
> in elm_widget.c
>
> Thanks
>
> --
> BRs,
> Kim.
SVN revision: 71301
Dear all, hello.
If an item of diskselector has only icon without label, then the icon
displays at left side of its space.
So if there is no label, the icon should display at the middle of its
space.
Please review the patch. Thanks.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Kim Shinwoo <kimcinoo.efl@gmail.com>
SVN revision: 71279
Instead of a global 400msec value, we now have 200msec between mouse downs.
E.g if the first timestamp is 0, we get:
valid: down(0) up(50) down(150) up(300)
invalid: down(0) up(100) down(201) up(250)
SVN revision: 71200
I've received feedback on being bad to expose the thumb's frame.
So, making it a base widget here. Let me know what you guys think.
SVN revision: 71176
Documentation was wrong too and code had a slight bug stopping
genlist from contracting to min size.
Optimize the case of COMPRESS + homogeneous mode to avoid
queue entirely and use existing known item sizes.
SVN revision: 71140
sometimes the only separators are shown even though the items are hidden.
So the separator's visibility is desided by it's previous item.
SVN revision: 71093
behaves.
Containers like boxes should not be resizing themselves, but flagging
desireable sizes via size hints to parent widgets.
Let it be that way for now, though. Ctxpopup is giving me A LOT OF
HEADACHE to port to the new schema without having to rewrite it :(.
It has the craziest code flow on sizing things, and of course that
code is uber fragile to borks.
SVN revision: 71085
should be called prior to edje_object_part_swallow. This is because
evas-callback function(about EVAS_CALLBACK_CHANGED_SIZE_HINTS) which is
registered by _smart_sub_object_add should be called after the one
registered by edje_object_part_swallow.
SVN revision: 70985
Hi! All,
[test_menu]
I have added test code for following APIs, even though Elementary 1.0 is
released. :-)
- elm_menu_close()
- elm_menu_item_icon_name_set()
- elm_menu_item_is_separator()
- elm_menu_item_selected_set()
- elm_menu_parent_set()
Then, please review those patches and keep on the upstream.
Sincerely,
Shinwoo Kim.
SVN revision: 70983
* Fileselector test: add a check to enable/disable buttons
Updated Changelog and NEW, also add myself as authors...
btw: the EIO code in the Fileselector is crazy-complex, about 200
lines of code just to have the list of files ina dir... :/
SVN revision: 70965
Currently there's semi-ready code (1 liner) that does nothing. Hermet, you
promised you'll add ui-mirroring support AGES ago when this widget got in.
SVN revision: 70960
NOTE: This is not very robust yet. But that's not related to this patch.
You can see the issue when switching between two different theme in
elementary_config. At some point elementary_test start to loose information.
SVN revision: 70895
Hi Mr. Park,
Please find attached theme bug fix patch of elm_colorselector.
Bug:
1. Colorselector spreading its size to whole window.
2. Colorselector size not adjusting properly when shifted in between different modes.
Change Log: Color selector Theme fixed to adjust size properly based on mode and demo
application appropriately fixed with proper size.
Signed-Off-By : Shilpa Singh<shilpa.singh@samsung.com>
Thanks & Regards
Shilpa Singh
SVN revision: 70869
Hi!
I have just modified the elm_menu.c because there are some improper
indentation.
That's it... Thanks.
Sincerely,
Shinwoo Kim.
Signed-Off-By: Shinwoo Kim <kimcinoo@gmail.com>
SVN revision: 70758
widget hierarchy.
Win inherits directly from Elm_Widget_Smart_Class, while inwin is now
an elm layout.
Note that elm_widget_sub_object_list_get(), which was an unecessary
hack only used on win, was killed.
SVN revision: 70717
class: elm_layout.
This will be, besides the codebase for the elm_layout widget, a common
base for all other widgets which got an edje layout as a basis for
their decoration.
From now on, all elm_layout_* namespaced fuctions will function
on objects inheriting from this base:
- elm_layout_content_set
- elm_layout_content_get
- elm_layout_content_unset
- elm_layout_text_set
- elm_layout_text_get
(recovered from deprecated header -> not anymore)
- elm_layout_sizing_eval
- elm_layout_data_get
- elm_layout_edje_get
- elm_layout_file_set
- elm_layout_theme_set
- elm_layout_box_append
- elm_layout_box_prepend
- elm_layout_box_insert_before
- elm_layout_box_insert_at
- elm_layout_box_remove
- elm_layout_box_remove_all
- elm_layout_table_pack
- elm_layout_table_unpack
- elm_layout_table_clear
Three missing functions on layouts were added, then:
- elm_layout_signal_emit
- elm_layout_signal_callback_add
- elm_layout_signal_callback_del
Naturally, the elm_object_ namespaced counterparts of those will also
function (they will be deprecated on the future).
SVN revision: 70708
This is for general purpose containers in Elm, those supporting
- elm_object_part_content_set()
- elm_object_part_content_get()
- elm_object_part_content_unset()
SVN revision: 70707
resize objects to new schema.
sub-object-{add,del} new class functions got their bodies in. One by
one, the old elm_widget_ namespaced calls to them got to be migrated
to the class calls.
A resize object is now a sub-object, too. This should be like that
from the start -- we share code and avoid callback duplication -- what
leaded to a plethora of bugs.
SVN revision: 70705
properly by real widgets.
I'm also creating a *compatibility* class on top of it, which extends
the old (unique) one to its old components, so that everything goes
unnoticed for the widgets.
Next, we'll be accessing class functions for widget hooks *on the base
class*, which will be proxied back to the instance ones.
Then, one by one the widgets will be translated to a proper
hierarchical smart class parentage, making extensibility and reuse
much better.
Last, but not least, since we'll be moving these hooks to the class,
where (almost) everything is a function, let's adapt to the future --
take away the "_func" suffix from them.
NB: there is ONE hook and associated data which was kept on the base,
for now: "show_region" stuff. I did that because scrollers need that
in order to work, right now. Keep in mind, though, the scrollers will
be reworked, so that fields ought to be changed soon, too.
SVN revision: 70704
in naviframe. Patch by Shilpa Onkar Singh <shilpa.singh@samsung.com>
On Thu, May 3, 2012 at 2:30 PM, SHILPA ONKAR SINGH
<shilpa.singh@samsung.com> wrote:
> Hi All,
>
> Please find attached, patch for elc_naviframe bug fix: "wrong signal
sent when subtitle,title is set".
>
> Change Description:
> Bug Fix: Wrong signal sent when title/subtitle is set in naviframe.
>
> Thanks & Regards
> Shilpa Singh
SVN revision: 70685
using elm_widget_focus_direction_go function, focus will be moved from
the current focused object to the near object in one direction.
Direction can be set by degree(for easy usability). Degree changes
clockwise, i.e. 0 means UP, 90 means RIGHT, 180 means DOWN, and 270
means LEFT. You can select any direction by changing this degree.
SVN revision: 70681