Summary: mapi have to be set NULL after free(m->api)
Reviewers: kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3756
Eo's syntax has changed (see efl.git for more info), this adjusts
elementary accordingly.
This is a merge commit that merges my branch will all of the fixes
I just ran my script (email to follow) to migrate all of the EFL
automatically. This commit is *only* the automatic conversion, so it can
be easily reverted and re-run.
If the scale is set on an object before contents are set, it will not
pass to them. Because of this, in the test, scale of the first label
remains 1.0, i.e the window scale, instead of 0.5.
The patch modifies the order of the instructions by setting the scale
after setting the label as content of the frame.
Summary: Radio inherits from Check now and remove the duplicate codes
Reviewers: yashu21985, cedric, tasn, raster
Reviewed By: raster
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D3747
Switch to use a lcov config file which geninfo_auto_base and remove hard coding
the base dir to src/lib. geninfo_auto_base is designed for a use case like
ours where we have several base dirs (lib, bin, tests, ...) and it detects them
automatically. This fixes failures in a coverage run like this:
genhtml: ERROR: cannot read
/srv/build/workspace/manual_elm_gcc_x86_64_exactness_coverage/src/lib/test_win_state.c
Where the file is simply looked for in the wrong directory.
gcc thinks the vars may in theory be uniitiialized. it's right but it
won't actually happen. but having noise in warning output is bad, so
fix the warnings so we can focus on the real bugs/issues/warnings
Summary:
After genlist/genrid items are cleared, item highlight still
remains in blank space. This patch fixes this by updating highlight.
Test Plan:
elementary_test -to fileselector
enter blank directory and see highlight still remains
Reviewers: jpeg, SanghyeonLee, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3683
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Check for all error conditions case in elm_spinner_label_format_set
and set label format only if its valid.
Signed-off-by: Shilpa Singh <shilpa.singh@samsung.com>
@feature
Test Plan:
1. Launch elementary test spinner
2. Set invalid formats e.g. formats with out %, formats with more than
one format specifier "%d %s" etc:-
Reviewers: jpeg, cedric
Reviewed By: cedric
Subscribers: govi, buds, subodh6129
Differential Revision: https://phab.enlightenment.org/D3720
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
without size hints on the edje object, a list item will never be sized
accurately, meaning that the size hints set on subobjects (icon, end) are
ignored in nearly all cases, and any previous sizing which was accurate was,
in fact, merely coincidentally accurate
@fix
typecast const char * to void * and pass ptr to free() since it doesn't modify the value pointed to,
either conceptually or in practice, it merely looks up the memory block using the pointer and deallocates it.
@fix
if a content's size hints change, reapplying the list's size hints
to override existing hints is required to prevent some list items from
having a bad layout
@fix
Summary: In "compile with" comment, filenames are different from the actual ones.
Reviewers: cedric, Oleksander, Hermet
Reviewed By: Oleksander, Hermet
Differential Revision: https://phab.enlightenment.org/D3722
Summary:
move focus out of genlist by pressing "up" key when no item
is selected.
Test Plan: elementary_test -to fileselector
Reviewers: SanghyeonLee, cedric, Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D3721
Summary:
fix the wrong operation of mirrored set.
when mirrored set is applied, notify change the theme using mirrored flag.
however, it is unnecessary operation.
@fix
Reviewers: Hermet, kimcinoo
Reviewed By: kimcinoo
Differential Revision: https://phab.enlightenment.org/D3700
Summary: No use of top object if not editable.
Reviewers: cedric, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D3719
Move declarations of types used in elm_widget.eo to elm_general.eot and
elm_widget.eo.
Give them a Eolian name and use it instead of the old ones.
Correct the type name of some other types used as method parameters, by
using the Eolian names instead of legacy/generated names.
Reorganize the positions of elm_widget.eo.h inclusion and
of callback type declarations in elm_widget.h.
This make a clearer distinction of the types in elm_widget.h that are
still required in elm_widget.eo.h.