Summary:
API changed from "edje_object_signal_callback_add()" to "elm_layout_signal_callback_add"
to following code refactoring.
Reviewers: seoz, woohyun, Jaehyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2102
Summary:
The _text_aliases value exists. but never use here on layout for text part aliases.
in addition, i think that "elm,text" should be the default part for text set.
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2116
Summary:
When parent is resized, popup keeps its original size.
This patch makes popup have proper size in proportion to parent's size.
T2082
Test Plan: You can check the effect of this patch in "elementary_test popup".
Reviewers: seoz, Hermet
Subscribers: stefan_schmidt, J5lx, seoz
Differential Revision: https://phab.enlightenment.org/D2121
Summary:
This restack callback added for support previous tree [parent - notify - popup].
The popup has been redesigned to have correct tree [parent -popup - notify].
So the restack callback does not need anymore.
Test Plan:
1. Run elementary_test
2. Execute popup sample.
3. Activate popup which has restack feature.
4. Check the result.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2127
Summary:
Since this patch ctxpopup is able to report its size which is equal to 1 element of list.
This can be treated as another bug (list visibility implementation must be so list will be counting its size dynamic on every item add)
Might be also ignored.
Test Plan:
1. Use application provided in T2042 (should have coordinates greater then 0).
2. Using atspi check is accessible element is visible. (with patch ctxpopup will be visible, without ctxpopup and its children will have status visible and showing set to FALSE)
Reviewers: raster, seoz, Hermet
Subscribers: m.jagiello
Projects: #elementary
Maniphest Tasks: T2042
Differential Revision: https://phab.enlightenment.org/D2045
Summary:
Add extra check to prevent crashing when user clicks configuration
test from elementary_test window
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D2086
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Item width max size set as 130 in edc before, i thinks that value doen't have any meaning,
so i changed the item max width size to follow container width size.
For modification, item size calc, box resize logic changed.
Test Plan:
1. Run elementary_test
2. Execute multibuttonentry sample.
3. Input some text for make item.
Reviewers: Hermet, seoz, woohyun, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1970
Restacking not selected item should be selected after it is done.
@fix
Test Plan:
1. run in console
> elementary_test "Genlist Reorder Mode"
2. Switch to reorder mode
3. Select Item #6
4. Try to restack Item #4
(not selecting it, but holding mouse on it and moving down)
5. See that Item #4 and Item #6 is not selected
Reviewers: cedric, Hermet, raster, seoz
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1931
this adds logic in elm widget and elm win to figure out how to
automatically show a focus hilight when switching focus, or to hide
it. this really should be the default mode, thus in all default
profiles (default, standard, mobile) it's turned on. this means if you
tab or shif+tab or use arrow keys to switch focus, the focus hilight
will magicallly appear. click with a mouse to change focus and it'll
disappear assuming you want to use the mouse to do things. If focus is
explicitly turned on in config or in the window by api, then this has
no effect and focus will remain on all the time. this adds apis to
change these config values and options in the default elm config tool
to swizzle them as well as config upgrade handling for existing configs.
@feature
Summary:
Issue: Focus was not getting transferred individually on arrow buttons and text area.
Solution: Remove the usage of image parts and text parts and replace them with buttons
so as to handle the focus transfer normally than forcibly via smart event.
hence Focus next hook and focus direction hook is implemented.
Signed-off by: Subodh Kumar<s7158.kumar@samsung.com>
Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>
Test Plan:
Use keyboard keys on spinner and test focus transfer, enable accessibility and test
accessibility.
Reviewers: woohyun, Hermet, shilpasingh, raster, seoz
Reviewed By: shilpasingh, raster
Subscribers: stefan_schmidt, raster, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D1911
Removed default disable automatic mirroring of hoversel.
Summary:
Removed below API call for hoversel, hover, box and button object
elm_widget_mirrored_automatic_set(obj, EINA_FALSE);
Modified theme of "elm/button/base/hoversel_vertical_entry/default" to remove console errors due to theme, and modified text.align to -1 as 'x' value to set auto align for Arabic text.
Modified example hoversel_example_01.c to illustrate mirroring functionality
@fix
Reviewers: Hermet, seoz, tasn
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D1910
Summary:
1. Implemented genlist mode ELM_LIST_EXPAND
2. Implemented content_min_limit function which override scroll interface.
This function will be used by call API elm_scroller_content_min_limit.
This function will set the object minimum size as its scroll content size,
if parameter value is EINA_TRUE.
@feature
Test Plan: Add new test case in test_popup.c
Reviewers: raster, seoz
Subscribers: stefan_schmidt, bluezery
Differential Revision: https://phab.enlightenment.org/D1279
when a layout's theme is changed by elm_layout_theme_set, the edje is updated
according to the widget's states such as 'disabled' or 'highlight_in_theme'.
but the update is dropped for elm_layout_file_set.
this patch tied up the codes into _visuals_refresh function
so that the same update happens for elm_layout_file_set.
@fix
Summary: When running the E startup wizard using DRM, the cursor ends
up getting unset (and never reset) due to the DRM engine not having a
wayland window. To fix this, we will test the the engine being DRM and
if so then set the cursor->use_engine to false so that it defaults to
ecore_evas_object_cursor calls (which work on DRM).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: If we are unsetting the cursor for an object, then if it's an
object on a wayland window, we should be callbacking
ecore_wl_window_cursor_default_restore
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
There is no reason why drop targets callbacks registered for a specific
type would be invoked when a not supported data is dragged.
This patch fixes it by comparing the data type and the callback type of
the drop target. Only the callbacks supporting the data type are
invoked.
During a DnD position event, we need to find the first dropable target
located under the mouse pointer; one of its callbacks has to support
at least one of the types of the dragged data.
This search process was done by strcmp-ing types for every drop target
and for each of their types until a good target is found.
This patch improves the process by comparing types formats, i.e and-ing bits
vectors.
Summary:
When box has expanded items (evas_object_size_hint_weight_set() with EVAS_HINT_EXPAND)
and homogeneous is set (elm_box_homogeneous_set() with EINA_TRUE),
there is a bug that it miscalculates its items size omitting padding size (space among items),
so the last item looks cropped or having smaller size than others.
This patch makes box calculate its items' size correctly.
T2033
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Maniphest Tasks: T2033
Differential Revision: https://phab.enlightenment.org/D2016
Summary:
If user sets the limit value using elm_datetime_field_limit_set() API, the filed value will be recalculated.
Even though the value changed in case, value changed signal didn't send to user before.
@fix
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1980
Summary:
When an item is realized, select/disable/expand signal emission to the view object of an item was handled correctly,but there are no updating code for focus state.
@fix
Test Plan: tested by editing genlist/genlist item edc to react on elm,state,focused and move scroll signals to unrealized/realized item again.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: eunue
Differential Revision: https://phab.enlightenment.org/D2024
Summary: The API "elm_box_horizontal_get" missed @ingroup tag. so i added the tag for grouping when doxygen making API documentation.
Reviewers: Hermet, JackDanielZ, Jaehyun, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1966
Summary:
Thumbscroll is disabled in default configuration,
but "scrollable" feature in panel only works when thumbscroll is turned on.
To make "scrollable" work always in elementary test,
this patch enables thumbscroll temporarily regardless of configuration.
(configuration is restored when sample window is closed.)
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1983
Summary:
evas_image_orient_set is a newly added API to set orientation of evas image.
Using this API to set orientation of image widget.
Also removed Elm_Image_Orient enums and replaced it with Evas_Image_Orient enums.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: raster, seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1987
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This reverts commit 83f94464f1743cfa55e6b39704c605978edcee19.
This is incorrect. both windows evas are different,
we cannot set the child window as the resize object.
This reverts commit 72ef635ff3b8939509ecfb29ecf19e465b40e652.
changing a test so that it will not crash in a valid use case is not an appropriate fix.
ref T1973
Summary:
This small application for quick testing main features and changes in Evas 3D.
Main features: effects shadow, fog, measuring fps, load 3D model, panel for change
sets light and camera.
Reviewers: Hermet, raster, cedric
Differential Revision: https://phab.enlightenment.org/D1953
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_transit_go() is executed immediately after it is called.
elm_transit_go_in() starts transit in given seconds.
@feature
Reviewers: Hermet, seoz
Reviewed By: seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1954
Summary:
_current_item_change() called at _item_select() internally.
it means _current_item_changed() called two times in vain.
so that's why item select callback called two times.
@fix
Test Plan:
1. Run elementary_test
2. Excute multibuttonentry sample.
3. Added some items and click the item area.
4. Select signal called two times.
Reviewers: Hermet, woohyun, JackDanielZ, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1955
now when a whele event comes in, 1. the amount we scroll accelerates
based on time between wheel events (the faster wheel events come out,
the more accel), and 2. we animate to the new position providing a
smooth transition to the new spot rather than a jump. very visually
nice.
@feature
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
Summary:
elm_coords_finger_size_adjust() is called twice.
It might not be intended.
Reviewers: Hermet, Jaehyun, seoz
Reviewed By: seoz
Subscribers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1924
this fixes a deprecation of elm engine done just before 1.13 release
that ends up breaking "make doc" and also will make ELM_ENGINE env var
stop working (the latter was intentional). but since this is relied on
for things like make doc - keep the env var and haveit set preferred
engine and let people migrate away from using the engine var EXCEPT
for things like the shot engine
@fix
Summary:
There was no consistency with another widget which has item object, basically widgets has Elm_Object_Item object for own's item object.
but multibuttonentry used edje object for item object before.
Test Plan:
1. Run elementary test.
2. Execute multibuttonentry.
3. Doing variety action on multibuttonentry widget.(add, delete, key event, focus etc...)
Reviewers: seoz, woohyun, Jaehyun, Hermet, JackDanielZ
Subscribers: herdsman, cedric
Differential Revision: https://phab.enlightenment.org/D1864
Summary:
elm_layout_content_set API calls _elm_panel_elm_container_content_set func.
The panel widget checks the given "parts" string is whether "elm.swallow.event" or not.
To avoid error message and set the given object to the "elm.swallow.event" internally,
the panel widget need to call *_content_set for "elm.swallow.event" part using eo_do_super.
@fix
Test Plan: elementary_test -> panel
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1949
Summary:
1) According to description in .eo file,
some APIs return not 0 when the given object is NULL or not proper object.
But, several APIs are not implemented as those description.
Now, they will return a value as description.
2) If there is no description about the return value when the API fail,
put description according to pair API or old version of elementary.
@fix
Reviewers: woohyun, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1933
Summary:
Resolved FIXME filled all smart callbacks and also set it in the constructor
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1876
the elm config tool only lets you set accel preference. if you set
none, then the old engine config takes charge, but there is no way to
change/set this, so deprecate the old engine set and don't use it.
this accel preference has been around for a while, so use it now
instead.
Summary: Added indicator_visible_mode to each slider in order not to make elm_config controlls every sliders.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1887
Summary:
When ecore_evas_window_profile_supported_get API return EINA_FALSE,
elm_win widget should not get profile from ecore_evas_window_profile_get API.
@fix
Reviewers: woohyun, Hermet, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1943
while this is technically an abi break, it should actually have no
real impact. it will have warnings - sure, but running existing code
will simply not see the extra parammeters on the stack and not use
them so it'll continue to work. if we removed paramms, we'd be in
pain. (same applies to params passed in registers).
this fixes T2031
Summary:
There is a bug that text disappears when theme is changed after label shown.
This patch fixed it.
@fix
Reviewers: woohyun, Hermet, Jaehyun, seoz
Subscribers: Jaehyun, seoz
Differential Revision: https://phab.enlightenment.org/D1923
Summary:
tooltip could be hide by the other object which have lower layer than target object of tooltip.
the layer of content could be changed, when is set to the tooltip as a content.
@fix
Test Plan: check added test lines
Reviewers: cedric, jpeg, seoz, raster
Reviewed By: raster
Subscribers: singh.amitesh, stefan_schmidt, seoz
Differential Revision: https://phab.enlightenment.org/D1889
Summary:
Label should not start sliding before elm_label_slide_go() is called.
However, label starts sliding automatically,
because resize callback emits slide start signal.
This patch prevents label from sliding before calling elm_label_slide_go().
@fix
Reviewers: woohyun, Hermet, seoz
Subscribers: CHAN, woohyun
Differential Revision: https://phab.enlightenment.org/D1906
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
but elm_gengrid_realized_items_update doesn't free Eina_List.
So memory leak is happens.
@fix
Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.
Reviewers: raster, seoz
Differential Revision: https://phab.enlightenment.org/D1903
Summary:
It could success only when the widget was visible.
The API must return EINA_TRUE if buffer and size has no problem, not visiblity of widget.
@fix
Reviewers: Hermet, woohyun, jpeg
Differential Revision: https://phab.enlightenment.org/D1917
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When layout clicked, "elm_widget_on_focus()" called with "entry_focus_in()" callback.
The "view update" and "focus set to entry" already call in those callbacks, so i deleted duplicate code and it also make focus issue when user click the entry to add item.
@fix
Test Plan:
Run elementary_test.
1. excute multibuttonentry.
2. click the entry area.
3. see the elm_widget_on_focus called twice.
(layout callback function called view update -> elm_box_unpack called in view update ->
entry lose focus -> on_focus_callback call again)
Reviewers: Hermet, seoz, Jaehyun_Cho, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D1902
Summary: The API must return ELM_WIN_UNKNOWN (-1) when the given object is improper.
Test Plan: None.
Reviewers: woohyun, JackDanielZ, seoz
Differential Revision: https://phab.enlightenment.org/D1907
Use the min between w and h of the evas object to
request the size in the icon theme. Fdo icon are always
square (1:1) so min seems correct.
Also improved the test to include a test that do
not relay on the size_hint_min of the icon.
Now in all the test I have done always the correct
fdo icon are used.
This reverts commit 75176a789981bd6b1ef0bfcc95793c896b5bde07.
Was not the correct solution, as min_size can be smaller than
the real wanted size. Need to find another solution.
Thanks TAsn to spot this
This @fix fdo icons to load the correct image for the requested size.
Whitout this the small images (16x16) was never used, because once a big
(64x64 for example) image was loaded, that size was used as min.
See the Icon Standard test for a better explanation
The code there was trying to reload the icon to have an
image that should match the requested size, this was totally
wrong, the calculation was always resulting in an image bigger
than the needed.
It was also useless as this logic is yet handled in the resize
callback.
You can now select the size of the icons in the list and
also added a single icon that you can resize.
The size of the icons is important as icon themes usually
provide different images for different sizes.
This test now spot out some errors in elm_icon wrt icon
sizing, will fix soon
This fixes the side effect that introduced from 1e06309be42fd2b5d0900b16da0178215c111681
Since transit has supported adding a map effect on the previous map status,
transit tried to access object-state map pointer.
but theses map pointer won't be valid if the transit keeps the last state
because it doesn't back up any object-state data.
- Do not set unnecessary min size for the icons. Just follow list's item
size naturally.
- Do not free unnecessary list which was already freed by
EINA_LIST_FREE.
- Do not set align for the window resize object which is not required to
be set.
- Follow conventional way of pointer declaration.
Previously, entry set handlers' style as default when they are created
and changed style on theme_apply function. But in usual scenario, users create
entry and set style before handlers are created, so when they are created
the style is set as default regardless of the style users already set.
This patch fixes it.
@fix
This reverts commit f99be3a1d6bdc63153598b592b5437c33da44bf0.
The API is not ready to be released. Please see the thread on the e-devel
mailing list under this subject. This can get another try in the 1.14
release cycle.
Conflicts:
src/lib/elm_genlist.c
Summary:
Fix crach issue caused by multiple transit effects on a single object.
This patch prevents deleting obj_data while the obj_data is still used by other transit objects.
This fix is related to commits "Support zoom keeping current map effect."(60214e6a172e42303fdfc69ef3d1996b25132242)
and "Support rotation keeping current map effect."(1e06309be42fd2b5d0900b16da0178215c111681).
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1878
user request was ignored if they calls the genlist_item_selected_set(true)
to another item in an item selected callback. because genlist made
the selected item highlighted after user "selected" callback.
The behavior had been changed on my genlist refactoring,
so the behavior was actually just restored.
This issue resolves T2020
Summary:
Fix to support zoom rate zero by using evas_map_util_zoom() instead of evas_map_util_3d_perspective().
@fix
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1877
Note that the iterate function will never trigger the idler that are registered
in Ecore. That's by definition. I changed the code to actually use the full
main loop and trigger the change detection on idle enterer. That should be enough
for Elementary as all idler should logically affect the visual aspect of something
at some point and exit idle.
Thanks marcel-hollerbach@t-online.de for helping me debug this issue.
This reverts commit c80b24baf815e35c160bf0dbe8ecae6ea247aef8.
this broke the selection callback completely and makes every genlist app unusable.
please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.
Carsten Haitzler
Daniel Juyung Seo
ChunEon Park
woochan lee
Jee-Yong Um
kabeer khan
Mike Blumenkrantz
Sung-Taek Hong
Vitalii Vorobiov
Subodh Kumar
Shobhit
Andrii Kroitor
VBS
Stefan Schmidt
Jaeun Choi
Chris Michael
Daniel Zaoui
Daniel Zaoui
Cedric BAIL
Tom Hacohen
SangHyeon Lee
Andy Williams
Oleksandr Shcherbina
Jee-Yong Um
Daniel Kolesa
Youngbok Shin
Shinwoo Kim
Jaehwan Kim
Amitesh Singh
Davide Andreoli
Jaehyun Cho
WooHyun Jung
Lukasz Stanislawski